Re: [PATCH v6 4/4] hwmon: (sht3x) Add support for GXCAS GXHT30

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] Redundant compatible string in the OF match table.
- [Low] Missing update to subsystem documentation (`Documentation/hwmon/sht3x.rst`).
- [Low] Missing Kconfig help text update.
--

commit 907d39a1530eacc8aee2b5e489cdd9c94b10ce78
Author: Zaixiang Xu <zaixiang.xu.dev@gmail.com>

hwmon: (sht3x) Add support for GXCAS GXHT30

This commit adds support for the GXCAS GXHT30 humidity and temperature sensor.
The GXHT30 is described as being software compatible with the Sensirion SHT30.

> diff --git a/drivers/hwmon/sht3x.c b/drivers/hwmon/sht3x.c
> index 6437568aaf73..f52114c13edb 100644
> --- a/drivers/hwmon/sht3x.c
> +++ b/drivers/hwmon/sht3x.c
[ ... ]
> @@ -948,6 +949,7 @@ static const struct of_device_id sht3x_of_match[] = {
>  	{ .compatible = "sensirion,sts31", .data = (void *)(uintptr_t)sts3x },
>  	{ .compatible = "sensirion,sts32", .data = (void *)(uintptr_t)sts3x },
>  	{ .compatible = "sensirion,sts35", .data = (void *)(uintptr_t)sts3x },
> +	{ .compatible = "gxcas,gxht30", .data = (void *)(uintptr_t)sht3x },

Is this explicit compatible string entry necessary in the driver?

The device tree binding for the GXHT30 enforces using sensirion,sht30 as a
fallback compatible string. Since the device tree node will provide
sensirion,sht30 in its compatible list, and the driver already matches
sensirion,sht30 using the same sht3x driver data, the fallback should handle
the matching automatically without needing an explicit entry here.

This isn't a bug, but should the documentation and Kconfig be updated for the
new chip?

The patch adds a new hardware chip but doesn't update the supported chips
section in Documentation/hwmon/sht3x.rst, or the help text for
CONFIG_SENSORS_SHT3x in drivers/hwmon/Kconfig. Updating these is expected
when adding support for a new device to the hardware monitoring subsystem.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/1777374569-59233-1-git-send-email-zaixiang.xu.dev@gmail.com?part=4