Re: [PATCH 1/3] dt-bindings: hwmon: pmbus: add Delta E50SN12051 binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The devicetree binding schema is missing the '%YAML 1.2' declaration.
- [Low] The devicetree example uses a device-specific node name 'e50sn12051@40' instead of a generic class name.
--

commit 91ccfd1047b5355c8ba1210c7c4b1e1a74f2e8cc
Author: Colin Huang <u8813345@gmail.com>

dt-bindings: hwmon: pmbus: add Delta E50SN12051 binding

This commit adds the devicetree binding documentation for the Delta
E50SN12051 PMBus-compliant device. It supports reading voltage, current,
and temperature over the PMBus interface.

> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/delta,e50sn12051.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/delta,e50sn12051.yaml
> new file mode 100644
> index 000000000000..362cbbf10bfe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/delta,e50sn12051.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

This isn't a bug, but shouldn't this include the %YAML 1.2 declaration
immediately after the SPDX license identifier and before the '---' document
separator? Without this, schema validation tooling might fail to process the
file correctly or report formatting errors.

> +---
> +$id: http://devicetree.org/schemas/hwmon/pmbus/delta,e50sn12051.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#

[ ... ]

> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        e50sn12051@40 {

This isn't a bug, but could this example use a generic node name like
sensor@40 or hwmon@40 instead of the device-specific e50sn12051@40? This
would help comply with standard devicetree practices and prevent dtc
warnings during validation.

> +            compatible = "delta,e50sn12051";
> +            reg = <0x40>;
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260429-add-e50sn12051-v1-0-c101e6c80bbb@gmail.com?part=1