Re: [PATCH 3/3] hwmon: (pmbus) add support for Delta E50SN12051

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The driver uses `pmbus_do_probe()` which is exported in the `PMBUS` namespace, but fails to include `MODULE_IMPORT_NS("PMBUS");`.
- [Low] The driver includes `<linux/debugfs.h>`, `<linux/kstrtox.h>`, and `<linux/of_device.h>` when they are either unused or technically incorrect.
--

commit 8b9d265ffa7130b1c2d0afd9fd591168b6c43156
Author: Colin Huang <u8813345@gmail.com>

hwmon: (pmbus) add support for Delta E50SN12051

Add the pmbus driver for Delta E50SN12051 600W Non-isolated 1/8th Brick
DCDC Power Modules.

> diff --git a/drivers/hwmon/pmbus/e50sn12051.c b/drivers/hwmon/pmbus/e50sn12051.c
> new file mode 100644
> index 000000000000..56935e9543b6
> --- /dev/null
> +++ b/drivers/hwmon/pmbus/e50sn12051.c
> @@ -0,0 +1,60 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Hardware monitoring driver for E50SN12051
> + */
> +
> +#include <linux/debugfs.h>
> +#include <linux/i2c.h>
> +#include <linux/kstrtox.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>

Are linux/debugfs.h and linux/kstrtox.h used in this driver? I don't see
any debugfs interfaces or string parsing functions being utilized.

Also, since this driver only uses of_device_id from linux/of_device.h,
should it include linux/mod_devicetable.h instead to follow the standard
device match table patterns?

[ ... ]

> +static int e50sn12051_probe(struct i2c_client *client)
> +{
> +	struct pmbus_driver_info *info;
> +
> +	info = devm_kmemdup(&client->dev, &e50sn12051_info, sizeof(*info),
> +			    GFP_KERNEL);
> +	if (!info)
> +		return -ENOMEM;
> +
> +	return pmbus_do_probe(client, info);
> +}

[ ... ]

> +MODULE_AUTHOR("Kevin Chang <kevin.chang2@amd.com>");
> +MODULE_DESCRIPTION("PMBus driver for E50SN12051");
> +MODULE_LICENSE("GPL");

Since this driver calls pmbus_do_probe() which is exported in the PMBUS
namespace, does it need a MODULE_IMPORT_NS("PMBUS") declaration?

Without it, modpost might fail the build with a missing namespace import
error if CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS is not enabled.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260429-add-e50sn12051-v1-0-c101e6c80bbb@gmail.com?part=3