Re: [PATCH 7/7] hwmon: (pmbus/adm1266) include adapter number in GPIO line label

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The I2C adapter number is incorrectly formatted as hexadecimal instead of decimal in the GPIO line label.
--

commit 79ede8d83182247b49e64822f8f1d3ea0161b1cd
Author: Abdurrahman Hussain <abdurrahman@nexthop.ai>

hwmon: (pmbus/adm1266) include adapter number in GPIO line label

This commit updates the GPIO line labels in the ADM1266 driver to include
the I2C adapter number. This change disambiguates the labels when multiple
devices reside at the same I2C address on different buses.

> diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c
> index 07c20746f0831..ec6a2c9167d82 100644
> --- a/drivers/hwmon/pmbus/adm1266.c
> +++ b/drivers/hwmon/pmbus/adm1266.c
> @@ -293,8 +293,9 @@ static int adm1266_config_gpio(struct adm1266_data *data)
>  	int i;
>  
>  	for (i = 0; i < ARRAY_SIZE(data->gpio_names); i++) {
> -		gpio_name = devm_kasprintf(&data->client->dev, GFP_KERNEL, "adm1266-%x-%s",
> -					   data->client->addr, adm1266_names[i]);
> +		gpio_name = devm_kasprintf(&data->client->dev, GFP_KERNEL, "adm1266-%x-%x-%s",
> +					   data->client->adapter->nr, data->client->addr,

Is the use of %x intended for the I2C adapter number here?

I2C adapter numbers are conventionally represented as decimal integers in
Linux (e.g., i2c-10 or 10-0040). Formatting the adapter number as hexadecimal
means that bus numbers of 10 or greater will be displayed with letters (e.g.,
bus 10 becomes a, resulting in adm1266-a-40-...).

Would using %d for the adapter number better match standard I2C identifiers?

> +					   adm1266_names[i]);
>  		if (!gpio_name)
>  			return -ENOMEM;
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508-adm1266-v1-0-ec08bf29e0ce@nexthop.ai?part=7