Re: [PATCH v2 1/5] powercap: arm_scmi_powercap: Log number of powercap domains

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The log message incorrectly reports the number of 'Initialized' domains using the count of 'Discovered' domains, leading to inaccurate and contradictory logs.
- [Low] Format string type mismatch for `pr->num_zones`.
--

commit bbfaa4d885154a2acd690976aeb604fa1c8f0eb4
Author: Alex Tran <alex.tran@oss.qualcomm.com>

powercap: arm_scmi_powercap: Log number of powercap domains

This commit adds a debug log to report the number of powercap domains
discovered from the firmware during probe. This helps confirm the firmware
exposed powercap resources.

> diff --git a/drivers/powercap/arm_scmi_powercap.c b/drivers/powercap/arm_scmi_powercap.c
> index ab66e9a3b1e2c..3efe3743cce0a 100644
> --- a/drivers/powercap/arm_scmi_powercap.c
> +++ b/drivers/powercap/arm_scmi_powercap.c

[ ... ]

> @@ -496,6 +496,7 @@ static int scmi_powercap_probe(struct scmi_device *sdev)
>  		return ret;
>  
>  	dev_set_drvdata(dev, pr);
> +	dev_dbg(dev, "Initialized %d powercap domains\n", pr->num_zones);

Are all of these domains actually initialized?

During the probe process, domains using an abstract power scale are
explicitly skipped and marked as invalid (spz->invalid = true).
scmi_zones_register() also tracks and logs the actual successfully
registered count.

If there are skipped domains, this will produce confusing logs, such as
"Registered 3 SCMI Powercap domains !" from scmi_zones_register() followed
by "Initialized 5 powercap domains" here.

Should the log message say "Discovered" instead of "Initialized" to match
the commit message?

Also, this isn't a bug, but does this code use the correct format specifier
for pr->num_zones? Since num_zones is an unsigned int in struct
scmi_powercap_root, should this use %u instead of %d?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-scmi-client-probe-log-v2-0-36607e9dd540@oss.qualcomm.com?part=1