Re: [PATCH v2 4/5] reset: reset-scmi: Log number of reset domains

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The dev_dbg() statement uses the '%d' format specifier to log `data->rcdev.nr_resets`, which is defined as an `unsigned int` in `struct reset_controller_dev`. The correct format specifier should be '%u'.
--

commit 7bce3db3196b0adcbf2826ecbc55698c8ce2e8f5
Author: Alex Tran <alex.tran@oss.qualcomm.com>

reset: reset-scmi: Log number of reset domains

This commit updates the SCMI reset driver to log the number of reset domains
discovered from firmware during probe.

> diff --git a/drivers/reset/reset-scmi.c b/drivers/reset/reset-scmi.c
> index 4335811e0cfaa..114470c12931f 100644
> --- a/drivers/reset/reset-scmi.c
> +++ b/drivers/reset/reset-scmi.c

[ ... ]

> @@ -111,7 +112,12 @@ static int scmi_reset_probe(struct scmi_device *sdev)
>  	data->rcdev.nr_resets = reset_ops->num_domains_get(ph);
>  	data->ph = ph;
>  
> -	return devm_reset_controller_register(dev, &data->rcdev);
> +	ret = devm_reset_controller_register(dev, &data->rcdev);
> +	if (ret)
> +		return ret;
> +
> +	dev_dbg(dev, "Initialized %d reset domains\n", data->rcdev.nr_resets);

This isn't a bug, but does this dev_dbg() statement use the wrong format
specifier?

The nr_resets field in struct reset_controller_dev is an unsigned int, so
should it use %u instead of %d?

> +	return 0;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-scmi-client-probe-log-v2-0-36607e9dd540@oss.qualcomm.com?part=4