From: sashiko-bot@kernel.org
To: "Flaviu Nistor" <flaviu.nistor@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (adt7475) Add explicit header include
Date: Fri, 22 May 2026 05:58:19 +0000 [thread overview]
Message-ID: <20260522055820.459DB1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260522052352.12139-1-flaviu.nistor@gmail.com>
> Since device_property_read_string() and similar functions defined in
> linux/property.h are used in the driver add explicit include for
> linux/mod_devicetable.h and linux/property.h rather than having
> implicit inclusions.
> Removed of_match_ptr() improving non-Device Tree compatibility of the
> driver and drop unnecessary __maybe_unused.
> Header linux/of.h can't be removed yet since macro is_of_node() is used.
>
> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260522052352.12139-1-flaviu.nistor@gmail.com?part=1
next prev parent reply other threads:[~2026-05-22 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 5:23 [PATCH] hwmon: (adt7475) Add explicit header include Flaviu Nistor
2026-05-22 5:58 ` sashiko-bot [this message]
2026-05-24 15:29 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260522055820.459DB1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=flaviu.nistor@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox