[PATCH] hwmon: (adt7475) Add explicit header include

[PATCH] hwmon: (adt7475) Add explicit header include

[Flaviu Nistor]

Since device_property_read_string() and similar functions defined in
linux/property.h are used in the driver add explicit include for
linux/mod_devicetable.h and linux/property.h rather than having
implicit inclusions.
Removed of_match_ptr() improving non-Device Tree compatibility of the
driver and drop unnecessary __maybe_unused.
Header linux/of.h can't be removed yet since macro is_of_node() is used.

Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
---
 drivers/hwmon/adt7475.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
index 7fb96f5395fa..7241fc73d21a 100644
--- a/drivers/hwmon/adt7475.c
+++ b/drivers/hwmon/adt7475.c
@@ -19,6 +19,8 @@
 #include <linux/err.h>
 #include <linux/jiffies.h>
 #include <linux/of.h>
+#include <linux/mod_devicetable.h>
+#include <linux/property.h>
 #include <linux/util_macros.h>
 
 #include <dt-bindings/pwm/pwm.h>
@@ -173,7 +175,7 @@ static const struct i2c_device_id adt7475_id[] = {
 };
 MODULE_DEVICE_TABLE(i2c, adt7475_id);
 
-static const struct of_device_id __maybe_unused adt7475_of_match[] = {
+static const struct of_device_id adt7475_of_match[] = {
 	{
 		.compatible = "adi,adt7473",
 		.data = (void *)adt7473
@@ -1995,7 +1997,7 @@ static struct i2c_driver adt7475_driver = {
 	.class		= I2C_CLASS_HWMON,
 	.driver = {
 		.name	= "adt7475",
-		.of_match_table = of_match_ptr(adt7475_of_match),
+		.of_match_table = adt7475_of_match,
 	},
 	.probe		= adt7475_probe,
 	.id_table	= adt7475_id,
-- 
2.34.1

Re: [PATCH] hwmon: (adt7475) Add explicit header include

[sashiko-bot]

> Since device_property_read_string() and similar functions defined in
> linux/property.h are used in the driver add explicit include for
> linux/mod_devicetable.h and linux/property.h rather than having
> implicit inclusions.
> Removed of_match_ptr() improving non-Device Tree compatibility of the
> driver and drop unnecessary __maybe_unused.
> Header linux/of.h can't be removed yet since macro is_of_node() is used.
> 
> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260522052352.12139-1-flaviu.nistor@gmail.com?part=1

Re: [PATCH] hwmon: (adt7475) Add explicit header include

[Guenter Roeck]

On Fri, May 22, 2026 at 08:23:52AM +0300, Flaviu Nistor wrote:
> Since device_property_read_string() and similar functions defined in
> linux/property.h are used in the driver add explicit include for
> linux/mod_devicetable.h and linux/property.h rather than having
> implicit inclusions.
> Removed of_match_ptr() improving non-Device Tree compatibility of the
> driver and drop unnecessary __maybe_unused.
> Header linux/of.h can't be removed yet since macro is_of_node() is used.
> 
> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>

Applied.

For the future, please don't split lines that much in patch descriptions.
The column length limit in patch descriptions is 75.

Thanks,
Guenter

> ---
>  drivers/hwmon/adt7475.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
> index 7fb96f5395fa..7241fc73d21a 100644
> --- a/drivers/hwmon/adt7475.c
> +++ b/drivers/hwmon/adt7475.c
> @@ -19,6 +19,8 @@
>  #include <linux/err.h>
>  #include <linux/jiffies.h>
>  #include <linux/of.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/property.h>
>  #include <linux/util_macros.h>
>  
>  #include <dt-bindings/pwm/pwm.h>
> @@ -173,7 +175,7 @@ static const struct i2c_device_id adt7475_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, adt7475_id);
>  
> -static const struct of_device_id __maybe_unused adt7475_of_match[] = {
> +static const struct of_device_id adt7475_of_match[] = {
>  	{
>  		.compatible = "adi,adt7473",
>  		.data = (void *)adt7473
> @@ -1995,7 +1997,7 @@ static struct i2c_driver adt7475_driver = {
>  	.class		= I2C_CLASS_HWMON,
>  	.driver = {
>  		.name	= "adt7475",
> -		.of_match_table = of_match_ptr(adt7475_of_match),
> +		.of_match_table = adt7475_of_match,
>  	},
>  	.probe		= adt7475_probe,
>  	.id_table	= adt7475_id,