* [PATCH] hwmon: (tmp401) register with thermal subsystem
@ 2026-07-13 21:07 Vincent Jardin via B4 Relay
2026-07-13 21:16 ` sashiko-bot
2026-07-19 14:03 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Vincent Jardin via B4 Relay @ 2026-07-13 21:07 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-hwmon, linux-kernel, Vincent Jardin
From: Vincent Jardin <vjardin@free.fr>
tmp401 is missing HWMON_C_REGISTER_TZ. So a devicetree thermal
zone referencing a such sensor ('thermal-sensors = <&tmp411 N>')
fails to register it. Then its cooling-maps is not set, which means
that the fans are not managed.
Same as lm90 or jc42, set HWMON_C_REGISTER_TZ.
Boards without the property into the DT keep the same behavior.
Signed-off-by: Vincent Jardin <vjardin@free.fr>
---
It was checked on a LX2160A board that uses a TMP411 for the chassis ambient
input of a fan thermal zone.
Without this patch the zone silently never registers.
With this patch, the zone registers and the cooling-map drives the EMC2305
fans.
---
drivers/hwmon/tmp401.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c
index ca0ff525ea29..83aafe4bd3e7 100644
--- a/drivers/hwmon/tmp401.c
+++ b/drivers/hwmon/tmp401.c
@@ -695,7 +695,7 @@ static int tmp401_probe(struct i2c_client *client)
info->type = hwmon_chip;
info->config = data->chip_channel_config;
- data->chip_channel_config[0] = HWMON_C_UPDATE_INTERVAL;
+ data->chip_channel_config[0] = HWMON_C_REGISTER_TZ | HWMON_C_UPDATE_INTERVAL;
info = &data->temp_info;
info->type = hwmon_temp;
---
base-commit: ca078d004cf58137bcf8cb24a8b271397431ba58
change-id: 20260713-for-upstream-hwmon-tmp401-register-tz-d07130b9be30
Best regards,
--
Vincent Jardin <vjardin@free.fr>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hwmon: (tmp401) register with thermal subsystem
2026-07-13 21:07 [PATCH] hwmon: (tmp401) register with thermal subsystem Vincent Jardin via B4 Relay
@ 2026-07-13 21:16 ` sashiko-bot
2026-07-19 14:03 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-07-13 21:16 UTC (permalink / raw)
To: Vincent Jardin; +Cc: linux-hwmon
> From: Vincent Jardin <vjardin@free.fr>
>
> tmp401 is missing HWMON_C_REGISTER_TZ. So a devicetree thermal
> zone referencing a such sensor ('thermal-sensors = <&tmp411 N>')
> fails to register it. Then its cooling-maps is not set, which means
> that the fans are not managed.
>
> Same as lm90 or jc42, set HWMON_C_REGISTER_TZ.
> Boards without the property into the DT keep the same behavior.
>
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260713-for-upstream-hwmon-tmp401-register-tz-v1-1-47315d8617bc@free.fr?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hwmon: (tmp401) register with thermal subsystem
2026-07-13 21:07 [PATCH] hwmon: (tmp401) register with thermal subsystem Vincent Jardin via B4 Relay
2026-07-13 21:16 ` sashiko-bot
@ 2026-07-19 14:03 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2026-07-19 14:03 UTC (permalink / raw)
To: Vincent Jardin; +Cc: linux-hwmon, linux-kernel
On Mon, Jul 13, 2026 at 11:07:54PM +0200, Vincent Jardin wrote:
> From: Vincent Jardin <vjardin@free.fr>
>
> tmp401 is missing HWMON_C_REGISTER_TZ. So a devicetree thermal
> zone referencing a such sensor ('thermal-sensors = <&tmp411 N>')
> fails to register it. Then its cooling-maps is not set, which means
> that the fans are not managed.
>
> Same as lm90 or jc42, set HWMON_C_REGISTER_TZ.
> Boards without the property into the DT keep the same behavior.
>
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-19 14:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-13 21:07 [PATCH] hwmon: (tmp401) register with thermal subsystem Vincent Jardin via B4 Relay
2026-07-13 21:16 ` sashiko-bot
2026-07-19 14:03 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox