Re: [PATCH v2] hwmon: (yogafan) Add support for new Lenovo models

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Redundant DMI quirk entry for 'Yoga 14cACN 2021'
--

commit 634b305e1f54cec1238a122131d8de1e78a97b9f
Author: Sergio Melas <sergiomelas@gmail.com>
hwmon: (yogafan) Add support for new Lenovo models

This commit adds DMI quirk entries to map the correct ACPI paths and
configurations for new Lenovo laptop models. It maps specific configurations
for Yoga 14cACN 2021, IdeaPad 3 15ALC6 Ub, and Yoga 740-15IML models based
on DMI product family matching.

> diff --git a/drivers/hwmon/yogafan.c b/drivers/hwmon/yogafan.c
> index 48fa5148d9e2c..2f86a8f6e0aeb 100644
> --- a/drivers/hwmon/yogafan.c
> +++ b/drivers/hwmon/yogafan.c

[ ... ]

> @@ -189,6 +194,30 @@ static const struct hwmon_chip_info yoga_fan_chip_info = {
>  };
>  
>  static const struct dmi_system_id yogafan_quirks[] = {

[ ... ]

> +	{
> +		.ident = "Yoga 14cACN 2021",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_FAMILY, "Yoga 14cACN 2021"),
> +		},
> +		.driver_data = (void *)&yoga_8bit_fans_cfg,
> +	},

[Severity: Low]
Is this explicit entry for the Yoga 14cACN 2021 necessary?

Looking further down in the yogafan_quirks array, there is a generic fallback
match for Lenovo Yoga devices:

static const struct dmi_system_id yogafan_quirks[] = {
    ...
    {
        .ident = "Lenovo Yoga",
        .matches = {
            DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
            DMI_MATCH(DMI_PRODUCT_FAMILY, "Yoga"),
        },
        .driver_data = (void *)&yoga_8bit_fans_cfg,
    },
    ...
};

Since dmi_first_match() performs substring matching, and the generic fallback
maps to the exact same yoga_8bit_fans_cfg configuration, won't omitting this
new block naturally fall through to the correct behavior without adding
redundant entries to the array?

>  	{
>  		.ident = "Lenovo LOQ 15IAX9",

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908094717.2224803-1-sergiomelas@gmail.com?part=1