Re: [PATCH v2] hwmon: (yogafan) Add support for new Lenovo models

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new DMI quirk entry for 'Yoga 14cACN 2021' is fully redundant and has no effect.
--

commit a58d4537b52bbed66e2772abc8773ca0b3f84710
Author: Sergio Melas <sergiomelas@gmail.com>

hwmon: (yogafan) Add support for new Lenovo models

Add DMI quirk entries and map correct ACPI paths and configurations for
additional Lenovo laptop models: Yoga 14cACN 2021, IdeaPad 3 15ALC6 Ub
and Yoga 740-15IML, leveraging DMI product family matching.

> diff --git a/drivers/hwmon/yogafan.c b/drivers/hwmon/yogafan.c
> index 48fa5148d9e2c..2f86a8f6e0aeb 100644
> --- a/drivers/hwmon/yogafan.c
> +++ b/drivers/hwmon/yogafan.c

[ ... ]

> @@ -189,6 +194,30 @@ static const struct hwmon_chip_info yoga_fan_chip_info = {
>  };
>  
>  static const struct dmi_system_id yogafan_quirks[] = {

[ ... ]

> +	{
> +		.ident = "Yoga 14cACN 2021",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_FAMILY, "Yoga 14cACN 2021"),
> +		},
> +		.driver_data = (void *)&yoga_8bit_fans_cfg,
> +	},

[Severity: Low]
Is this explicit entry for "Yoga 14cACN 2021" necessary?

Since the kernel's DMI_MATCH() macro uses substring matching, a product
family of "Yoga 14cACN 2021" will naturally fall through and match the
existing generic "Lenovo Yoga" fallback entry located later in the array:

	{
		.ident = "Lenovo Yoga",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
			DMI_MATCH(DMI_PRODUCT_FAMILY, "Yoga"),
		},
		.driver_data = (void *)&yoga_8bit_fans_cfg,
	},

Because both the explicit entry and the generic fallback map to the exact
same driver configuration (yoga_8bit_fans_cfg), adding this specific entry
appears to be logically redundant.

>  	{
>  		.ident = "Lenovo LOQ 15IAX9",
>  		.matches = {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908094931.2227049-1-sergiomelas@gmail.com?part=1