* [PATCH v3] Documentation: hwmon: (yogafan) adjust table alignment for long model name
@ 2026-09-10 7:45 Sergio Melas
2026-09-10 7:49 ` sashiko-bot
0 siblings, 1 reply; 3+ messages in thread
From: Sergio Melas @ 2026-09-10 7:45 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-hwmon, linux-kernel, Sergio Melas
Update the reStructuredText table layout and column separators to
accommodate the longer product family string for the newly added IdeaPad
model (IdeaPad 3 15ALC6 Ub). This prevents Sphinx build warnings and
maintains proper visual alignment.
Signed-off-by: Sergio Melas <sergiomelas@gmail.com>
---
v3: Adjust rst table alignment and column separators for the new IdeaPad model.
v2: Split changes and addressed reviewer comments.
---
Documentation/hwmon/yogafan.rst | 47 ++++++++++++++++++---------------
1 file changed, 25 insertions(+), 22 deletions(-)
diff --git a/Documentation/hwmon/yogafan.rst b/Documentation/hwmon/yogafan.rst
index 9ff5db5dc..239c7b576 100644
--- a/Documentation/hwmon/yogafan.rst
+++ b/Documentation/hwmon/yogafan.rst
@@ -85,28 +85,30 @@ immediately to ensure the user knows the fan has stopped.
::
- MODEL (DMI PN) | FAMILY / SERIES | EC OFFSET | FULL ACPI OBJECT PATH | WIDTH | MULTiplier
- ----------------------------------------------------------------------------------------------------
- 82N7 | Yoga 14cACN | 0x06 | \_SB.PCI0.LPC0.EC0.FANS | 8-bit | 100
- 80V2 / 81C3 | Yoga 710/720 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100
- 83E2 | Yoga Pro 7 | 0xFE | \_SB.PCI0.LPC0.EC0.FANS | 8-bit | 100
- 83DN | Yoga Pro 9 16IMH9 | 0x06/0xFE | \_SB.PC00.LPCB.EC0.FANS/FA2S | 8-bit | 100
- 82A2 / 82A3 | Yoga Slim 7 | 0x06 | \_SB.PCI0.LPC0.EC0.FANS | 8-bit | 100
- 81YM / 82FG | IdeaPad 5 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100
- 82JW / 82JU | Legion 5 (AMD) | 0xFE/0xFF | \_SB.PCI0.LPC0.EC0.FANS (Fan1) | 16-bit | 1
- 82JW / 82JU | Legion 5 (AMD) | 0xFE/0xFF | \_SB.PCI0.LPC0.EC0.FA2S (Fan2) | 16-bit | 1
- 82WQ | Legion 7i (Int) | 0xFE/0xFF | \_SB.PCI0.LPC0.EC0.FANS (Fan1) | 16-bit | 1
- 82WQ | Legion 7i (Int) | 0xFE/0xFF | \_SB.PCI0.LPC0.EC0.FA2S (Fan2) | 16-bit | 1
- 82XV / 83DV | LOQ 15/16 | 0xFE/0xFF | \_SB.PCI0.LPC0.EC0.FANS /FA2S | 16-bit | 1
- 83AK | ThinkBook G6 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100
- 81X1 | Flex 5 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100
- 83KF | XiaoXinPro 13ARE | 0x06/0xFE | \_SB.PCI0.LPC0.EC0.FANS/FA2S | 8-bit | 100
- 82KU | IdeaPad 3 15ALC6 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100
- 83RU | Legion Pro 7 16 | 0x03/0x06 | \_SB.PCI0.LPC0.EC0.FANS/FA2S | 8-bit | 100
- 83KF | Yoga Pro 7 14IAH | 0x06 | \_SB.PC00.LPCB.EC0.FANS | 8-bit | 100
- 83BS | Yoga 7 16ARP8 | 0x03/0x06 | \_SB.PCI0.LPC0.EC0.FANS/FA2S | 8-bit | 100
- *Legacy* | Pre-2020 Models | 0x06 | \_SB.PCI0.LPC.EC.FAN0 | 8-bit | 100
- ----------------------------------------------------------------------------------------------------
+ MODEL (DMI PN) | FAMILY / SERIES | EC OFFSET | FULL ACPI OBJECT PATH | WIDTH | MULTiplier
+ -------------------------------------------------------------------------------------------------------
+ 82N7 | Yoga 14cACN 2021 | 0x06 | \_SB.PCI0.LPC0.EC0.FANS | 8-bit | 100
+ 81TD | Yoga 740-15IML | 0x06 | \_SB.PCI0.LPCB.EC0.FANS | 8-bit | 100
+ 82KU | IdeaPad 3 15ALC6 Ub | 0x06 | \_SB.PCI0.LPC0.EC0.FANS/FA2S | 8-bit | 100
+ 80V2 / 81C3 | Yoga 710/720 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100
+ 83E2 | Yoga Pro 7 | 0xFE | \_SB.PCI0.LPC0.EC0.FANS | 8-bit | 100
+ 83DN | Yoga Pro 9 16IMH9 | 0x06/0xFE | \_SB.PC00.LPCB.EC0.FANS/FA2S | 8-bit | 100
+ 82A2 / 82A3 | Yoga Slim 7 | 0x06 | \_SB.PCI0.LPC0.EC0.FANS | 8-bit | 100
+ 81YM / 82FG | IdeaPad 5 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100
+ 82JW / 82JU | Legion 5 (AMD) | 0xFE/0xFF | \_SB.PCI0.LPC0.EC0.FANS (Fan1) | 16-bit | 1
+ 82JW / 82JU | Legion 5 (AMD) | 0xFE/0xFF | \_SB.PCI0.LPC0.EC0.FA2S (Fan2) | 16-bit | 1
+ 82WQ | Legion 7i (Int) | 0xFE/0xFF | \_SB.PCI0.LPC0.EC0.FANS (Fan1) | 16-bit | 1
+ 82WQ | Legion 7i (Int) | 0xFE/0xFF | \_SB.PCI0.LPC0.EC0.FA2S (Fan2) | 16-bit | 1
+ 82XV / 83DV | LOQ 15/16 | 0xFE/0xFF | \_SB.PCI0.LPC0.EC0.FANS /FA2S | 16-bit | 1
+ 83AK | ThinkBook G6 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100
+ 81X1 | Flex 5 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100
+ 83KF | XiaoXinPro 13ARE | 0x06/0xFE | \_SB.PCI0.LPC0.EC0.FANS/FA2S | 8-bit | 100
+ 82KU | IdeaPad 3 15ALC6 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100
+ 83RU | Legion Pro 7 16 | 0x03/0x06 | \_SB.PCI0.LPC0.EC0.FANS/FA2S | 8-bit | 100
+ 83KF | Yoga Pro 7 14IAH | 0x06 | \_SB.PC00.LPCB.EC0.FANS | 8-bit | 100
+ 83BS | Yoga 7 16ARP8 | 0x03/0x06 | \_SB.PCI0.LPC0.EC0.FANS/FA2S | 8-bit | 100
+ *Legacy* | Pre-2020 Models | 0x06 | \_SB.PCI0.LPC.EC.FAN0 | 8-bit | 100
+ -------------------------------------------------------------------------------------------------------
METHODOLOGY & IDENTIFICATION:
@@ -159,6 +161,7 @@ Contributors & DSDT Providers:
- **Sarbajit Sarkar** (Lenovo LOQ 15IAX9)
- **HinataKato** (XiaoXin Pro 13ARE 2020 - 83KF)
- **PenPenIsGod** (IdeaPad 3 15ALC6 - 82KU & Legion Pro 7 16AFR10H - 83RU)
+- **wizard-28** (IdeaPad 3 15ALC6 Ub - 82KU)
- **unlockxiaom** (Legion Pro 7 16AFR10H - 83RU, Yoga Pro 7 14IAH10 - 83KF, ThinkCentre M80q)
- **Phani Pavan K** (Yoga Pro 7 14IAH10 - 83KF)
- **Splarkszter** (Yoga 7 16ARP8 - 83BS)
--
2.55.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] Documentation: hwmon: (yogafan) adjust table alignment for long model name
2026-09-10 7:45 [PATCH v3] Documentation: hwmon: (yogafan) adjust table alignment for long model name Sergio Melas
@ 2026-09-10 7:49 ` sashiko-bot
2026-09-10 15:20 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: sashiko-bot @ 2026-09-10 7:49 UTC (permalink / raw)
To: Sergio Melas; +Cc: linux-hwmon
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch silently introduces undocumented model additions and modifications to the hardware support table, which contradicts the commit message.
--
commit ecc05eb9d5cd9f6474be8ef3ef43d5a812bf701e
Author: Sergio Melas <sergiomelas@gmail.com>
Documentation: hwmon: (yogafan) adjust table alignment for long model name
This commit updates the reStructuredText table layout in the yogafan
documentation to accommodate a longer product family string for the newly
added IdeaPad 3 15ALC6 Ub model, preventing Sphinx build warnings.
> Update the reStructuredText table layout and column separators to
> accommodate the longer product family string for the newly added IdeaPad
> model (IdeaPad 3 15ALC6 Ub). This prevents Sphinx build warnings and
> maintains proper visual alignment.
> diff --git a/Documentation/hwmon/yogafan.rst b/Documentation/hwmon/yogafan.rst
> index 9ff5db5dc08ce..239c7b5761caf 100644
> --- a/Documentation/hwmon/yogafan.rst
> +++ b/Documentation/hwmon/yogafan.rst
> @@ -85,28 +85,30 @@ immediately to ensure the user knows the fan has stopped.
>
> ::
>
> - MODEL (DMI PN) | FAMILY / SERIES | EC OFFSET | FULL ACPI OBJECT PATH | WIDTH | MULTiplier
> - ----------------------------------------------------------------------------------------------------
> - 82N7 | Yoga 14cACN | 0x06 | \_SB.PCI0.LPC0.EC0.FANS | 8-bit | 100
> - 80V2 / 81C3 | Yoga 710/720 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100
[ ... ]
> + MODEL (DMI PN) | FAMILY / SERIES | EC OFFSET | FULL ACPI OBJECT PATH | WIDTH | MULTiplier
> + -------------------------------------------------------------------------------------------------------
> + 82N7 | Yoga 14cACN 2021 | 0x06 | \_SB.PCI0.LPC0.EC0.FANS | 8-bit | 100
> + 81TD | Yoga 740-15IML | 0x06 | \_SB.PCI0.LPCB.EC0.FANS | 8-bit | 100
> + 82KU | IdeaPad 3 15ALC6 Ub | 0x06 | \_SB.PCI0.LPC0.EC0.FANS/FA2S | 8-bit | 100
[Severity: Medium]
The commit message states this patch only adjusts table alignment to
accommodate the newly added IdeaPad 3 15ALC6 Ub model. However, it appears
this patch also silently adds an entirely new model (81TD | Yoga 740-15IML)
and modifies the name of an existing model (Yoga 14cACN to Yoga 14cACN 2021).
Should these unrelated hardware support additions and modifications be split
into a separate patch or explicitly mentioned in the commit message to
accurately reflect the changes made?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260910074505.1077544-1-sergiomelas@gmail.com?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] Documentation: hwmon: (yogafan) adjust table alignment for long model name
2026-09-10 7:49 ` sashiko-bot
@ 2026-09-10 15:20 ` Guenter Roeck
0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2026-09-10 15:20 UTC (permalink / raw)
To: sashiko-reviews, Sergio Melas; +Cc: linux-hwmon
On 9/10/26 00:49, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The patch silently introduces undocumented model additions and modifications to the hardware support table, which contradicts the commit message.
> --
>
> commit ecc05eb9d5cd9f6474be8ef3ef43d5a812bf701e
> Author: Sergio Melas <sergiomelas@gmail.com>
>
> Documentation: hwmon: (yogafan) adjust table alignment for long model name
>
> This commit updates the reStructuredText table layout in the yogafan
> documentation to accommodate a longer product family string for the newly
> added IdeaPad 3 15ALC6 Ub model, preventing Sphinx build warnings.
>
>> Update the reStructuredText table layout and column separators to
>> accommodate the longer product family string for the newly added IdeaPad
>> model (IdeaPad 3 15ALC6 Ub). This prevents Sphinx build warnings and
>> maintains proper visual alignment.
>
>> diff --git a/Documentation/hwmon/yogafan.rst b/Documentation/hwmon/yogafan.rst
>> index 9ff5db5dc08ce..239c7b5761caf 100644
>> --- a/Documentation/hwmon/yogafan.rst
>> +++ b/Documentation/hwmon/yogafan.rst
>> @@ -85,28 +85,30 @@ immediately to ensure the user knows the fan has stopped.
>>
>> ::
>>
>> - MODEL (DMI PN) | FAMILY / SERIES | EC OFFSET | FULL ACPI OBJECT PATH | WIDTH | MULTiplier
>> - ----------------------------------------------------------------------------------------------------
>> - 82N7 | Yoga 14cACN | 0x06 | \_SB.PCI0.LPC0.EC0.FANS | 8-bit | 100
>> - 80V2 / 81C3 | Yoga 710/720 | 0x06 | \_SB.PCI0.LPC0.EC0.FAN0 | 8-bit | 100
>
> [ ... ]
>
>> + MODEL (DMI PN) | FAMILY / SERIES | EC OFFSET | FULL ACPI OBJECT PATH | WIDTH | MULTiplier
>> + -------------------------------------------------------------------------------------------------------
>> + 82N7 | Yoga 14cACN 2021 | 0x06 | \_SB.PCI0.LPC0.EC0.FANS | 8-bit | 100
>> + 81TD | Yoga 740-15IML | 0x06 | \_SB.PCI0.LPCB.EC0.FANS | 8-bit | 100
>> + 82KU | IdeaPad 3 15ALC6 Ub | 0x06 | \_SB.PCI0.LPC0.EC0.FANS/FA2S | 8-bit | 100
>
> [Severity: Medium]
> The commit message states this patch only adjusts table alignment to
> accommodate the newly added IdeaPad 3 15ALC6 Ub model. However, it appears
> this patch also silently adds an entirely new model (81TD | Yoga 740-15IML)
> and modifies the name of an existing model (Yoga 14cACN to Yoga 14cACN 2021).
> Should these unrelated hardware support additions and modifications be split
> into a separate patch or explicitly mentioned in the commit message to
> accurately reflect the changes made?
>
Why those changes ? This should at least be explained in the commit
description.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-10 15:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-10 7:45 [PATCH v3] Documentation: hwmon: (yogafan) adjust table alignment for long model name Sergio Melas
2026-09-10 7:49 ` sashiko-bot
2026-09-10 15:20 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).