From: sashiko-bot@kernel.org
To: "Lin Wang" <wanglin@open-hieco.net>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v5 3/8] EDAC/amd64: Stop matching Hygon CPUs
Date: Thu, 10 Sep 2026 08:33:27 +0000 [thread overview]
Message-ID: <20260910083327.DB2671F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260910082734.3771675-4-wanglin@open-hieco.net>
> amd64_edac matches Hygon Family 0x18, but obtains its node count and
> F3 devices from the AMD northbridge cache. That cache maps dense node
> indices to fixed PCI slots starting at 0x18. Hygon discovers DF devices
> by PCI ID and reads their identities from DF registers. Their PCI slots
> do not encode node identity, and CPU NodeIds are sparse across sockets.
> The cache therefore cannot represent the Hygon topology.
>
> A failed fixed-slot F3 lookup causes amd_cache_northbridges() to discard
> the cache, and amd64_edac then exits at its amd_nb_num() check. The
> driver has no valid Hygon node count or node-to-F3 mapping.
>
> Remove the Hygon CPU match and the unused Family 0x18 case. Hygon memory
> controller support requires the Hygon node interfaces and will be added
> separately. This does not affect MCE decoding in mce_amd.c.
>
> Signed-off-by: Lin Wang <wanglin@open-hieco.net>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260910082734.3771675-1-wanglin@open-hieco.net?part=3
next prev parent reply other threads:[~2026-09-10 8:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 8:27 [PATCH v5 0/8] x86/hygon: Add Family 0x18 DF node enumeration and SMN access Lin Wang
2026-09-10 8:27 ` [PATCH v5 1/8] x86/hygon: Add Family 0x18 DF node enumeration Lin Wang
2026-09-10 8:32 ` sashiko-bot
2026-09-10 8:27 ` [PATCH v5 2/8] x86/hygon: Map CPU NodeIds to DF nodes Lin Wang
2026-09-10 8:32 ` sashiko-bot
2026-09-10 8:27 ` [PATCH v5 3/8] EDAC/amd64: Stop matching Hygon CPUs Lin Wang
2026-09-10 8:33 ` sashiko-bot [this message]
2026-09-10 8:27 ` [PATCH v5 4/8] RAS/AMD/ATL: Match AMD CPUs only Lin Wang
2026-09-10 8:34 ` sashiko-bot
2026-09-10 8:27 ` [PATCH v5 5/8] hwmon: (k10temp) Stop matching Hygon devices Lin Wang
2026-09-10 8:36 ` sashiko-bot
2026-09-11 0:52 ` Guenter Roeck
2026-09-11 1:10 ` Lin Wang
2026-09-10 8:27 ` [PATCH v5 6/8] x86/amd_nb: Restrict the northbridge framework to AMD CPUs Lin Wang
2026-09-10 8:37 ` sashiko-bot
2026-09-10 8:27 ` [PATCH v5 7/8] x86/amd_node: Restrict SMN setup " Lin Wang
2026-09-10 8:43 ` sashiko-bot
2026-09-10 8:27 ` [PATCH v5 8/8] x86/hygon: Add Family 0x18 SMN access Lin Wang
2026-09-10 8:38 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910083327.DB2671F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wanglin@open-hieco.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox