From: sashiko-bot@kernel.org
To: "Lin Wang" <wanglin@open-hieco.net>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v5 5/8] hwmon: (k10temp) Stop matching Hygon devices
Date: Thu, 10 Sep 2026 08:36:48 +0000 [thread overview]
Message-ID: <20260910083649.4CAC11F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260910082734.3771675-6-wanglin@open-hieco.net>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete removal of Hygon support in documentation
--
commit 5233d0bb0c626dfef82d25286284d5ba59e76f21
Author: Lin Wang <wanglin@open-hieco.net>
hwmon: (k10temp) Stop matching Hygon devices
This commit removes the Hygon PCI match and the Family 0x18 branch from the
k10temp driver. Hygon temperature monitoring will be added separately, as
the derived node number currently has no defined relationship to the Hygon
DF node or its SMN root.
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index 75a45010d687a..20a5470e6593f 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -475,7 +475,7 @@ static int k10temp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> data->read_tempreg = read_tempreg_pci;
> }
>
> - if (boot_cpu_data.x86 == 0x17 || boot_cpu_data.x86 == 0x18) {
> + if (boot_cpu_data.x86 == 0x17) {
[Severity: Low]
Does Documentation/hwmon/k10temp.rst need to be updated to match this code
removal?
Currently, the documentation file incorrectly lists the chip as supported:
* AMD Family 18h processors: "Hygon Dhyana"
If a user consults Documentation/hwmon/k10temp.rst for driver compatibility,
could this regression mislead them into thinking the k10temp driver still
supports it?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260910082734.3771675-1-wanglin@open-hieco.net?part=5
next prev parent reply other threads:[~2026-09-10 8:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 8:27 [PATCH v5 0/8] x86/hygon: Add Family 0x18 DF node enumeration and SMN access Lin Wang
2026-09-10 8:27 ` [PATCH v5 1/8] x86/hygon: Add Family 0x18 DF node enumeration Lin Wang
2026-09-10 8:32 ` sashiko-bot
2026-09-10 8:27 ` [PATCH v5 2/8] x86/hygon: Map CPU NodeIds to DF nodes Lin Wang
2026-09-10 8:32 ` sashiko-bot
2026-09-10 8:27 ` [PATCH v5 3/8] EDAC/amd64: Stop matching Hygon CPUs Lin Wang
2026-09-10 8:33 ` sashiko-bot
2026-09-10 8:27 ` [PATCH v5 4/8] RAS/AMD/ATL: Match AMD CPUs only Lin Wang
2026-09-10 8:34 ` sashiko-bot
2026-09-10 8:27 ` [PATCH v5 5/8] hwmon: (k10temp) Stop matching Hygon devices Lin Wang
2026-09-10 8:36 ` sashiko-bot [this message]
2026-09-11 0:52 ` Guenter Roeck
2026-09-11 1:10 ` Lin Wang
2026-09-10 8:27 ` [PATCH v5 6/8] x86/amd_nb: Restrict the northbridge framework to AMD CPUs Lin Wang
2026-09-10 8:37 ` sashiko-bot
2026-09-10 8:27 ` [PATCH v5 7/8] x86/amd_node: Restrict SMN setup " Lin Wang
2026-09-10 8:43 ` sashiko-bot
2026-09-10 8:27 ` [PATCH v5 8/8] x86/hygon: Add Family 0x18 SMN access Lin Wang
2026-09-10 8:38 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910083649.4CAC11F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wanglin@open-hieco.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox