* [PATCH v2 0/2] hwmon: (k10temp): Add 0x1ah/80h
@ 2026-09-11 19:17 Mario Limonciello
2026-09-11 19:17 ` [PATCH v2 1/2] hwmon: (k10temp): Add support for 1ah/80h Mario Limonciello
2026-09-11 19:17 ` [PATCH v2 2/2] hwmon: (k10temp): Define unshared PCI device IDs locally Mario Limonciello
0 siblings, 2 replies; 7+ messages in thread
From: Mario Limonciello @ 2026-09-11 19:17 UTC (permalink / raw)
To: bhelgaas, clemens, linux; +Cc: Mario Limonciello, linux-hwmon, linux-pci
Add support for more systems. Documentation changes would come
later after systems launch.
While at it, move some single use IDs into k10temp.
Mario Limonciello (2):
hwmon: (k10temp): Add support for 1ah/80h
hwmon: (k10temp): Define unshared PCI device IDs locally
drivers/hwmon/k10temp.c | 32 +++++++++++++++++++++++---------
include/linux/pci_ids.h | 20 --------------------
2 files changed, 23 insertions(+), 29 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/2] hwmon: (k10temp): Add support for 1ah/80h
2026-09-11 19:17 [PATCH v2 0/2] hwmon: (k10temp): Add 0x1ah/80h Mario Limonciello
@ 2026-09-11 19:17 ` Mario Limonciello
2026-09-11 19:21 ` sashiko-bot
2026-09-11 21:37 ` Guenter Roeck
2026-09-11 19:17 ` [PATCH v2 2/2] hwmon: (k10temp): Define unshared PCI device IDs locally Mario Limonciello
1 sibling, 2 replies; 7+ messages in thread
From: Mario Limonciello @ 2026-09-11 19:17 UTC (permalink / raw)
To: bhelgaas, clemens, linux; +Cc: Mario Limonciello, linux-hwmon, linux-pci
1ah/80h uses same base as other programs. It only supports Tctl.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v2:
* Move header to k10temp.c
---
drivers/hwmon/k10temp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
index 3e7e63edc6a30..5414b7841864b 100644
--- a/drivers/hwmon/k10temp.c
+++ b/drivers/hwmon/k10temp.c
@@ -94,6 +94,7 @@ MODULE_PARM_DESC(force, "force loading on processors with erratum 319");
* Defining locally as IDs are not shared.
*/
#define PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3 0x12cb
+#define PCI_DEVICE_ID_AMD_1AH_M80H_DF_F3 0x1243
#define PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3 0x127b
struct k10temp_data {
@@ -582,6 +583,7 @@ static const struct pci_device_id k10temp_id_table[] = {
{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3) },
{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3) },
{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M70H_DF_F3) },
+ { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M80H_DF_F3) },
{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3) },
{ PCI_VDEVICE(HYGON, PCI_DEVICE_ID_AMD_17H_DF_F3) },
{}
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] hwmon: (k10temp): Define unshared PCI device IDs locally
2026-09-11 19:17 [PATCH v2 0/2] hwmon: (k10temp): Add 0x1ah/80h Mario Limonciello
2026-09-11 19:17 ` [PATCH v2 1/2] hwmon: (k10temp): Add support for 1ah/80h Mario Limonciello
@ 2026-09-11 19:17 ` Mario Limonciello
2026-09-11 19:25 ` sashiko-bot
2026-09-11 21:40 ` Guenter Roeck
1 sibling, 2 replies; 7+ messages in thread
From: Mario Limonciello @ 2026-09-11 19:17 UTC (permalink / raw)
To: bhelgaas, clemens, linux; +Cc: Mario Limonciello, linux-hwmon, linux-pci
Headers (now) only used by k10temp should not be declared in
global headers.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v2:
* New patch
---
drivers/hwmon/k10temp.c | 30 +++++++++++++++++++++---------
include/linux/pci_ids.h | 20 --------------------
2 files changed, 21 insertions(+), 29 deletions(-)
diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
index 5414b7841864b..49a62d7349ca7 100644
--- a/drivers/hwmon/k10temp.c
+++ b/drivers/hwmon/k10temp.c
@@ -83,17 +83,29 @@ MODULE_PARM_DESC(force, "force loading on processors with erratum 319");
*/
#define AMD_I3255_STR "3255"
-/*
- * PCI Device IDs for AMD's Family 17h-based SOCs.
- * Defining locally as IDs are not shared.
- */
+/* PCI Device IDs. Defining locally as IDs are not shared. */
+#define PCI_DEVICE_ID_AMD_11H_NB_MISC 0x1303
+#define PCI_DEVICE_ID_AMD_CNB17H_F3 0x1703
+#define PCI_DEVICE_ID_AMD_17H_DF_F3 0x1463
+#define PCI_DEVICE_ID_AMD_17H_M10H_DF_F3 0x15eb
+#define PCI_DEVICE_ID_AMD_17H_M30H_DF_F3 0x1493
+#define PCI_DEVICE_ID_AMD_17H_M40H_DF_F3 0x13f3
+#define PCI_DEVICE_ID_AMD_17H_M60H_DF_F3 0x144b
+#define PCI_DEVICE_ID_AMD_17H_M70H_DF_F3 0x1443
#define PCI_DEVICE_ID_AMD_17H_M90H_DF_F3 0x1663
-
-/*
- * PCI Device IDs for AMD's Family 1Ah-based SOCs.
- * Defining locally as IDs are not shared.
- */
+#define PCI_DEVICE_ID_AMD_17H_MA0H_DF_F3 0x1727
+#define PCI_DEVICE_ID_AMD_19H_DF_F3 0x1653
+#define PCI_DEVICE_ID_AMD_19H_M10H_DF_F3 0x14b0
+#define PCI_DEVICE_ID_AMD_19H_M40H_DF_F3 0x167c
+#define PCI_DEVICE_ID_AMD_19H_M50H_DF_F3 0x166d
+#define PCI_DEVICE_ID_AMD_19H_M60H_DF_F3 0x14e3
+#define PCI_DEVICE_ID_AMD_19H_M70H_DF_F3 0x14f3
+#define PCI_DEVICE_ID_AMD_19H_M78H_DF_F3 0x12fb
+#define PCI_DEVICE_ID_AMD_1AH_M00H_DF_F3 0x12c3
+#define PCI_DEVICE_ID_AMD_1AH_M20H_DF_F3 0x16fb
#define PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3 0x12cb
+#define PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3 0x124b
+#define PCI_DEVICE_ID_AMD_1AH_M70H_DF_F3 0x12bb
#define PCI_DEVICE_ID_AMD_1AH_M80H_DF_F3 0x1243
#define PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3 0x127b
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 63774ae2bf71d..7f2ce86695de4 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -550,7 +550,6 @@
#define PCI_DEVICE_ID_AMD_11H_NB_HT 0x1300
#define PCI_DEVICE_ID_AMD_11H_NB_MAP 0x1301
#define PCI_DEVICE_ID_AMD_11H_NB_DRAM 0x1302
-#define PCI_DEVICE_ID_AMD_11H_NB_MISC 0x1303
#define PCI_DEVICE_ID_AMD_11H_NB_LINK 0x1304
#define PCI_DEVICE_ID_AMD_15H_M10H_F3 0x1403
#define PCI_DEVICE_ID_AMD_15H_M30H_NB_F3 0x141d
@@ -567,28 +566,9 @@
#define PCI_DEVICE_ID_AMD_16H_NB_F4 0x1534
#define PCI_DEVICE_ID_AMD_16H_M30H_NB_F3 0x1583
#define PCI_DEVICE_ID_AMD_16H_M30H_NB_F4 0x1584
-#define PCI_DEVICE_ID_AMD_17H_DF_F3 0x1463
-#define PCI_DEVICE_ID_AMD_17H_M10H_DF_F3 0x15eb
-#define PCI_DEVICE_ID_AMD_17H_M30H_DF_F3 0x1493
-#define PCI_DEVICE_ID_AMD_17H_M40H_DF_F3 0x13f3
-#define PCI_DEVICE_ID_AMD_17H_M60H_DF_F3 0x144b
-#define PCI_DEVICE_ID_AMD_17H_M70H_DF_F3 0x1443
-#define PCI_DEVICE_ID_AMD_17H_MA0H_DF_F3 0x1727
-#define PCI_DEVICE_ID_AMD_19H_DF_F3 0x1653
-#define PCI_DEVICE_ID_AMD_19H_M10H_DF_F3 0x14b0
-#define PCI_DEVICE_ID_AMD_19H_M40H_DF_F3 0x167c
-#define PCI_DEVICE_ID_AMD_19H_M50H_DF_F3 0x166d
-#define PCI_DEVICE_ID_AMD_19H_M60H_DF_F3 0x14e3
-#define PCI_DEVICE_ID_AMD_19H_M70H_DF_F3 0x14f3
-#define PCI_DEVICE_ID_AMD_19H_M78H_DF_F3 0x12fb
-#define PCI_DEVICE_ID_AMD_1AH_M00H_DF_F3 0x12c3
-#define PCI_DEVICE_ID_AMD_1AH_M20H_DF_F3 0x16fb
-#define PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3 0x124b
-#define PCI_DEVICE_ID_AMD_1AH_M70H_DF_F3 0x12bb
#define PCI_DEVICE_ID_AMD_MI200_DF_F3 0x14d3
#define PCI_DEVICE_ID_AMD_MI300_DF_F3 0x152b
#define PCI_DEVICE_ID_AMD_VANGOGH_USB 0x163a
-#define PCI_DEVICE_ID_AMD_CNB17H_F3 0x1703
#define PCI_DEVICE_ID_AMD_LANCE 0x2000
#define PCI_DEVICE_ID_AMD_LANCE_HOME 0x2001
#define PCI_DEVICE_ID_AMD_SCSI 0x2020
--
2.43.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] hwmon: (k10temp): Add support for 1ah/80h
2026-09-11 19:17 ` [PATCH v2 1/2] hwmon: (k10temp): Add support for 1ah/80h Mario Limonciello
@ 2026-09-11 19:21 ` sashiko-bot
2026-09-11 21:37 ` Guenter Roeck
1 sibling, 0 replies; 7+ messages in thread
From: sashiko-bot @ 2026-09-11 19:21 UTC (permalink / raw)
To: Mario Limonciello; +Cc: linux-pci, linux-hwmon
> 1ah/80h uses same base as other programs. It only supports Tctl.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260911191803.1522358-1-mario.limonciello@amd.com?part=1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] hwmon: (k10temp): Define unshared PCI device IDs locally
2026-09-11 19:17 ` [PATCH v2 2/2] hwmon: (k10temp): Define unshared PCI device IDs locally Mario Limonciello
@ 2026-09-11 19:25 ` sashiko-bot
2026-09-11 21:40 ` Guenter Roeck
1 sibling, 0 replies; 7+ messages in thread
From: sashiko-bot @ 2026-09-11 19:25 UTC (permalink / raw)
To: Mario Limonciello; +Cc: linux-hwmon, linux-pci
> Headers (now) only used by k10temp should not be declared in
> global headers.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260911191803.1522358-1-mario.limonciello@amd.com?part=2
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] hwmon: (k10temp): Add support for 1ah/80h
2026-09-11 19:17 ` [PATCH v2 1/2] hwmon: (k10temp): Add support for 1ah/80h Mario Limonciello
2026-09-11 19:21 ` sashiko-bot
@ 2026-09-11 21:37 ` Guenter Roeck
1 sibling, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2026-09-11 21:37 UTC (permalink / raw)
To: Mario Limonciello; +Cc: bhelgaas, clemens, linux-hwmon, linux-pci
On Fri, Sep 11, 2026 at 02:17:13PM -0500, Mario Limonciello wrote:
> 1ah/80h uses same base as other programs. It only supports Tctl.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Applied.
Thanks,
Guenter
> ---
> v2:
> * Move header to k10temp.c
> ---
> drivers/hwmon/k10temp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index 3e7e63edc6a30..5414b7841864b 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -94,6 +94,7 @@ MODULE_PARM_DESC(force, "force loading on processors with erratum 319");
> * Defining locally as IDs are not shared.
> */
> #define PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3 0x12cb
> +#define PCI_DEVICE_ID_AMD_1AH_M80H_DF_F3 0x1243
> #define PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3 0x127b
>
> struct k10temp_data {
> @@ -582,6 +583,7 @@ static const struct pci_device_id k10temp_id_table[] = {
> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3) },
> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3) },
> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M70H_DF_F3) },
> + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M80H_DF_F3) },
> { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3) },
> { PCI_VDEVICE(HYGON, PCI_DEVICE_ID_AMD_17H_DF_F3) },
> {}
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] hwmon: (k10temp): Define unshared PCI device IDs locally
2026-09-11 19:17 ` [PATCH v2 2/2] hwmon: (k10temp): Define unshared PCI device IDs locally Mario Limonciello
2026-09-11 19:25 ` sashiko-bot
@ 2026-09-11 21:40 ` Guenter Roeck
1 sibling, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2026-09-11 21:40 UTC (permalink / raw)
To: Mario Limonciello; +Cc: bhelgaas, clemens, linux-hwmon, linux-pci
On Fri, Sep 11, 2026 at 02:17:14PM -0500, Mario Limonciello wrote:
> Headers (now) only used by k10temp should not be declared in
> global headers.
>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
I'll need an Ack from a PCI maintainer to apply this patch.
Thanks,
Guenter
> ---
> v2:
> * New patch
> ---
> drivers/hwmon/k10temp.c | 30 +++++++++++++++++++++---------
> include/linux/pci_ids.h | 20 --------------------
> 2 files changed, 21 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index 5414b7841864b..49a62d7349ca7 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -83,17 +83,29 @@ MODULE_PARM_DESC(force, "force loading on processors with erratum 319");
> */
> #define AMD_I3255_STR "3255"
>
> -/*
> - * PCI Device IDs for AMD's Family 17h-based SOCs.
> - * Defining locally as IDs are not shared.
> - */
> +/* PCI Device IDs. Defining locally as IDs are not shared. */
> +#define PCI_DEVICE_ID_AMD_11H_NB_MISC 0x1303
> +#define PCI_DEVICE_ID_AMD_CNB17H_F3 0x1703
> +#define PCI_DEVICE_ID_AMD_17H_DF_F3 0x1463
> +#define PCI_DEVICE_ID_AMD_17H_M10H_DF_F3 0x15eb
> +#define PCI_DEVICE_ID_AMD_17H_M30H_DF_F3 0x1493
> +#define PCI_DEVICE_ID_AMD_17H_M40H_DF_F3 0x13f3
> +#define PCI_DEVICE_ID_AMD_17H_M60H_DF_F3 0x144b
> +#define PCI_DEVICE_ID_AMD_17H_M70H_DF_F3 0x1443
> #define PCI_DEVICE_ID_AMD_17H_M90H_DF_F3 0x1663
> -
> -/*
> - * PCI Device IDs for AMD's Family 1Ah-based SOCs.
> - * Defining locally as IDs are not shared.
> - */
> +#define PCI_DEVICE_ID_AMD_17H_MA0H_DF_F3 0x1727
> +#define PCI_DEVICE_ID_AMD_19H_DF_F3 0x1653
> +#define PCI_DEVICE_ID_AMD_19H_M10H_DF_F3 0x14b0
> +#define PCI_DEVICE_ID_AMD_19H_M40H_DF_F3 0x167c
> +#define PCI_DEVICE_ID_AMD_19H_M50H_DF_F3 0x166d
> +#define PCI_DEVICE_ID_AMD_19H_M60H_DF_F3 0x14e3
> +#define PCI_DEVICE_ID_AMD_19H_M70H_DF_F3 0x14f3
> +#define PCI_DEVICE_ID_AMD_19H_M78H_DF_F3 0x12fb
> +#define PCI_DEVICE_ID_AMD_1AH_M00H_DF_F3 0x12c3
> +#define PCI_DEVICE_ID_AMD_1AH_M20H_DF_F3 0x16fb
> #define PCI_DEVICE_ID_AMD_1AH_M50H_DF_F3 0x12cb
> +#define PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3 0x124b
> +#define PCI_DEVICE_ID_AMD_1AH_M70H_DF_F3 0x12bb
> #define PCI_DEVICE_ID_AMD_1AH_M80H_DF_F3 0x1243
> #define PCI_DEVICE_ID_AMD_1AH_M90H_DF_F3 0x127b
>
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 63774ae2bf71d..7f2ce86695de4 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -550,7 +550,6 @@
> #define PCI_DEVICE_ID_AMD_11H_NB_HT 0x1300
> #define PCI_DEVICE_ID_AMD_11H_NB_MAP 0x1301
> #define PCI_DEVICE_ID_AMD_11H_NB_DRAM 0x1302
> -#define PCI_DEVICE_ID_AMD_11H_NB_MISC 0x1303
> #define PCI_DEVICE_ID_AMD_11H_NB_LINK 0x1304
> #define PCI_DEVICE_ID_AMD_15H_M10H_F3 0x1403
> #define PCI_DEVICE_ID_AMD_15H_M30H_NB_F3 0x141d
> @@ -567,28 +566,9 @@
> #define PCI_DEVICE_ID_AMD_16H_NB_F4 0x1534
> #define PCI_DEVICE_ID_AMD_16H_M30H_NB_F3 0x1583
> #define PCI_DEVICE_ID_AMD_16H_M30H_NB_F4 0x1584
> -#define PCI_DEVICE_ID_AMD_17H_DF_F3 0x1463
> -#define PCI_DEVICE_ID_AMD_17H_M10H_DF_F3 0x15eb
> -#define PCI_DEVICE_ID_AMD_17H_M30H_DF_F3 0x1493
> -#define PCI_DEVICE_ID_AMD_17H_M40H_DF_F3 0x13f3
> -#define PCI_DEVICE_ID_AMD_17H_M60H_DF_F3 0x144b
> -#define PCI_DEVICE_ID_AMD_17H_M70H_DF_F3 0x1443
> -#define PCI_DEVICE_ID_AMD_17H_MA0H_DF_F3 0x1727
> -#define PCI_DEVICE_ID_AMD_19H_DF_F3 0x1653
> -#define PCI_DEVICE_ID_AMD_19H_M10H_DF_F3 0x14b0
> -#define PCI_DEVICE_ID_AMD_19H_M40H_DF_F3 0x167c
> -#define PCI_DEVICE_ID_AMD_19H_M50H_DF_F3 0x166d
> -#define PCI_DEVICE_ID_AMD_19H_M60H_DF_F3 0x14e3
> -#define PCI_DEVICE_ID_AMD_19H_M70H_DF_F3 0x14f3
> -#define PCI_DEVICE_ID_AMD_19H_M78H_DF_F3 0x12fb
> -#define PCI_DEVICE_ID_AMD_1AH_M00H_DF_F3 0x12c3
> -#define PCI_DEVICE_ID_AMD_1AH_M20H_DF_F3 0x16fb
> -#define PCI_DEVICE_ID_AMD_1AH_M60H_DF_F3 0x124b
> -#define PCI_DEVICE_ID_AMD_1AH_M70H_DF_F3 0x12bb
> #define PCI_DEVICE_ID_AMD_MI200_DF_F3 0x14d3
> #define PCI_DEVICE_ID_AMD_MI300_DF_F3 0x152b
> #define PCI_DEVICE_ID_AMD_VANGOGH_USB 0x163a
> -#define PCI_DEVICE_ID_AMD_CNB17H_F3 0x1703
> #define PCI_DEVICE_ID_AMD_LANCE 0x2000
> #define PCI_DEVICE_ID_AMD_LANCE_HOME 0x2001
> #define PCI_DEVICE_ID_AMD_SCSI 0x2020
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-09-11 21:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-11 19:17 [PATCH v2 0/2] hwmon: (k10temp): Add 0x1ah/80h Mario Limonciello
2026-09-11 19:17 ` [PATCH v2 1/2] hwmon: (k10temp): Add support for 1ah/80h Mario Limonciello
2026-09-11 19:21 ` sashiko-bot
2026-09-11 21:37 ` Guenter Roeck
2026-09-11 19:17 ` [PATCH v2 2/2] hwmon: (k10temp): Define unshared PCI device IDs locally Mario Limonciello
2026-09-11 19:25 ` sashiko-bot
2026-09-11 21:40 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox