From: sashiko-bot@kernel.org
To: "Alexei Solcanu" <alexei.solcanu@pm.me>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 1/2] hwmon: (gpd-fan) Reset both fans to automatic on duo boards
Date: Sat, 26 Sep 2026 20:19:02 +0000 [thread overview]
Message-ID: <20260926201902.B1B691F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260926-gpd-fan-duo-auto-v2-1-0a2ea41ee3b5@pm.me>
> From: Alexei Solcanu <alexei.solcanu@pm.me>
>
> On boards using gpd_duo_drvdata (GPD Duo, GPD Win 5), writing
> pwm1_enable=2 only returns the first fan to EC control. The second fan
> keeps its last manual duty cycle, e.g. full speed after pwm1=255, so a
> fan control tool that exits leaves it running at that speed.
>
> gpd_duo_write_pwm() writes both fan registers (pwm_write and
> pwm_write + 1), but switching to automatic only clears pwm_write.
> Also clear pwm_write + 1, so both fans return to EC control.
>
> Tested on a GPD Win 5 (G1618-05). Not tested on the GPD Duo.
>
> Fixes: 0ab88e239439 ("hwmon: add GPD devices sensor driver")
> Assisted-by: LLM
> Signed-off-by: Alexei Solcanu <alexei.solcanu@pm.me>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260926-gpd-fan-duo-auto-v2-0-0a2ea41ee3b5@pm.me?part=1
next prev parent reply other threads:[~2026-09-26 20:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-26 20:11 [PATCH v2 0/2] hwmon: (gpd-fan) Fix the second fan on duo boards, split Win 5 fans Alexei Solcanu via B4 Relay
2026-09-26 20:11 ` [PATCH v2 1/2] hwmon: (gpd-fan) Reset both fans to automatic on duo boards Alexei Solcanu via B4 Relay
2026-09-26 20:19 ` sashiko-bot [this message]
2026-09-26 20:22 ` Antheas Kapenekakis
2026-09-26 20:11 ` [PATCH v2 2/2] hwmon: (gpd-fan) Register both fans on the GPD Win 5 Alexei Solcanu via B4 Relay
2026-09-26 20:20 ` sashiko-bot
2026-09-26 20:32 ` Antheas Kapenekakis
2026-09-26 21:36 ` Alexei Solcanu
2026-09-26 21:52 ` Antheas Kapenekakis
2026-09-26 22:15 ` Alexei Solcanu
2026-09-28 11:05 ` Guenter Roeck
2026-09-28 12:03 ` Antheas Kapenekakis
2026-09-28 14:30 ` Guenter Roeck
2026-09-28 13:32 ` Alexei Solcanu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260926201902.B1B691F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexei.solcanu@pm.me \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox