Re: [PATCH v2 2/2] hwmon: (gpd-fan) Register both fans on the GPD Win 5

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] hwmon: gpd-fan: missing gpd_win5_drvdata in gpd_module_drvdata
--

commit 288529d887048f9c76f06b48689bb509162e7569
Author: Alexei Solcanu <alexei.solcanu@pm.me>

hwmon: (gpd-fan) Register both fans on the GPD Win 5

The GPD Win 5 uses gpd_duo_drvdata, which exposes a single fan and pwm
channel. This patch adds separate board data for the Win 5 and registers
one channel per fan.

> diff --git a/drivers/hwmon/gpd-fan.c b/drivers/hwmon/gpd-fan.c
> index b3b75f99f5883..e03b0dde66f94 100644
> --- a/drivers/hwmon/gpd-fan.c
> +++ b/drivers/hwmon/gpd-fan.c
[ ... ]
> @@ -214,7 +233,7 @@ static const struct dmi_system_id dmi_table[] = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "GPD"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "G1618-05"),
>  		},
> -		.driver_data = &gpd_duo_drvdata,
> +		.driver_data = &gpd_win5_drvdata,
>  	},
>  	{
>  		// GPD Pocket 4

[Severity: Low]
Is the new gpd_win5_drvdata also supposed to be added to gpd_module_drvdata?

Looking at the module parameter implementation in gpd-fan.c,
gpd_module_drvdata is iterated to match the module parameter when overriding
DMI detection:

static const struct gpd_fan_drvdata *gpd_module_drvdata[] = {
	&gpd_win_mini_drvdata, &gpd_win4_drvdata, &gpd_wm2_drvdata, &gpd_mpc2_drvdata, NULL
};

Since gpd_win5_drvdata is missing from this array, does this mean users cannot
force the GPD Win 5 configuration using the gpd_fan_board="win5" module
parameter?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260926-gpd-fan-duo-auto-v2-0-0a2ea41ee3b5@pm.me?part=2