* [PATCH v3] hwmon: (asus-ec-sensors) add CPU_Opt fan for ROG STRIX X570-E GAMING
@ 2026-10-06 14:35 Matt Layher via B4 Relay
2026-10-06 14:35 ` Matt Layher via B4 Relay
0 siblings, 1 reply; 4+ messages in thread
From: Matt Layher via B4 Relay @ 2026-10-06 14:35 UTC (permalink / raw)
To: Eugene Shalygin, Guenter Roeck; +Cc: linux-hwmon, linux-kernel, Matt Layher
Testing:
- Runtime: the same one-line change applied to the driver in v6.18.54,
loaded on the board in place of the stock module; CPU_Opt read
1454-1463 RPM and the chipset fan 0.
- Build: hwmon-next with W=1 and sparse (C=1), no warnings;
checkpatch --strict reports no errors, warnings or checks.
Signed-off-by: Matt Layher <mdlayher@gmail.com>
---
Changes in v3:
- Drop the LLM usage note in favor of the Assisted-by tag (Eugene).
- Move the testing notes to a cover letter (Eugene).
- Link to v2: https://patch.msgid.link/20261006-asus-ec-x570e-cpu-opt-v2-1-74df23c22f04@gmail.com
Changes in v2:
- Shorten the commit message (Eugene).
- Link to v1: https://patch.msgid.link/20261004-asus-ec-x570e-cpu-opt-v1-1-d9ea371c30d5@gmail.com
---
Matt Layher (1):
hwmon: (asus-ec-sensors) add CPU_Opt fan for ROG STRIX X570-E GAMING
drivers/hwmon/asus-ec-sensors.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
base-commit: 4781ca52761e666cf18b591e6bb0478396c90320
change-id: 20261004-asus-ec-x570e-cpu-opt-623621af0790
Best regards,
--
Matt Layher <mdlayher@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v3] hwmon: (asus-ec-sensors) add CPU_Opt fan for ROG STRIX X570-E GAMING
2026-10-06 14:35 [PATCH v3] hwmon: (asus-ec-sensors) add CPU_Opt fan for ROG STRIX X570-E GAMING Matt Layher via B4 Relay
@ 2026-10-06 14:35 ` Matt Layher via B4 Relay
2026-10-06 14:40 ` Eugene Shalygin
2026-10-06 14:41 ` sashiko-bot
0 siblings, 2 replies; 4+ messages in thread
From: Matt Layher via B4 Relay @ 2026-10-06 14:35 UTC (permalink / raw)
To: Eugene Shalygin, Guenter Roeck; +Cc: linux-hwmon, linux-kernel, Matt Layher
From: Matt Layher <mdlayher@gmail.com>
The board has a CPU_OPT fan header, which the EC reports at the same
register (bank 0, 0xb0) as the other AMD 500 series boards. Enable it.
Assisted-by: LLM sparse
Signed-off-by: Matt Layher <mdlayher@gmail.com>
---
drivers/hwmon/asus-ec-sensors.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
index 19f423e45ce5..8261ddd00653 100644
--- a/drivers/hwmon/asus-ec-sensors.c
+++ b/drivers/hwmon/asus-ec-sensors.c
@@ -721,7 +721,7 @@ static const struct ec_board_info board_info_strix_x470_i_gaming = {
static const struct ec_board_info board_info_strix_x570_e_gaming = {
.sensors = SENSOR_SET_TEMP_CHIPSET_CPU_MB |
- SENSOR_TEMP_T_SENSOR |
+ SENSOR_TEMP_T_SENSOR | SENSOR_FAN_CPU_OPT |
SENSOR_FAN_CHIPSET | SENSOR_CURR_CPU |
SENSOR_IN_CPU_CORE,
.mutex_path = ASUS_HW_ACCESS_MUTEX_ASMX,
--
2.54.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v3] hwmon: (asus-ec-sensors) add CPU_Opt fan for ROG STRIX X570-E GAMING
2026-10-06 14:35 ` Matt Layher via B4 Relay
@ 2026-10-06 14:40 ` Eugene Shalygin
2026-10-06 14:41 ` sashiko-bot
1 sibling, 0 replies; 4+ messages in thread
From: Eugene Shalygin @ 2026-10-06 14:40 UTC (permalink / raw)
To: mdlayher; +Cc: Guenter Roeck, linux-hwmon, linux-kernel
On Tue, 6 Oct 2026 at 16:36, Matt Layher via B4 Relay
<devnull+mdlayher.gmail.com@kernel.org> wrote:
>
> From: Matt Layher <mdlayher@gmail.com>
>
> The board has a CPU_OPT fan header, which the EC reports at the same
> register (bank 0, 0xb0) as the other AMD 500 series boards. Enable it.
>
> Assisted-by: LLM sparse
> Signed-off-by: Matt Layher <mdlayher@gmail.com>
Reviewed-by: Eugene Shalygin <eugene.shalygin@gmail.com>
Thank you,
Eugene
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] hwmon: (asus-ec-sensors) add CPU_Opt fan for ROG STRIX X570-E GAMING
2026-10-06 14:35 ` Matt Layher via B4 Relay
2026-10-06 14:40 ` Eugene Shalygin
@ 2026-10-06 14:41 ` sashiko-bot
1 sibling, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-10-06 14:41 UTC (permalink / raw)
To: Matt Layher; +Cc: linux-hwmon
> From: Matt Layher <mdlayher@gmail.com>
>
> The board has a CPU_OPT fan header, which the EC reports at the same
> register (bank 0, 0xb0) as the other AMD 500 series boards. Enable it.
>
> Assisted-by: LLM sparse
> Signed-off-by: Matt Layher <mdlayher@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261006-asus-ec-x570e-cpu-opt-v3-1-62672edc18b3@gmail.com?part=1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-10-06 14:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-06 14:35 [PATCH v3] hwmon: (asus-ec-sensors) add CPU_Opt fan for ROG STRIX X570-E GAMING Matt Layher via B4 Relay
2026-10-06 14:35 ` Matt Layher via B4 Relay
2026-10-06 14:40 ` Eugene Shalygin
2026-10-06 14:41 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox