From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wenliang Yan <wenliang202407@163.com>
Cc: conor+dt@kernel.org, corbet@lwn.net, devicetree@vger.kernel.org,
jdelvare@suse.com, krzk+dt@kernel.org,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@roeck-us.net, robh@kernel.org
Subject: Re: [PATCH 3/3] dt-bindings:Add SQ52206 to ina2xx devicetree bindings
Date: Wed, 8 Jan 2025 08:06:37 +0100 [thread overview]
Message-ID: <450da9ec-d754-4dea-99c7-d5730e35a284@kernel.org> (raw)
In-Reply-To: <20250107130110.25525-1-wenliang202407@163.com>
On 07/01/2025 14:01, Wenliang Yan wrote:
>>> Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>> index 05a9cb36cd82..f0b7758ab29f 100644
>>> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>> @@ -20,6 +20,7 @@ description: |
>>> properties:
>>> compatible:
>>> enum:
>>> + - silergy,sq52206
>>
>> So it is compatible or not? You said same bindings, but not compatible?
>>
>
> What I mean is that SQ52206 is compatible.the datasheet depends on
Then compatibility should be expressed in fallback, but OTOH, your
linked changes suggest these are not compatible. Confusing commit msg.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-08 7:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-25 2:03 [PATCH 3/3] dt-bindings:Add SQ52206 to ina2xx devicetree bindings Wenliang Yan
2024-12-27 9:06 ` Krzysztof Kozlowski
2025-01-07 13:01 ` Wenliang Yan
2025-01-08 7:06 ` Krzysztof Kozlowski [this message]
2025-01-08 14:18 ` Guenter Roeck
2025-01-09 8:28 ` Wenliang Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=450da9ec-d754-4dea-99c7-d5730e35a284@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=wenliang202407@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox