[PATCH 3/3] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[PATCH 3/3] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[Wenliang Yan]

From: Wenliang <wenliang202407@163.com>

Document the compatible string for the Silergy SQ52206, this device
is a variant of the existing INA2xx devices and has the same device
tree bindings.

Signed-off-by: Wenliang <wenliang202407@163.com>
---
 Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
index 05a9cb36cd82..f0b7758ab29f 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
@@ -20,6 +20,7 @@ description: |
 properties:
   compatible:
     enum:
+      - silergy,sq52206
       - silergy,sy24655
       - ti,ina209
       - ti,ina219
-- 
2.43.0

Re: [PATCH 3/3] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[Krzysztof Kozlowski]

On Wed, Dec 25, 2024 at 10:03:05AM +0800, Wenliang Yan wrote:
> From: Wenliang <wenliang202407@163.com>
> 
> Document the compatible string for the Silergy SQ52206, this device
> is a variant of the existing INA2xx devices and has the same device
> tree bindings.
> 
> Signed-off-by: Wenliang <wenliang202407@163.com>

Where is the rest of the patches? Why this is 3/3, not first, before the
users (assuming there are users)? If there are no users, then that's a
no...

> ---
>  Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> index 05a9cb36cd82..f0b7758ab29f 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> @@ -20,6 +20,7 @@ description: |
>  properties:
>    compatible:
>      enum:
> +      - silergy,sq52206

So it is compatible or not? You said same bindings, but not compatible?

Best regards,
Krzysztof

Re: [PATCH 3/3] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[Wenliang Yan]

At 2024-12-27 17:06:32, "Krzysztof Kozlowski" <krzk@kernel.org> wrote:
>On Wed, Dec 25, 2024 at 10:03:05AM +0800, Wenliang Yan wrote:
>> From: Wenliang <wenliang202407@163.com>
>> 
>> Document the compatible string for the Silergy SQ52206, this device
>> is a variant of the existing INA2xx devices and has the same device
>> tree bindings.
>> 
>> Signed-off-by: Wenliang <wenliang202407@163.com>
>
>Where is the rest of the patches? Why this is 3/3, not first, before the
>users (assuming there are users)? If there are no users, then that's a
>no...
>

Due to an issue with sending, this email has been lost outside the
thread pool. Attached is the link:
https://lore.kernel.org/linux-hwmon/20241224063559.391061-1-wenliang202407@163.com/
https://lore.kernel.org/linux-hwmon/20241225020256.439990-1-wenliang202407@163.com/

>> ---
>>  Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>> index 05a9cb36cd82..f0b7758ab29f 100644
>> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>> @@ -20,6 +20,7 @@ description: |
>>  properties:
>>    compatible:
>>      enum:
>> +      - silergy,sq52206
>
>So it is compatible or not? You said same bindings, but not compatible?
>

What I mean is that SQ52206 is compatible.the datasheet depends on 
https://us1.silergy.com/cloud/index/uniqid/676b659b4a503
The password is fx6NEe.

>Best regards,
>Krzysztof

Thanks,
Krzysztof

Re: [PATCH 3/3] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[Krzysztof Kozlowski]

On 07/01/2025 14:01, Wenliang Yan wrote:
>>>  Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>> index 05a9cb36cd82..f0b7758ab29f 100644
>>> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>> @@ -20,6 +20,7 @@ description: |
>>>  properties:
>>>    compatible:
>>>      enum:
>>> +      - silergy,sq52206
>>
>> So it is compatible or not? You said same bindings, but not compatible?
>>
> 
> What I mean is that SQ52206 is compatible.the datasheet depends on 


Then compatibility should be expressed in fallback, but OTOH, your
linked changes suggest these are not compatible. Confusing commit msg.



Best regards,
Krzysztof

Re: [PATCH 3/3] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[Guenter Roeck]

On 1/7/25 23:06, Krzysztof Kozlowski wrote:
> On 07/01/2025 14:01, Wenliang Yan wrote:
>>>>   Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>>> index 05a9cb36cd82..f0b7758ab29f 100644
>>>> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>>> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>>> @@ -20,6 +20,7 @@ description: |
>>>>   properties:
>>>>     compatible:
>>>>       enum:
>>>> +      - silergy,sq52206
>>>
>>> So it is compatible or not? You said same bindings, but not compatible?
>>>
>>
>> What I mean is that SQ52206 is compatible.the datasheet depends on
> 
> 
> Then compatibility should be expressed in fallback, but OTOH, your
> linked changes suggest these are not compatible. Confusing commit msg.
> 

It is 'backward compatible' with additional features. That means it is not
'compatible' in devicetree terminology.

Guenter

Re: [PATCH 3/3] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[Wenliang Yan]

At 2025-01-08 22:18:38, "Guenter Roeck" <linux@roeck-us.net> wrote:
>On 1/7/25 23:06, Krzysztof Kozlowski wrote:
>> On 07/01/2025 14:01, Wenliang Yan wrote:
>>>>>   Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 +
>>>>>   1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>>>> index 05a9cb36cd82..f0b7758ab29f 100644
>>>>> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>>>> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>>>> @@ -20,6 +20,7 @@ description: |
>>>>>   properties:
>>>>>     compatible:
>>>>>       enum:
>>>>> +      - silergy,sq52206
>>>>
>>>> So it is compatible or not? You said same bindings, but not compatible?
>>>>
>>>
>>> What I mean is that SQ52206 is compatible.the datasheet depends on
>> 
>> 
>> Then compatibility should be expressed in fallback, but OTOH, your
>> linked changes suggest these are not compatible. Confusing commit msg.
>> 
>
>It is 'backward compatible' with additional features. That means it is not
>'compatible' in devicetree terminology.
>

Thank you for your explanation.
Although SQ52206 has added some new features, it has not affected the
hardware properties.The properties described in the ina2xx.yaml are
applicable to the sq52206 hardware.
So I will just add the sq52206 compatible to the ina2xx.yaml.yaml
from that series. Would that be fine from your side?

Thanks,
Wenliang Yan