[PATCH] hwmon: nct6683 Add support for ASRock Z890 Pro-A

[PATCH] hwmon: nct6683 Add support for ASRock Z890 Pro-A

[Reiner Pröls]

 From ac010d19f5ba1e44a0ddb83cc570f18ca3348015 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Reiner=20Pr=C3=B6ls?= <Reiner.Pröls@gmail.com>
Date: Wed, 20 May 2026 20:59:57 +0200
Subject: [PATCH] Add support for ASRock Z890 Pro-A mainboard
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Reiner Pröls <Reiner.Pröls@gmail.com>
---
  drivers/hwmon/nct6683.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
index 0581770380cc..1b9092f48c7d 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -177,12 +177,13 @@ superio_exit(int ioreg)
  #define NCT6683_CUSTOMER_ID_MSI3    0x207
  #define NCT6683_CUSTOMER_ID_MSI4    0x20d
  #define NCT6683_CUSTOMER_ID_AMD        0x162b
-#define NCT6683_CUSTOMER_ID_ASROCK        0xe2c
+#define NCT6683_CUSTOMER_ID_ASROCK    0xe2c
  #define NCT6683_CUSTOMER_ID_ASROCK2    0xe1b
  #define NCT6683_CUSTOMER_ID_ASROCK3    0x1631
  #define NCT6683_CUSTOMER_ID_ASROCK4    0x163e
  #define NCT6683_CUSTOMER_ID_ASROCK5    0x1621
  #define NCT6683_CUSTOMER_ID_ASROCK6    0x1633
+#define NCT6683_CUSTOMER_ID_ASROCK7    0x163d // Z890 Pro-A

  #define NCT6683_REG_BUILD_YEAR        0x604
  #define NCT6683_REG_BUILD_MONTH        0x605
@@ -1248,6 +1249,8 @@ static int nct6683_probe(struct platform_device *pdev)
          break;
      case NCT6683_CUSTOMER_ID_ASROCK6:
          break;
+    case NCT6683_CUSTOMER_ID_ASROCK7:
+        break;
      default:
          if (!force)
              return -ENODEV;
-- 
2.43.0

Re: [PATCH] hwmon: nct6683 Add support for ASRock Z890 Pro-A

[Guenter Roeck]

On Wed, May 20, 2026 at 09:16:37PM +0200, Reiner Pröls wrote:
> From ac010d19f5ba1e44a0ddb83cc570f18ca3348015 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Reiner=20Pr=C3=B6ls?= <Reiner.Pröls@gmail.com>
> Date: Wed, 20 May 2026 20:59:57 +0200
> Subject: [PATCH] Add support for ASRock Z890 Pro-A mainboard

Subject should be
	"hwmon: (nct6683) Add support for ASRock Z890 Pro-A"
or similar. Actually, your outer subject comes close.

> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 

Description goes here. Look into the driver log for examples.

Also, it looks like you embedded your patch in another patch
with a different subject. That probably triggers:

WARNING: From:/Signed-off-by: email address mismatch: 'From: "Reiner Pröls" <Reiner.Pröls@gmail.com>' != 'Signed-off-by: Reiner Pröls <Reiner.Pröls@gmail.com>'

Also, when I try to apply the patch, I get "patch is empty".

Please fix this up.

> Signed-off-by: Reiner Pröls <Reiner.Pröls@gmail.com>
> ---
>  drivers/hwmon/nct6683.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
> index 0581770380cc..1b9092f48c7d 100644
> --- a/drivers/hwmon/nct6683.c
> +++ b/drivers/hwmon/nct6683.c
> @@ -177,12 +177,13 @@ superio_exit(int ioreg)
>  #define NCT6683_CUSTOMER_ID_MSI3    0x207
>  #define NCT6683_CUSTOMER_ID_MSI4    0x20d
>  #define NCT6683_CUSTOMER_ID_AMD        0x162b
> -#define NCT6683_CUSTOMER_ID_ASROCK        0xe2c
> +#define NCT6683_CUSTOMER_ID_ASROCK    0xe2c
>  #define NCT6683_CUSTOMER_ID_ASROCK2    0xe1b
>  #define NCT6683_CUSTOMER_ID_ASROCK3    0x1631
>  #define NCT6683_CUSTOMER_ID_ASROCK4    0x163e
>  #define NCT6683_CUSTOMER_ID_ASROCK5    0x1621
>  #define NCT6683_CUSTOMER_ID_ASROCK6    0x1633
> +#define NCT6683_CUSTOMER_ID_ASROCK7    0x163d // Z890 Pro-A

No C++ comments in this file, please.

> 
>  #define NCT6683_REG_BUILD_YEAR        0x604
>  #define NCT6683_REG_BUILD_MONTH        0x605
> @@ -1248,6 +1249,8 @@ static int nct6683_probe(struct platform_device *pdev)
>          break;
>      case NCT6683_CUSTOMER_ID_ASROCK6:
>          break;
> +    case NCT6683_CUSTOMER_ID_ASROCK7:
> +        break;

Was this cut-and-paste ? There are no tabs, just spaces, meaning the
patch would not apply. That would also explain the duplicated headers.

Guenter

>      default:
>          if (!force)
>              return -ENODEV;
> -- 
> 2.43.0
> 
> 

Re: [PATCH] hwmon: nct6683 Add support for ASRock Z890 Pro-A

[Reiner Pröls]

[-- Attachment #1: Type: text/plain, Size: 2714 bytes --]

Here the patch as attatchment


Am 20.05.26 um 21:54 schrieb Guenter Roeck:
> On Wed, May 20, 2026 at 09:16:37PM +0200, Reiner Pröls wrote:
>>  From ac010d19f5ba1e44a0ddb83cc570f18ca3348015 Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Reiner=20Pr=C3=B6ls?= <Reiner.Pröls@gmail.com>
>> Date: Wed, 20 May 2026 20:59:57 +0200
>> Subject: [PATCH] Add support for ASRock Z890 Pro-A mainboard
> Subject should be
> 	"hwmon: (nct6683) Add support for ASRock Z890 Pro-A"
> or similar. Actually, your outer subject comes close.
>
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
> Description goes here. Look into the driver log for examples.
>
> Also, it looks like you embedded your patch in another patch
> with a different subject. That probably triggers:
>
> WARNING: From:/Signed-off-by: email address mismatch: 'From: "Reiner Pröls" <Reiner.Pröls@gmail.com>' != 'Signed-off-by: Reiner Pröls <Reiner.Pröls@gmail.com>'
>
> Also, when I try to apply the patch, I get "patch is empty".
>
> Please fix this up.
>
>> Signed-off-by: Reiner Pröls <Reiner.Pröls@gmail.com>
>> ---
>>   drivers/hwmon/nct6683.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
>> index 0581770380cc..1b9092f48c7d 100644
>> --- a/drivers/hwmon/nct6683.c
>> +++ b/drivers/hwmon/nct6683.c
>> @@ -177,12 +177,13 @@ superio_exit(int ioreg)
>>   #define NCT6683_CUSTOMER_ID_MSI3    0x207
>>   #define NCT6683_CUSTOMER_ID_MSI4    0x20d
>>   #define NCT6683_CUSTOMER_ID_AMD        0x162b
>> -#define NCT6683_CUSTOMER_ID_ASROCK        0xe2c
>> +#define NCT6683_CUSTOMER_ID_ASROCK    0xe2c
>>   #define NCT6683_CUSTOMER_ID_ASROCK2    0xe1b
>>   #define NCT6683_CUSTOMER_ID_ASROCK3    0x1631
>>   #define NCT6683_CUSTOMER_ID_ASROCK4    0x163e
>>   #define NCT6683_CUSTOMER_ID_ASROCK5    0x1621
>>   #define NCT6683_CUSTOMER_ID_ASROCK6    0x1633
>> +#define NCT6683_CUSTOMER_ID_ASROCK7    0x163d // Z890 Pro-A
> No C++ comments in this file, please.
>
>>   #define NCT6683_REG_BUILD_YEAR        0x604
>>   #define NCT6683_REG_BUILD_MONTH        0x605
>> @@ -1248,6 +1249,8 @@ static int nct6683_probe(struct platform_device *pdev)
>>           break;
>>       case NCT6683_CUSTOMER_ID_ASROCK6:
>>           break;
>> +    case NCT6683_CUSTOMER_ID_ASROCK7:
>> +        break;
> Was this cut-and-paste ? There are no tabs, just spaces, meaning the
> patch would not apply. That would also explain the duplicated headers.
>
> Guenter
>
>>       default:
>>           if (!force)
>>               return -ENODEV;
>> -- 
>> 2.43.0
>>
>>

[-- Attachment #2: 0001-hwmon-Added-support-for-ASRock-Z890-Pro-A.patch --]
[-- Type: text/x-patch, Size: 1464 bytes --]

From 6d88f02e770fd1965a14f975c3a173feeed9e1ac Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Reiner=20Pr=C3=B6ls?= <Reiner.Pröls@gmail.com>
Date: Wed, 20 May 2026 22:44:45 +0200
Subject: [PATCH] hwmon: Added support for ASRock Z890 Pro-A
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Reiner Pröls <Reiner.Pröls@gmail.com>
---
 drivers/hwmon/nct6683.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
index 0581770380cc..37405329ba78 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -177,12 +177,13 @@ superio_exit(int ioreg)
 #define NCT6683_CUSTOMER_ID_MSI3	0x207
 #define NCT6683_CUSTOMER_ID_MSI4	0x20d
 #define NCT6683_CUSTOMER_ID_AMD		0x162b
-#define NCT6683_CUSTOMER_ID_ASROCK		0xe2c
+#define NCT6683_CUSTOMER_ID_ASROCK	0xe2c
 #define NCT6683_CUSTOMER_ID_ASROCK2	0xe1b
 #define NCT6683_CUSTOMER_ID_ASROCK3	0x1631
 #define NCT6683_CUSTOMER_ID_ASROCK4	0x163e
 #define NCT6683_CUSTOMER_ID_ASROCK5	0x1621
 #define NCT6683_CUSTOMER_ID_ASROCK6	0x1633
+#define NCT6683_CUSTOMER_ID_ASROCK7	0x163d 
 
 #define NCT6683_REG_BUILD_YEAR		0x604
 #define NCT6683_REG_BUILD_MONTH		0x605
@@ -1248,6 +1249,8 @@ static int nct6683_probe(struct platform_device *pdev)
 		break;
 	case NCT6683_CUSTOMER_ID_ASROCK6:
 		break;
+	case NCT6683_CUSTOMER_ID_ASROCK7:
+		break;
 	default:
 		if (!force)
 			return -ENODEV;
-- 
2.43.0

Re: [PATCH] hwmon: nct6683 Add support for ASRock Z890 Pro-A

[Guenter Roeck]

On 5/20/26 13:46, Reiner Pröls wrote:
> Here the patch as attatchment
> 

Sending a patch as attachment will cause it to be dropped from
the mailing list, the AI review agent wont see it, and I
won't even look at it.

Guenter

[PATCH] hwmon: (nct6683) Add support for ASRock Z890 Pro-A

[Reiner Pröls]

From: Reiner Pröls <reiner.proels@gmail.com>

Add the ASRock Z890 Pro-A customer ID to the list of supported
boards for the NCT6683 hardware monitoring driver.

MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Reiner Pröls <reiner.proels@gmail.com>
---
 drivers/hwmon/nct6683.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
index 0581770380cc..37405329ba78 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -177,12 +177,13 @@ superio_exit(int ioreg)
 #define NCT6683_CUSTOMER_ID_MSI3	0x207
 #define NCT6683_CUSTOMER_ID_MSI4	0x20d
 #define NCT6683_CUSTOMER_ID_AMD		0x162b
-#define NCT6683_CUSTOMER_ID_ASROCK		0xe2c
+#define NCT6683_CUSTOMER_ID_ASROCK	0xe2c
 #define NCT6683_CUSTOMER_ID_ASROCK2	0xe1b
 #define NCT6683_CUSTOMER_ID_ASROCK3	0x1631
 #define NCT6683_CUSTOMER_ID_ASROCK4	0x163e
 #define NCT6683_CUSTOMER_ID_ASROCK5	0x1621
 #define NCT6683_CUSTOMER_ID_ASROCK6	0x1633
+#define NCT6683_CUSTOMER_ID_ASROCK7	0x163d

 #define NCT6683_REG_BUILD_YEAR		0x604
 #define NCT6683_REG_BUILD_MONTH		0x605
@@ -1248,6 +1249,8 @@ static int nct6683_probe(struct platform_device *pdev)
 		break;
 	case NCT6683_CUSTOMER_ID_ASROCK6:
 		break;
+	case NCT6683_CUSTOMER_ID_ASROCK7:
+		break;
 	default:
 		if (!force)
 			return -ENODEV;
--
2.43.0

Re: [PATCH] hwmon: (nct6683) Add support for ASRock Z890 Pro-A

[sashiko-bot]

> From: Reiner Pröls <reiner.proels@gmail.com>
> 
> Add the ASRock Z890 Pro-A customer ID to the list of supported
> boards for the NCT6683 hardware monitoring driver.
> 
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Signed-off-by: Reiner Pröls <reiner.proels@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521212632.223724-1-Reiner.Proels@gmail.com?part=1

Re: [PATCH] hwmon: (nct6683) Add support for ASRock Z890 Pro-A

[Guenter Roeck]

On Thu, May 21, 2026 at 11:26:11PM +0200,  Reiner Pröls  wrote:
> From: Reiner Pröls <reiner.proels@gmail.com>
> 
> Add the ASRock Z890 Pro-A customer ID to the list of supported
> boards for the NCT6683 hardware monitoring driver.
> 
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Signed-off-by: Reiner Pröls <reiner.proels@gmail.com>

Applied.

Thanks,
Guenter