From: Guenter Roeck <linux@roeck-us.net>
To: Akshay Gupta <akshay.gupta@amd.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, arnd@arndb.de,
naveenkrishna.chatradhi@amd.com
Subject: Re: [PATCH v2 1/8] hwmon/misc: amd-sbi: Move core sbrmi from hwmon to misc
Date: Wed, 17 Jul 2024 09:26:31 -0700 [thread overview]
Message-ID: <6e8245d5-8c39-491e-9fd0-1be88be7b00a@roeck-us.net> (raw)
In-Reply-To: <20240717081027.2079549-2-akshay.gupta@amd.com>
On 7/17/24 01:10, Akshay Gupta wrote:
> This is done to support other functionality provided by the SBRMI, which
> does not fit in the hwmon subsystem.
>
> - Move the SBRMI core functionality and I2C device probing part to misc.
> - Move hwmon device sensor to misc as only power is reported through
> hwmon sensor.
>
I fail to see the logic here. Why would the supported sensor types
be a reason or an argument for moving the hwmon code out of hwmon ?
Guenter
next prev parent reply other threads:[~2024-07-17 16:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 8:10 [PATCH v2 0/8] misc: Add AMD side band interface(SBI) functionality Akshay Gupta
2024-07-17 8:10 ` [PATCH v2 1/8] hwmon/misc: amd-sbi: Move core sbrmi from hwmon to misc Akshay Gupta
2024-07-17 16:26 ` Guenter Roeck [this message]
2024-07-18 10:21 ` Gupta, Akshay
2024-07-18 14:43 ` Guenter Roeck
2024-07-17 8:10 ` [PATCH v2 2/8] misc: amd-sbi: Use regmap subsystem Akshay Gupta
2024-07-17 8:10 ` [PATCH v2 3/8] misc: amd-sbi: Add support for AMD_SBI IOCTL Akshay Gupta
2024-07-17 8:44 ` Greg KH
2024-07-22 8:18 ` Gupta, Akshay
2024-07-17 8:10 ` [PATCH v2 4/8] misc: amd-sbi: Add support for mailbox error codes Akshay Gupta
2024-07-17 8:10 ` [PATCH v2 5/8] misc: amd-sbi: Add support for CPUID protocol Akshay Gupta
2024-07-17 8:10 ` [PATCH v2 6/8] misc: amd-sbi: Add support for MCA register protocol Akshay Gupta
2024-07-17 8:10 ` [PATCH v2 7/8] misc: amd-sbi: Add supoort for register xfer Akshay Gupta
2024-07-17 8:10 ` [PATCH v2 8/8] misc: amd-sbi: Add document for AMD SB IOCTL description Akshay Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e8245d5-8c39-491e-9fd0-1be88be7b00a@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akshay.gupta@amd.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naveenkrishna.chatradhi@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox