From: Guenter Roeck <linux@roeck-us.net>
To: Akinobu Mita <akinobu.mita@gmail.com>,
Billy Tsai <billy_tsai@aspeedtech.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Jean Delvare <jdelvare@suse.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 1/2] hwmon: (pwm-fan) add option to leave fan on shutdown
Date: Wed, 30 Oct 2024 08:02:55 -0700 [thread overview]
Message-ID: <8a68babc-b4f5-42f2-bc93-ce8f1b7a14e1@roeck-us.net> (raw)
In-Reply-To: <CAC5umyjtCaYPjtgDnJ69c87w825MFSHgm92JA1kWORwP4Hdjww@mail.gmail.com>
On 10/30/24 07:55, Akinobu Mita wrote:
> 2024年10月29日(火) 11:35 Billy Tsai <billy_tsai@aspeedtech.com>:
>>
>>> This adds an optional property "retain-state-shutdown" as requested by
>>> Billy Tsai.
>>
>>> Billy said:
>>> "Our platform is BMC that will use a PWM-FAN driver to control the fan
>>> on the managed host. In our case, we do not want to stop the fan when
>>> the BMC is reboot, which may cause the temperature of the managed host
>>> not to be lowered."
>>
>> I confirmed that it works properly.
>>
>> Reviewed-by: Billy Tsai <billy_tsai@aspeedtech.com>
>> Tested-by: Billy Tsai <billy_tsai@aspeedtech.com>
>
> Thank you very much for testing.
> However, I plan to change this option to device attribute
> (/sys/class/hwmon/hwmonX/retain-state-shutdown) instead of the device tree.
No, I won't acccept that.
Guenter
next prev parent reply other threads:[~2024-10-30 15:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 8:05 [PATCH v2 0/2] hwmon: (pwm-fan) add option to leave fan on shutdown Akinobu Mita
2024-10-26 8:05 ` [PATCH v2 1/2] " Akinobu Mita
2024-10-29 2:34 ` Billy Tsai
2024-10-30 14:55 ` Akinobu Mita
2024-10-30 15:02 ` Guenter Roeck [this message]
2024-10-30 15:18 ` Akinobu Mita
2024-10-30 15:30 ` Guenter Roeck
2024-10-26 8:05 ` [PATCH v2 2/2] dt-bindings: hwmon: pwm-fan: add retain-state-shutdown property Akinobu Mita
2024-10-27 20:38 ` Krzysztof Kozlowski
2024-10-28 12:42 ` Akinobu Mita
2024-10-28 14:22 ` Krzysztof Kozlowski
2024-10-28 14:57 ` Akinobu Mita
2024-10-30 15:18 ` Krzysztof Kozlowski
2024-10-30 15:34 ` Akinobu Mita
2024-11-04 7:45 ` Billy Tsai
2024-11-04 11:47 ` Krzysztof Kozlowski
2024-11-05 8:16 ` Billy Tsai
2024-10-26 16:19 ` [PATCH v2 0/2] hwmon: (pwm-fan) add option to leave fan on shutdown Guenter Roeck
2024-10-27 5:31 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a68babc-b4f5-42f2-bc93-ce8f1b7a14e1@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akinobu.mita@gmail.com \
--cc=billy_tsai@aspeedtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox