Re: [PATCH 1/2] dt-bindings: hwmon: pmbus: add max20830

[Krzysztof Kozlowski <krzk@kernel.org>]

On 16/04/2026 20:09, Guenter Roeck wrote:
> On Thu, Apr 16, 2026 at 05:45:52PM +0000, Roman Gushchin wrote:
>> Krzysztof Kozlowski <krzk@kernel.org> writes:
>>
>>> On Tue, Apr 14, 2026 at 04:38:40AM +0000, sashiko-bot@kernel.org wrote:
>>>> Sashiko AI review found 3 potential issue(s):
>>>> - [Medium] Incomplete Regulator Schema
>>>> - [Medium] Missing Hardware Capability (Interrupts)
>>>> - [Low] Devicetree Best Practices Violation (Node Name)
>>>> --
>>>>
>>>> commit 20a4d8dcd2f3344ac22d7d2e974bae1ef57874ed
>>>> Author: Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
>>>>
>>>> dt-bindings: hwmon: pmbus: add max20830
>>>>
>>>> This commit adds device tree documentation for the MAX20830 step-down DC-DC
>>>> switching regulator with PMBus interface. It allows monitoring of voltage,
>>>> current, and temperature.
>>>
>>> Sashiko devs,
>>> Can we drop such comments? They are useless - we know what the commit is
>>> doing, no point for reviewing tool to say it again.
>>
>> It's the format which originated from initial Chris Mason's prompts
>> and as *I understand* it's purpose was to make sure the llm is reviewing
>> the right patch and more or less understands it. Idk if we still need
>> this, but at least some find it useful: e.g.
>> https://github.com/sashiko-dev/sashiko/issues/90 .
>>
>> I'm planning to do it configurable in UI, but for emails I can
>> only make it configurable on per-subsystem basis.
>> If there is a consensus amongst hwmon maintainers, I'm happy to remove
>> it for hwmon (in several days).
> 
> I find it useful. Please don't take it out. Maybe there is a means to drop
> it from devicetree patches if that is what devicetree maintainers want. Fine
> with me to drop it for those, or to drop devicetree feedback entirely if
> that is what devicetree maintainers want and if it is possible to separate
> devicetree patches submitted as part of a hwmon series from the actual code
> patches.
> 

If there are folks who want them, then it's fine, don't make exception
just for me. I can skip first paragraphs by default :)

Best regards,
Krzysztof