Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: "René Rebe" <rene@exactcode.de>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: "Guenter Roeck" <linux@roeck-us.net>,
	"Thomas Weißschuh" <thomas@t-8ch.de>,
	linux-hwmon@vger.kernel.org, "Hristo Venev" <hristo@venev.name>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Radu Sabau" <radu.sabau@analog.com>,
	"Paul Menzel" <pmenzel@molgen.mpg.de>
Subject: Re: [PATCH 2/3] hwmon: Add support for SPD5118 compliant temperature sensors
Date: Fri, 31 May 2024 12:01:35 +0200	[thread overview]
Message-ID: <BA0B79E0-6582-45EA-8EA9-35E278B8CC42@exactcode.de> (raw)
In-Reply-To: <20240531093154.rna2vwbfx7csu2sj@ninjato>

Hi,

On May 31, 2024, at 11:31, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:
> 
> Hi all,
> 
>>> Wolfgang seems to think it's important:
> 
> Wolfram, please.
> 
>>> https://lore.kernel.org/lkml/tdia472d4pow2osabef24y2ujkkquplfajxmmtk5pnxllsdxsz@wxzynz7llasr/
>>> 
>> 
>> Ok, but that doesn't explain the reason. Wolfram, Paul, why do you
>> think this is needed ? Note that I am not opposed to adding spd
>> eeprom support, but I'd like to know why I am doing it before
>> I spend time on it.
> 
> A working eeprom driver is needed to get 'decode-dimms' from the
> i2c-tools package working. Jean reported that EEPROM access for DDR5 is
> different from DDR4, so it needs a separate driver. And
> i2c_register_spd() then needs to be updated to use the new driver for
> DDR5.

Well my original downstream driver already had eeprom access:

	https://svn.exactcode.de/t2/trunk/package/kernel/linux/spd-5118.patch

Note there are some surrounding -2, and parity patches around this patch.

Thanks,
	René

--
ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
http://exactcode.com | http://exactscan.com | http://ocrkit.com


  reply	other threads:[~2024-05-31 10:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-29 20:52 [PATCH 0/3] hwmon: Add support for SPD5118 compliant temperature sensors Guenter Roeck
2024-05-29 20:52 ` [PATCH 1/3] dt-bindings: hwmon: jedec,spd5118: Add bindings Guenter Roeck
2024-05-29 20:52 ` [PATCH 2/3] hwmon: Add support for SPD5118 compliant temperature sensors Guenter Roeck
2024-05-30  8:08   ` Armin Wolf
2024-05-30 13:23     ` Guenter Roeck
2024-05-30 13:39       ` Guenter Roeck
2024-05-30 16:45         ` Armin Wolf
2024-05-30 16:51           ` Guenter Roeck
2024-05-30 17:06             ` Armin Wolf
2024-05-30  9:08   ` Thomas Weißschuh
2024-05-30 13:27     ` Guenter Roeck
2024-05-30 10:51   ` Thomas Weißschuh
2024-05-30 13:47     ` Guenter Roeck
2024-05-30 13:57       ` Thomas Weißschuh
2024-05-30 14:07         ` Guenter Roeck
2024-05-30 17:03   ` Armin Wolf
2024-05-30 17:33     ` Guenter Roeck
2024-05-30 17:41       ` Armin Wolf
2024-05-30 17:36     ` Guenter Roeck
2024-05-30 20:20   ` Thomas Weißschuh
2024-05-30 20:46     ` Guenter Roeck
2024-05-30 21:02       ` Thomas Weißschuh
2024-05-30 22:33         ` Guenter Roeck
2024-05-31  9:31           ` Wolfram Sang
2024-05-31 10:01             ` René Rebe [this message]
2024-05-31 10:37               ` Thomas Weißschuh
2024-05-31 13:14               ` Guenter Roeck
2024-05-31 13:20                 ` René Rebe
2024-05-31 13:55                   ` Guenter Roeck
2024-05-29 20:52 ` [RFT PATCH 3/3] hwmon: (spd5118) Add PEC support Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BA0B79E0-6582-45EA-8EA9-35E278B8CC42@exactcode.de \
    --to=rene@exactcode.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hristo@venev.name \
    --cc=krzk+dt@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=pmenzel@molgen.mpg.de \
    --cc=radu.sabau@analog.com \
    --cc=robh@kernel.org \
    --cc=thomas@t-8ch.de \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox