From: Guenter Roeck <linux@roeck-us.net>
To: Armin Wolf <W_Armin@gmx.de>, linux-hwmon@vger.kernel.org
Cc: "Hristo Venev" <hristo@venev.name>,
"René Rebe" <rene@exactcode.de>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Radu Sabau" <radu.sabau@analog.com>
Subject: Re: [PATCH 2/3] hwmon: Add support for SPD5118 compliant temperature sensors
Date: Thu, 30 May 2024 10:36:43 -0700 [thread overview]
Message-ID: <be9a987d-9fca-4ef9-be58-58d7b4d8f26d@roeck-us.net> (raw)
In-Reply-To: <6f1ffb83-a64f-469d-b981-f0da0d2f02ac@gmx.de>
On 5/30/24 10:03, Armin Wolf wrote:
[ ... ]
>> +
>> +
>> +PEC configuration
>> +-----------------
>> +
>> +If the I2C/SMBus controller supports PEC, it can be enabled or disabled using
>> +the 'pec' sysfs attribute attached to the i2c device.
>> +
>
> Hi,
>
> the spd5118 only supports PEC when in i3c basic mode, so afaik we cannot use PEC here.
>
Thanks for noticing. I misread the spec and associated the note with PAR_DIS,
not PEC_EN. I'll drop this and the PEC patch. Good that I kept it separate.
Thanks,
Guenter
next prev parent reply other threads:[~2024-05-30 17:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 20:52 [PATCH 0/3] hwmon: Add support for SPD5118 compliant temperature sensors Guenter Roeck
2024-05-29 20:52 ` [PATCH 1/3] dt-bindings: hwmon: jedec,spd5118: Add bindings Guenter Roeck
2024-05-29 20:52 ` [PATCH 2/3] hwmon: Add support for SPD5118 compliant temperature sensors Guenter Roeck
2024-05-30 8:08 ` Armin Wolf
2024-05-30 13:23 ` Guenter Roeck
2024-05-30 13:39 ` Guenter Roeck
2024-05-30 16:45 ` Armin Wolf
2024-05-30 16:51 ` Guenter Roeck
2024-05-30 17:06 ` Armin Wolf
2024-05-30 9:08 ` Thomas Weißschuh
2024-05-30 13:27 ` Guenter Roeck
2024-05-30 10:51 ` Thomas Weißschuh
2024-05-30 13:47 ` Guenter Roeck
2024-05-30 13:57 ` Thomas Weißschuh
2024-05-30 14:07 ` Guenter Roeck
2024-05-30 17:03 ` Armin Wolf
2024-05-30 17:33 ` Guenter Roeck
2024-05-30 17:41 ` Armin Wolf
2024-05-30 17:36 ` Guenter Roeck [this message]
2024-05-30 20:20 ` Thomas Weißschuh
2024-05-30 20:46 ` Guenter Roeck
2024-05-30 21:02 ` Thomas Weißschuh
2024-05-30 22:33 ` Guenter Roeck
2024-05-31 9:31 ` Wolfram Sang
2024-05-31 10:01 ` René Rebe
2024-05-31 10:37 ` Thomas Weißschuh
2024-05-31 13:14 ` Guenter Roeck
2024-05-31 13:20 ` René Rebe
2024-05-31 13:55 ` Guenter Roeck
2024-05-29 20:52 ` [RFT PATCH 3/3] hwmon: (spd5118) Add PEC support Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be9a987d-9fca-4ef9-be58-58d7b4d8f26d@roeck-us.net \
--to=linux@roeck-us.net \
--cc=W_Armin@gmx.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hristo@venev.name \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=radu.sabau@analog.com \
--cc=rene@exactcode.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox