From: "Abdurrahman Hussain" <abdurrahman@nexthop.ai>
To: "Guenter Roeck" <linux@roeck-us.net>,
"Abdurrahman Hussain" <abdurrahman@nexthop.ai>
Cc: "Alexandru Tachici" <alexandru.tachici@analog.com>,
<linux-hwmon@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Guenter Roeck" <groeck7@gmail.com>
Subject: Re: [PATCH v3 1/5] hwmon: (pmbus/adm1266) add firmware_revision debugfs entry
Date: Thu, 14 May 2026 22:57:24 -0700 [thread overview]
Message-ID: <DIJ0PKKGIBSW.36AIGOA7ZDF5W@nexthop.ai> (raw)
In-Reply-To: <53fa7ca2-a2d1-44a9-8d15-48ecae68d3c9@roeck-us.net>
On Thu May 14, 2026 at 9:48 PM PDT, Guenter Roeck wrote:
> My understanding is that there is no in-kernel API to inform drivers
> about a rtc update. No other driver seems to need this.
> I see a number of options:
>
> 1) Use ktime_get_real_seconds() in probe, just like every other Linux
> driver using the real time clock does without problems.
> 2) schedule a timer which updates the clock every hour ? day ?
> 3) Attach a sysfs attribute to the i2c device to trigger a time sync.
>
> 2) and 3) are a bit excessive, so you'll need to provide a specific
> use case. "Because the datasheet says so" is not a use case.
>
Going with option 1. The current ktime_get_seconds() seed is
CLOCK_MONOTONIC, so this is a bug fix in disguise -- I'll land the
ktime_get_real_seconds() switch in the pre-existing fix series with
a Fixes: tag.
Thanks,
Abdurrahman
next prev parent reply other threads:[~2026-05-15 5:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 18:56 [PATCH v3 0/5] hwmon: (pmbus/adm1266) blackbox, FW rev, rtc_class, GPIO label Abdurrahman Hussain
2026-05-12 18:56 ` [PATCH v3 1/5] hwmon: (pmbus/adm1266) add firmware_revision debugfs entry Abdurrahman Hussain
2026-05-15 1:42 ` Guenter Roeck
2026-05-15 3:35 ` Abdurrahman Hussain
2026-05-15 4:48 ` Guenter Roeck
2026-05-15 5:57 ` Abdurrahman Hussain [this message]
2026-05-12 18:56 ` [PATCH v3 2/5] hwmon: (pmbus/adm1266) add clear_blackbox " Abdurrahman Hussain
2026-05-14 0:47 ` sashiko-bot
2026-05-14 4:58 ` Abdurrahman Hussain
2026-05-12 18:56 ` [PATCH v3 3/5] hwmon: (pmbus/adm1266) add powerup_counter " Abdurrahman Hussain
2026-05-14 1:17 ` sashiko-bot
2026-05-12 18:56 ` [PATCH v3 4/5] hwmon: (pmbus/adm1266) replace probe-time RTC seed with rtc_class device Abdurrahman Hussain
2026-05-14 1:57 ` sashiko-bot
2026-05-14 2:14 ` Guenter Roeck
2026-05-14 2:14 ` Guenter Roeck
2026-05-14 4:25 ` Abdurrahman Hussain
2026-05-12 18:56 ` [PATCH v3 5/5] hwmon: (pmbus/adm1266) include adapter number in GPIO line label Abdurrahman Hussain
2026-05-15 1:45 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIJ0PKKGIBSW.36AIGOA7ZDF5W@nexthop.ai \
--to=abdurrahman@nexthop.ai \
--cc=alexandru.tachici@analog.com \
--cc=groeck7@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox