Re: [PATCH] k10temp support for AMD Ryzen w/ Vega gfx

["René Rebe" <rene@exactcode.de>]

[-- Attachment #1: Type: text/plain, Size: 2571 bytes --]

Hi,

On 06 Mar 2018, at 00:03, Guenter Roeck <linux@roeck-us.net> wrote:

> On Mon, Mar 05, 2018 at 11:38:24PM +0100, René Rebe wrote:
>> Hi,
>> 
>> This enables k10temp for the new AMD Ryzen APUs w/ Vega Mobile Gfx.
>> Tested on Ryzen 5 2500U, the temperature looked plausible.
>> 
>>  Signed-off-by: René Rebe <rene@exactcode.de>
>> 
>> PS: 1st RFC - might get white-space damaged, will resend when ACKed.
>> Sorry my Xemacs/Mew broke.
>> 
>> --- linux-4.15/drivers/hwmon/k10temp.c.vanilla	2018-03-05 22:22:30.974331180 +0000
>> +++ linux-4.15/drivers/hwmon/k10temp.c	2018-03-05 22:24:17.186327291 +0000
>> @@ -40,6 +40,10 @@
>> #define PCI_DEVICE_ID_AMD_17H_DF_F3	0x1463
>> #endif
>> 
>> +#ifndef PCI_DEVICE_ID_AMD_17H_RR_NB
>> +#define PCI_DEVICE_ID_AMD_17H_RR_NB	0x15d0
>> +#endif
>> +
>> /* CPUID function 0x80000001, ebx */
>> #define CPUID_PKGTYPE_MASK	0xf0000000
>> #define CPUID_PKGTYPE_F		0x00000000
>> @@ -89,6 +93,8 @@
>> 	{ 0x17, "AMD Ryzen Threadripper 1950", 10000 },
>> 	{ 0x17, "AMD Ryzen Threadripper 1920", 10000 },
>> 	{ 0x17, "AMD Ryzen Threadripper 1910", 10000 },
>> +	{ 0x17, "AMD Ryzen 5 2500U with Radeon Vega Mobile Gfx", 20000 },
>> +	{ 0x17, "AMD Ryzen 7 2700U with Radeon Vega Mobile Gfx", 20000 },
> 
> Do you have a confirmation that the temperature offset is correct ?

I tried all of the three currently used offsets and this was looked the most plausible.
For me having some indication of temperature is better than having none at all.
Maybe some contact at AMD can shed some light on it, too?

> Thanks,
> Guenter
> 
>> };
>> 
>> static void read_tempreg_pci(struct pci_dev *pdev, u32 *regval)
>> @@ -289,6 +2944,7 @@
>> 	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_16H_NB_F3) },
>> 	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_16H_M30H_NB_F3) },
>> 	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_17H_DF_F3) },
>> +	{ PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_17H_RR_NB) },
>> 	{}
>> };
>> MODULE_DEVICE_TABLE(pci, k10temp_id_table);
>> 
>> -- 
>> ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
>> http://exactcode.com | http://exactscan.com | http://ocrkit.com | http://t2-project.org | http://rene.rebe.de
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
 ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
 http://exactcode.com | http://exactscan.com | http://ocrkit.com | http://t2-project.org | http://rene.rebe.de


[-- Attachment #2: Type: text/html, Size: 5451 bytes --]