From: Borislav Petkov <bp@alien8.de>
To: Naveen Krishna Chatradhi <nchatrad@amd.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, linux@roeck-us.net, yazen.ghannam@amd.com,
mingo@redhat.com, nathan.fontenot@amd.com, lewis.carroll@amd.com,
Ingo Molnar <mingo@kernel.org>, Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH 1/3] x86/amd_nb: Add support for HSMP mailbox access
Date: Thu, 2 Sep 2021 19:58:36 +0200 [thread overview]
Message-ID: <YTEQzIVfY/A1uy32@zn.tnic> (raw)
In-Reply-To: <20210902174155.7365-1-nchatrad@amd.com>
On Thu, Sep 02, 2021 at 11:11:53PM +0530, Naveen Krishna Chatradhi wrote:
> On Fam19h server CPUs from AMD an HSMP (Host System Management Port)
> mailbox interface is added to monitor and manage the CPU parameters.
Mailbox? Hmm, that rings a bell. There's drivers/mailbox/ with a bunch
of drivers in there. Those are
"Mailbox is a framework to control hardware communication between
on-chip processors through queued messages and interrupt driven
signals."
I wonder if that HSMP thing can be wrapped like a mailbox driver...
If not, I still don't like it being slapped in amd_nb.c where it would
be built in on *all* AMD hardware which is kinda too much.
You could make it a separate driver module called amd_hsmp.ko which
loads only on the appropriate hw and uses amd_nb.c for detection only
like the other drivers, for example.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-09-02 17:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 17:41 [PATCH 1/3] x86/amd_nb: Add support for HSMP mailbox access Naveen Krishna Chatradhi
2021-09-02 17:41 ` [PATCH 2/3] k10temp: Remove residues of current and voltage Naveen Krishna Chatradhi
2021-09-02 19:15 ` Guenter Roeck
2021-09-02 17:41 ` [PATCH 3/3] k10temp: Add power sensor for family 19h Naveen Krishna Chatradhi
2021-09-02 19:26 ` Guenter Roeck
2021-09-02 17:58 ` Borislav Petkov [this message]
2021-09-08 17:11 ` [PATCH 1/3] x86/amd_nb: Add support for HSMP mailbox access Chatradhi, Naveen Krishna
2021-09-10 9:57 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTEQzIVfY/A1uy32@zn.tnic \
--to=bp@alien8.de \
--cc=jdelvare@suse.com \
--cc=lewis.carroll@amd.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=nathan.fontenot@amd.com \
--cc=nchatrad@amd.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox