Re: [PATCH v2 1/2] hwmon: (pmbus/ltc2978) Use driver specific ops if they exist

[Marten Lindahl <martenli@axis.com>]

On Tue, Apr 26, 2022 at 03:39:15PM +0200, Guenter Roeck wrote:
> On 4/26/22 02:29, Mårten Lindahl wrote:
> > Several of the manuals for devices supported by this driver describes
> > the need for a minimum wait time before the chip is ready to receive
> > next command.
> > 
> > This wait time is already implemented in the driver as a ltc_wait_ready
> > function with a driver defined wait time of 100 ms, and is considered
> > for specific devices before reading/writing data on the pmbus.
> > 
> > Since this driver uses the default pmbus_regulator_ops for the enable/
> > disable/is_enabled functions and these functions do not check for driver
> > specific read/write ops, the wait time recommendations are bypassed for
> > several of the devices managed by this driver (ltc3880/ltc3882/ltc3883/
> > ltc3884/ltc3886/ltc3887/ltc3889/ltm4664/ltm4675/ltm4676/ltm4677/ltm4678/
> > ltm4680/ltm4686/ltm4700/ltc7880).
> > 
> > Lets add support for driver specific callbacks in pmbus core which takes
> > the wait time into consideration for the specified devices.
> > 
> 
> This should be two patches: one patch to add the callback to the pmbus core
> and a second patch to use it from the ltc2978 driver.

Ok, I will do that. Thanks!
Kind regards
Mårten

> 
> Guenter