From: Guenter Roeck <linux@roeck-us.net>
To: "Mårten Lindahl" <marten.lindahl@axis.com>,
"Jean Delvare" <jdelvare@suse.com>
Cc: linux-hwmon@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH v2 1/2] hwmon: (pmbus/ltc2978) Use driver specific ops if they exist
Date: Tue, 26 Apr 2022 06:39:15 -0700 [thread overview]
Message-ID: <a7fa7c5f-578f-480d-a2c3-eecb38032202@roeck-us.net> (raw)
In-Reply-To: <20220426092936.1127114-2-marten.lindahl@axis.com>
On 4/26/22 02:29, Mårten Lindahl wrote:
> Several of the manuals for devices supported by this driver describes
> the need for a minimum wait time before the chip is ready to receive
> next command.
>
> This wait time is already implemented in the driver as a ltc_wait_ready
> function with a driver defined wait time of 100 ms, and is considered
> for specific devices before reading/writing data on the pmbus.
>
> Since this driver uses the default pmbus_regulator_ops for the enable/
> disable/is_enabled functions and these functions do not check for driver
> specific read/write ops, the wait time recommendations are bypassed for
> several of the devices managed by this driver (ltc3880/ltc3882/ltc3883/
> ltc3884/ltc3886/ltc3887/ltc3889/ltm4664/ltm4675/ltm4676/ltm4677/ltm4678/
> ltm4680/ltm4686/ltm4700/ltc7880).
>
> Lets add support for driver specific callbacks in pmbus core which takes
> the wait time into consideration for the specified devices.
>
This should be two patches: one patch to add the callback to the pmbus core
and a second patch to use it from the ltc2978 driver.
Guenter
next prev parent reply other threads:[~2022-04-26 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 9:29 [PATCH v2 0/2] hwmon: (pmbus/ltc2978) Add regulator ops Mårten Lindahl
2022-04-26 9:29 ` [PATCH v2 1/2] hwmon: (pmbus/ltc2978) Use driver specific ops if they exist Mårten Lindahl
2022-04-26 13:39 ` Guenter Roeck [this message]
2022-04-26 15:06 ` Marten Lindahl
2022-04-26 9:29 ` [PATCH v2 2/2] hwmon: (pmbus/ltc2978) Add get_voltage/set_voltage ops Mårten Lindahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7fa7c5f-578f-480d-a2c3-eecb38032202@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=kernel@axis.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=marten.lindahl@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox