From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Hardware Monitoring <linux-hwmon@vger.kernel.org>
Subject: Re: [RFC/RFT PATCH v2] hwmon: (lm75) Hide register size differences in regmap access functions
Date: Fri, 20 Dec 2024 07:21:06 +0100 [thread overview]
Message-ID: <Z2UM0p3YYa4JfCz2@shikoro> (raw)
In-Reply-To: <20241218150404.2713377-1-linux@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 884 bytes --]
On Wed, Dec 18, 2024 at 07:04:04AM -0800, Guenter Roeck wrote:
> Hide register size differences in regmap access functions to simplify
> runtime code and to simplify adding support for I3C devices. Also
> use regmap API functions for bit operations where possible.
>
> For this to work, the 16-bit and 8-bit configuration register has to be
> mapped to a 16-bit value. Unlike other registers, this register is a
> low-byte-first register, presumably for compatibility with chips with
> 8-bit wide configuration registers. Hide the differences in the regmap
> access code.
>
> While at it, enable alarm attribute support for TMP112.
>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-12-20 6:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 15:04 [RFC/RFT PATCH v2] hwmon: (lm75) Hide register size differences in regmap access functions Guenter Roeck
2024-12-18 16:07 ` Wolfram Sang
2024-12-18 16:21 ` Guenter Roeck
2024-12-18 16:25 ` Wolfram Sang
2024-12-18 16:36 ` Guenter Roeck
2024-12-18 16:41 ` Guenter Roeck
2024-12-18 17:39 ` Wolfram Sang
2024-12-18 17:53 ` Guenter Roeck
2024-12-20 6:21 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2UM0p3YYa4JfCz2@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox