From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Hardware Monitoring <linux-hwmon@vger.kernel.org>
Subject: Re: [RFC/RFT PATCH v2] hwmon: (lm75) Hide register size differences in regmap access functions
Date: Wed, 18 Dec 2024 08:36:40 -0800 [thread overview]
Message-ID: <d97d5227-9672-40cf-9df4-804b22affc3d@roeck-us.net> (raw)
In-Reply-To: <Z2L3dhneuMi9ckUe@ninjato>
On 12/18/24 08:25, Wolfram Sang wrote:
>
>> Ah yes, 'client' can be passed as bus context, and isn't used elsewhere.
>> The access functions need lm75_data, but they can get the pointer to it
>> from drvdata.
>
> Yup, that's exactly what I did.
>
>> Maybe that should be part of this patch. I assume you'll take it over - do you
>> want to make that change or should I send another version ? Handling it in a
>> separate patch is fine with me as well if you prefer to do that.
>
> Since I already have that patch on top, I suggest to keep it
> incremental. Also easier to debug if something goes wrong etc...
>
SGTM. I'll let you handle the series from here.
Thanks,
Guenter
next prev parent reply other threads:[~2024-12-18 16:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 15:04 [RFC/RFT PATCH v2] hwmon: (lm75) Hide register size differences in regmap access functions Guenter Roeck
2024-12-18 16:07 ` Wolfram Sang
2024-12-18 16:21 ` Guenter Roeck
2024-12-18 16:25 ` Wolfram Sang
2024-12-18 16:36 ` Guenter Roeck [this message]
2024-12-18 16:41 ` Guenter Roeck
2024-12-18 17:39 ` Wolfram Sang
2024-12-18 17:53 ` Guenter Roeck
2024-12-20 6:21 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d97d5227-9672-40cf-9df4-804b22affc3d@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox