Re: [bug report] hwmon: (pmbus) Register with thermal for PSC_TEMPERATURE

[Eduardo Valentin <eduval@amazon.com>]

Hello,

On Fri, Jul 19, 2024 at 05:33:19PM -0500, Dan Carpenter wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> 
> 
> 
> On Fri, Jul 19, 2024 at 02:10:16PM -0700, Guenter Roeck wrote:
> > >      1373
> > >      1374         /* temperature sensors with _input values are registered with thermal */
> > > --> 1375         if (class == PSC_TEMPERATURE && strcmp(type, "input") == 0)
> > >                                                          ^^^^
> > > Unchecked dereference
> > >
> >
> > It is only NULL for PSC_PWM, never for PSC_TEMPERATURE. We could add a check to
> > make the static checker happy but it won't make a practical difference.
> 
> No, don't do that.  Just ignore the warning in that case.
> 
> I'm running with the cross function database, and in theory that should
> have silenced the warning.  I'll investigate.

Nice you are doing this, Dan.

Yeah. Let me know the outcome of your investigation. I can always patch it up.

Thanks.

> 
> 
> regards,
> dan carpenter
> 

-- 
All the best,
Eduardo Valentin