From: Dan Carpenter <dan.carpenter@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Eduardo Valentin <eduval@amazon.com>, linux-hwmon@vger.kernel.org
Subject: Re: [bug report] hwmon: (pmbus) Register with thermal for PSC_TEMPERATURE
Date: Fri, 19 Jul 2024 17:33:19 -0500 [thread overview]
Message-ID: <d88d5476-eec4-4e0c-8375-18dcc168e31e@suswa.mountain> (raw)
In-Reply-To: <cddb4e8e-4b4d-48de-a02d-4931c373b47b@roeck-us.net>
On Fri, Jul 19, 2024 at 02:10:16PM -0700, Guenter Roeck wrote:
> > 1373
> > 1374 /* temperature sensors with _input values are registered with thermal */
> > --> 1375 if (class == PSC_TEMPERATURE && strcmp(type, "input") == 0)
> > ^^^^
> > Unchecked dereference
> >
>
> It is only NULL for PSC_PWM, never for PSC_TEMPERATURE. We could add a check to
> make the static checker happy but it won't make a practical difference.
No, don't do that. Just ignore the warning in that case.
I'm running with the cross function database, and in theory that should
have silenced the warning. I'll investigate.
regards,
dan carpenter
next prev parent reply other threads:[~2024-07-19 22:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 20:55 [bug report] hwmon: (pmbus) Register with thermal for PSC_TEMPERATURE Dan Carpenter
2024-07-19 21:10 ` Guenter Roeck
2024-07-19 22:33 ` Dan Carpenter [this message]
2024-07-29 21:16 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d88d5476-eec4-4e0c-8375-18dcc168e31e@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=eduval@amazon.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox