* [PATCH] hwmon: (lm75) Fix I3C transfer buffer pointer for incoming data
@ 2025-05-13 11:17 Jarkko Nikula
2025-05-13 13:41 ` Guenter Roeck
2025-05-14 9:05 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Jarkko Nikula @ 2025-05-13 11:17 UTC (permalink / raw)
To: linux-hwmon; +Cc: Jean Delvare, Guenter Roeck, Wolfram Sang, Jarkko Nikula
Use the I3C private transfer input buffer pointer for incoming data
instead of output buffer. For now this is harmless since both of those
pointers are union members but may confuse when reading the code.
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
Build tested only.
---
drivers/hwmon/lm75.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
index d95a3c6c245c..9b4875e2fd8d 100644
--- a/drivers/hwmon/lm75.c
+++ b/drivers/hwmon/lm75.c
@@ -622,7 +622,7 @@ static int lm75_i3c_reg_read(void *context, unsigned int reg, unsigned int *val)
{
.rnw = true,
.len = 2,
- .data.out = data->val_buf,
+ .data.in = data->val_buf,
},
};
int ret;
--
2.47.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hwmon: (lm75) Fix I3C transfer buffer pointer for incoming data
2025-05-13 11:17 [PATCH] hwmon: (lm75) Fix I3C transfer buffer pointer for incoming data Jarkko Nikula
@ 2025-05-13 13:41 ` Guenter Roeck
2025-05-14 9:05 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2025-05-13 13:41 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: linux-hwmon, Jean Delvare, Wolfram Sang
On Tue, May 13, 2025 at 02:17:39PM +0300, Jarkko Nikula wrote:
> Use the I3C private transfer input buffer pointer for incoming data
> instead of output buffer. For now this is harmless since both of those
> pointers are union members but may confuse when reading the code.
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hwmon: (lm75) Fix I3C transfer buffer pointer for incoming data
2025-05-13 11:17 [PATCH] hwmon: (lm75) Fix I3C transfer buffer pointer for incoming data Jarkko Nikula
2025-05-13 13:41 ` Guenter Roeck
@ 2025-05-14 9:05 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2025-05-14 9:05 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: linux-hwmon, Jean Delvare, Guenter Roeck
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
On Tue, May 13, 2025 at 02:17:39PM +0300, Jarkko Nikula wrote:
> Use the I3C private transfer input buffer pointer for incoming data
> instead of output buffer. For now this is harmless since both of those
> pointers are union members but may confuse when reading the code.
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
FTR:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
I am on the road, so I cannot test it currently. I wanted to do this
once I am back.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-14 9:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-13 11:17 [PATCH] hwmon: (lm75) Fix I3C transfer buffer pointer for incoming data Jarkko Nikula
2025-05-13 13:41 ` Guenter Roeck
2025-05-14 9:05 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox