* [PATCH 14/62] hwmon: (it87) Check the it87_lock() return value [not found] <20260223220102.2158611-1-bart.vanassche@linux.dev> @ 2026-02-23 22:00 ` Bart Van Assche 2026-02-24 15:31 ` Guenter Roeck 0 siblings, 1 reply; 4+ messages in thread From: Bart Van Assche @ 2026-02-23 22:00 UTC (permalink / raw) To: Peter Zijlstra Cc: Ingo Molnar, Will Deacon, Boqun Feng, Waiman Long, linux-kernel, Marco Elver, Christoph Hellwig, Steven Rostedt, Nick Desaulniers, Nathan Chancellor, Kees Cook, Jann Horn, Bart Van Assche, Frank Crawford, Guenter Roeck, Jean Delvare, linux-hwmon From: Bart Van Assche <bvanassche@acm.org> Return early in it87_resume() if it87_lock() fails instead of ignoring the return value of that function. This patch suppresses a Clang thread-safety warning. Cc: Frank Crawford <frank@crawford.emu.id.au> Cc: Guenter Roeck <linux@roeck-us.net> Cc: Jean Delvare <jdelvare@suse.com> Cc: linux-hwmon@vger.kernel.org Fixes: 376e1a937b30 ("hwmon: (it87) Add calls to smbus_enable/smbus_disable as required") Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/hwmon/it87.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index e233aafa8856..8e3935089fca 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -3593,7 +3593,9 @@ static int it87_resume(struct device *dev) it87_resume_sio(pdev); - it87_lock(data); + int err = it87_lock(data); + if (err) + return err; it87_check_pwm(dev); it87_check_limit_regs(data); ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 14/62] hwmon: (it87) Check the it87_lock() return value 2026-02-23 22:00 ` [PATCH 14/62] hwmon: (it87) Check the it87_lock() return value Bart Van Assche @ 2026-02-24 15:31 ` Guenter Roeck 0 siblings, 0 replies; 4+ messages in thread From: Guenter Roeck @ 2026-02-24 15:31 UTC (permalink / raw) To: Bart Van Assche Cc: Peter Zijlstra, Ingo Molnar, Will Deacon, Boqun Feng, Waiman Long, linux-kernel, Marco Elver, Christoph Hellwig, Steven Rostedt, Nick Desaulniers, Nathan Chancellor, Kees Cook, Jann Horn, Bart Van Assche, Frank Crawford, Jean Delvare, linux-hwmon On Mon, Feb 23, 2026 at 02:00:14PM -0800, Bart Van Assche wrote: > From: Bart Van Assche <bvanassche@acm.org> > > Return early in it87_resume() if it87_lock() fails instead of ignoring the > return value of that function. This patch suppresses a Clang thread-safety > warning. > > Cc: Frank Crawford <frank@crawford.emu.id.au> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Jean Delvare <jdelvare@suse.com> > Cc: linux-hwmon@vger.kernel.org > Fixes: 376e1a937b30 ("hwmon: (it87) Add calls to smbus_enable/smbus_disable as required") > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > drivers/hwmon/it87.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c > index e233aafa8856..8e3935089fca 100644 > --- a/drivers/hwmon/it87.c > +++ b/drivers/hwmon/it87.c > @@ -3593,7 +3593,9 @@ static int it87_resume(struct device *dev) > > it87_resume_sio(pdev); > > - it87_lock(data); > + int err = it87_lock(data); > + if (err) > + return err; checkpatch: missing empty line after declarations. Oh, never mind, I'll fix that up and declare ret at the beginning of the function, to match the rest of the driver. Applied. Guenter ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20260223215118.2154194-1-bvanassche@acm.org>]
* [PATCH 14/62] hwmon: (it87) Check the it87_lock() return value [not found] <20260223215118.2154194-1-bvanassche@acm.org> @ 2026-02-23 21:50 ` Bart Van Assche 0 siblings, 0 replies; 4+ messages in thread From: Bart Van Assche @ 2026-02-23 21:50 UTC (permalink / raw) To: Peter Zijlstra Cc: Ingo Molnar, Will Deacon, Boqun Feng, Waiman Long, linux-kernel, Marco Elver, Christoph Hellwig, Steven Rostedt, Nick Desaulniers, Nathan Chancellor, Kees Cook, Jann Horn, Bart Van Assche, Frank Crawford, Guenter Roeck, Jean Delvare, linux-hwmon Return early in it87_resume() if it87_lock() fails instead of ignoring the return value of that function. This patch suppresses a Clang thread-safety warning. Cc: Frank Crawford <frank@crawford.emu.id.au> Cc: Guenter Roeck <linux@roeck-us.net> Cc: Jean Delvare <jdelvare@suse.com> Cc: linux-hwmon@vger.kernel.org Fixes: 376e1a937b30 ("hwmon: (it87) Add calls to smbus_enable/smbus_disable as required") Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/hwmon/it87.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index e233aafa8856..8e3935089fca 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -3593,7 +3593,9 @@ static int it87_resume(struct device *dev) it87_resume_sio(pdev); - it87_lock(data); + int err = it87_lock(data); + if (err) + return err; it87_check_pwm(dev); it87_check_limit_regs(data); ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <20260223214950.2153735-1-bvanassche@acm.org>]
* [PATCH 14/62] hwmon: (it87) Check the it87_lock() return value [not found] <20260223214950.2153735-1-bvanassche@acm.org> @ 2026-02-23 21:49 ` Bart Van Assche 0 siblings, 0 replies; 4+ messages in thread From: Bart Van Assche @ 2026-02-23 21:49 UTC (permalink / raw) To: Peter Zijlstra Cc: Bart Van Assche, Frank Crawford, Guenter Roeck, Jean Delvare, linux-hwmon Return early in it87_resume() if it87_lock() fails instead of ignoring the return value of that function. This patch suppresses a Clang thread-safety warning. Cc: Frank Crawford <frank@crawford.emu.id.au> Cc: Guenter Roeck <linux@roeck-us.net> Cc: Jean Delvare <jdelvare@suse.com> Cc: linux-hwmon@vger.kernel.org Fixes: 376e1a937b30 ("hwmon: (it87) Add calls to smbus_enable/smbus_disable as required") Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/hwmon/it87.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c index e233aafa8856..8e3935089fca 100644 --- a/drivers/hwmon/it87.c +++ b/drivers/hwmon/it87.c @@ -3593,7 +3593,9 @@ static int it87_resume(struct device *dev) it87_resume_sio(pdev); - it87_lock(data); + int err = it87_lock(data); + if (err) + return err; it87_check_pwm(dev); it87_check_limit_regs(data); ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-24 15:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260223220102.2158611-1-bart.vanassche@linux.dev>
2026-02-23 22:00 ` [PATCH 14/62] hwmon: (it87) Check the it87_lock() return value Bart Van Assche
2026-02-24 15:31 ` Guenter Roeck
[not found] <20260223215118.2154194-1-bvanassche@acm.org>
2026-02-23 21:50 ` Bart Van Assche
[not found] <20260223214950.2153735-1-bvanassche@acm.org>
2026-02-23 21:49 ` Bart Van Assche
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox