* [PATCH] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist
@ 2024-12-07 20:26 Povilas Kanapickas
2024-12-07 21:26 ` Armin Wolf
0 siblings, 1 reply; 3+ messages in thread
From: Povilas Kanapickas @ 2024-12-07 20:26 UTC (permalink / raw)
To: pali; +Cc: jdelvare, linux, linux-hwmon, linux-kernel
Add the Dell XPS 9370 to the fan control whitelist to allow
for manual fan control.
Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
---
drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index f5bdf842040e..bcb295ea3319 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1544,6 +1544,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
},
.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
},
+ {
+ .ident = "Dell XPS 13 9370",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9370"),
+ },
+ .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
+ },
{
.ident = "Dell Optiplex 7000",
.matches = {
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist
2024-12-07 20:26 [PATCH] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist Povilas Kanapickas
@ 2024-12-07 21:26 ` Armin Wolf
2025-01-09 21:03 ` Povilas Kanapickas
0 siblings, 1 reply; 3+ messages in thread
From: Armin Wolf @ 2024-12-07 21:26 UTC (permalink / raw)
To: Povilas Kanapickas, pali; +Cc: jdelvare, linux, linux-hwmon, linux-kernel
Am 07.12.24 um 21:26 schrieb Povilas Kanapickas:
> Add the Dell XPS 9370 to the fan control whitelist to allow
> for manual fan control.
Can you check if using i8k_fan_control_data[I8K_FAN_30A3_31A3] also works?
The reason for this is that the official Dell software seems to use those SMM calls
to enable/disable automatic fan control. If this does not work then you can keep
the i8k_fan_control_data[I8K_FAN_34A3_35A3].
Thanks,
Armin Wolf
> Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
> ---
> drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index f5bdf842040e..bcb295ea3319 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1544,6 +1544,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
> },
> .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> },
> + {
> + .ident = "Dell XPS 13 9370",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9370"),
> + },
> + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> + },
> {
> .ident = "Dell Optiplex 7000",
> .matches = {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist
2024-12-07 21:26 ` Armin Wolf
@ 2025-01-09 21:03 ` Povilas Kanapickas
0 siblings, 0 replies; 3+ messages in thread
From: Povilas Kanapickas @ 2025-01-09 21:03 UTC (permalink / raw)
To: Armin Wolf, pali; +Cc: jdelvare, linux, linux-hwmon, linux-kernel
On 2024-12-07 23:26, Armin Wolf wrote:
> Am 07.12.24 um 21:26 schrieb Povilas Kanapickas:
>
>> Add the Dell XPS 9370 to the fan control whitelist to allow
>> for manual fan control.
>
> Can you check if using i8k_fan_control_data[I8K_FAN_30A3_31A3] also works?
>
> The reason for this is that the official Dell software seems to use
> those SMM calls
> to enable/disable automatic fan control. If this does not work then you
> can keep
> the i8k_fan_control_data[I8K_FAN_34A3_35A3].
Sorry for taking this long to test. I can confirm I8K_FAN_30A3_31A3
works. I will submit a new patch.
Thanks,
Povilas
> Thanks,
> Armin Wolf
>
>> Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
>> ---
>> drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-
>> hwmon.c
>> index f5bdf842040e..bcb295ea3319 100644
>> --- a/drivers/hwmon/dell-smm-hwmon.c
>> +++ b/drivers/hwmon/dell-smm-hwmon.c
>> @@ -1544,6 +1544,14 @@ static const struct dmi_system_id
>> i8k_whitelist_fan_control[] __initconst = {
>> },
>> .driver_data = (void
>> *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
>> },
>> + {
>> + .ident = "Dell XPS 13 9370",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9370"),
>> + },
>> + .driver_data = (void
>> *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
>> + },
>> {
>> .ident = "Dell Optiplex 7000",
>> .matches = {
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-09 21:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-07 20:26 [PATCH] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist Povilas Kanapickas
2024-12-07 21:26 ` Armin Wolf
2025-01-09 21:03 ` Povilas Kanapickas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox