From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dawei Liu <dawei.liu.jy@renesas.com>
Cc: "linux@roeck-us.net" <linux@roeck-us.net>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
"geert+renesas@glider.be" <geert+renesas@glider.be>,
"magnus.damm" <magnus.damm@gmail.com>,
Grant Peltier <grant.peltier.jg@renesas.com>
Subject: Re: [PATCH 2/2] dt-bindings: hwmon: isl68137: Add compatible string for RAA228942 and RAA228943
Date: Wed, 18 Mar 2026 19:35:10 +0100 [thread overview]
Message-ID: <f02d5bbb-3f26-4ad5-a4d7-e3b34e20ed32@kernel.org> (raw)
In-Reply-To: <OS7PR01MB11926C7139DE648454D744DA2D540A@OS7PR01MB11926.jpnprd01.prod.outlook.com>
On 16/03/2026 10:00, Dawei Liu wrote:
> Hi Krzysztof,
>
> Thank you for the review.
>
> The RAA228942/228943 are register-compatible with RAA228228/244/246
> family, using the same PMBus command set and the raa_dmpvr2_2rail_nontc
> driver configuration (2-rail without TEMP3 sensor).
>
> In the driver code, they reuse the existing device configuration, so no
> special handling is needed. That's why they're added to the enum list in
> the binding.
>
> I will send v2 with improved commit messages to clarify this.
Please respond inline, instead of top-posting, because it makes your
emails hard to follow.
https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-18 18:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 5:35 [PATCH 1/2] hwmon/pmbus: (isl68137) Add support for Renesas RAA228942 and RAA228943 Dawei Liu
2026-03-16 5:35 ` [PATCH 2/2] dt-bindings: hwmon: isl68137: Add compatible string for " Dawei Liu
2026-03-16 8:25 ` Krzysztof Kozlowski
2026-03-16 9:00 ` Dawei Liu
2026-03-18 8:24 ` Krzysztof Kozlowski
2026-03-18 18:35 ` Krzysztof Kozlowski [this message]
2026-03-16 15:47 ` [PATCH 1/2] hwmon/pmbus: (isl68137) Add support for Renesas " Guenter Roeck
2026-03-17 2:50 ` Dawei Liu
2026-03-17 3:52 ` Guenter Roeck
2026-03-18 2:19 ` [PATCH v2 0/3] hwmon/pmbus: isl68137: Add RAA228942/RAA228943 support Dawei Liu
2026-03-18 2:19 ` [PATCH v2 1/3] hwmon: (pmbus/isl68137) Remove unused enum chips Dawei Liu
2026-03-18 4:48 ` Guenter Roeck
2026-03-18 2:19 ` [PATCH v2 2/3] hwmon: (pmbus/isl68137) Add support for Renesas RAA228942 and RAA228943 Dawei Liu
2026-03-18 5:23 ` Guenter Roeck
2026-03-18 8:25 ` Krzysztof Kozlowski
2026-03-18 17:49 ` Guenter Roeck
2026-03-18 2:19 ` [PATCH v2 3/3] dt-bindings: hwmon: isl68137: Add compatible strings for " Dawei Liu
2026-03-18 5:43 ` Dawei Liu
2026-03-18 8:23 ` Krzysztof Kozlowski
2026-03-19 2:05 ` Dawei Liu
2026-03-21 20:46 ` Krzysztof Kozlowski
2026-03-23 4:22 ` Dawei Liu
2026-03-23 7:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f02d5bbb-3f26-4ad5-a4d7-e3b34e20ed32@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=dawei.liu.jy@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=grant.peltier.jg@renesas.com \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=magnus.damm@gmail.com \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox