[PATCH 1/2] hwmon/pmbus: (isl68137) Add support for Renesas RAA228942 and RAA228943

[PATCH 1/2] hwmon/pmbus: (isl68137) Add support for Renesas RAA228942 and RAA228943

[Dawei Liu]

Both RAA228942 and RAA228943 are digital dual-output
16-Phase(X+Y ≤ 16) PWM controllers

Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>
---
 Documentation/hwmon/isl68137.rst | 20 ++++++++++++++++++++
 drivers/hwmon/pmbus/isl68137.c   |  6 ++++++
 2 files changed, 26 insertions(+)

diff --git a/Documentation/hwmon/isl68137.rst b/Documentation/hwmon/isl68137.rst
index e77f582c2..0ce20d091 100644
--- a/Documentation/hwmon/isl68137.rst
+++ b/Documentation/hwmon/isl68137.rst
@@ -394,6 +394,26 @@ Supported chips:
 
       Provided by Renesas upon request and NDA
 
+  * Renesas RAA228942
+
+    Prefix: 'raa228942'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Provided by Renesas upon request and NDA
+
+  * Renesas RAA228943
+
+    Prefix: 'raa228943'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Provided by Renesas upon request and NDA
+
   * Renesas RAA229001
 
     Prefix: 'raa229001'
diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
index 78cff9712..da2484d42 100644
--- a/drivers/hwmon/pmbus/isl68137.c
+++ b/drivers/hwmon/pmbus/isl68137.c
@@ -63,6 +63,8 @@ enum chips {
 	raa228228,
 	raa228244,
 	raa228246,
+	raa228942,
+	raa228943,
 	raa229001,
 	raa229004,
 	raa229141,
@@ -478,6 +480,8 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
 	{"raa228228", raa_dmpvr2_2rail_nontc},
 	{"raa228244", raa_dmpvr2_2rail_nontc},
 	{"raa228246", raa_dmpvr2_2rail_nontc},
+	{"raa228942", raa_dmpvr2_2rail_nontc},
+	{"raa228943", raa_dmpvr2_2rail_nontc},
 	{"raa229001", raa_dmpvr2_2rail},
 	{"raa229004", raa_dmpvr2_2rail},
 	{"raa229141", raa_dmpvr2_2rail_pmbus},
@@ -529,6 +533,8 @@ static const struct of_device_id isl68137_of_match[] = {
 	{ .compatible = "renesas,raa228228", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa228244", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa228246", .data = (void *)raa_dmpvr2_2rail_nontc },
+	{ .compatible = "renesas,raa228942", .data = (void *)raa_dmpvr2_2rail_nontc },
+	{ .compatible = "renesas,raa228943", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa229001", .data = (void *)raa_dmpvr2_2rail },
 	{ .compatible = "renesas,raa229004", .data = (void *)raa_dmpvr2_2rail },
 	{ .compatible = "renesas,raa229621", .data = (void *)raa_dmpvr2_2rail },
-- 
2.34.1

[PATCH 2/2] dt-bindings: hwmon: isl68137: Add compatible string for RAA228942 and RAA228943

[Dawei Liu]

Add compatible strings for the Renesas RAA228942 and RAA228943
digital dual-output 16-Phase PWM controllers.

Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>
---
 .../devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml          | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
index ae23a0537..53d07c0ce 100644
--- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
@@ -56,6 +56,8 @@ properties:
       - renesas,raa228228
       - renesas,raa228244
       - renesas,raa228246
+      - renesas,raa228942
+      - renesas,raa228943
       - renesas,raa229001
       - renesas,raa229004
       - renesas,raa229621
-- 
2.34.1

Re: [PATCH 2/2] dt-bindings: hwmon: isl68137: Add compatible string for RAA228942 and RAA228943

[Krzysztof Kozlowski]

On Mon, Mar 16, 2026 at 01:35:41PM +0800, Dawei Liu wrote:
> Add compatible strings for the Renesas RAA228942 and RAA228943
> digital dual-output 16-Phase PWM controllers.
> 
> Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>

Please read submitting patches in bindings and process directories.

> ---
>  .../devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml          | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> index ae23a0537..53d07c0ce 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> @@ -56,6 +56,8 @@ properties:
>        - renesas,raa228228
>        - renesas,raa228244
>        - renesas,raa228246
> +      - renesas,raa228942
> +      - renesas,raa228943

So are they compatible or they are not compatible with anything else,
like driver suggests? That's what commit msg is for as well.

Best regards,
Krzysztof

RE: [PATCH 2/2] dt-bindings: hwmon: isl68137: Add compatible string for RAA228942 and RAA228943

[Dawei Liu]

Hi Krzysztof,

Thank you for the review.

The RAA228942/228943 are register-compatible with RAA228228/244/246
family, using the same PMBus command set and the raa_dmpvr2_2rail_nontc 
driver configuration (2-rail without TEMP3 sensor). 

In the driver code, they reuse the existing device configuration, so no 
special handling is needed. That's why they're added to the enum list in 
the binding.

I will send v2 with improved commit messages to clarify this.


Best Regards
Dawei Liu

-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org> 
Sent: Monday, March 16, 2026 4:26 PM
To: Dawei Liu <dawei.liu.jy@renesas.com>
Cc: linux@roeck-us.net; linux-hwmon@vger.kernel.org; linux-kernel@vger.kernel.org; linux-doc@vger.kernel.org; devicetree@vger.kernel.org; linux-renesas-soc@vger.kernel.org; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; corbet@lwn.net; skhan@linuxfoundation.org; geert+renesas@glider.be; magnus.damm <magnus.damm@gmail.com>; Grant Peltier <grant.peltier.jg@renesas.com>
Subject: Re: [PATCH 2/2] dt-bindings: hwmon: isl68137: Add compatible string for RAA228942 and RAA228943

[Some people who received this message don't often get email from krzk@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

On Mon, Mar 16, 2026 at 01:35:41PM +0800, Dawei Liu wrote:
> Add compatible strings for the Renesas RAA228942 and RAA228943 digital 
> dual-output 16-Phase PWM controllers.
>
> Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>

Please read submitting patches in bindings and process directories.

> ---
>  .../devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml          | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git 
> a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml 
> b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> index ae23a0537..53d07c0ce 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> @@ -56,6 +56,8 @@ properties:
>        - renesas,raa228228
>        - renesas,raa228244
>        - renesas,raa228246
> +      - renesas,raa228942
> +      - renesas,raa228943

So are they compatible or they are not compatible with anything else, like driver suggests? That's what commit msg is for as well.

Best regards,
Krzysztof

Re: [PATCH 2/2] dt-bindings: hwmon: isl68137: Add compatible string for RAA228942 and RAA228943

[Krzysztof Kozlowski]

On Mon, Mar 16, 2026 at 09:00:24AM +0000, Dawei Liu wrote:
> Hi Krzysztof,
> 
> Thank you for the review.
> 
> The RAA228942/228943 are register-compatible with RAA228228/244/246
> family, using the same PMBus command set and the raa_dmpvr2_2rail_nontc 
> driver configuration (2-rail without TEMP3 sensor). 
> 
> In the driver code, they reuse the existing device configuration, so no 
> special handling is needed. That's why they're added to the enum list in 
> the binding.
> 
> I will send v2 with improved commit messages to clarify this.

Read netiquete about top posting.

Best regards,
Krzysztof

Re: [PATCH 2/2] dt-bindings: hwmon: isl68137: Add compatible string for RAA228942 and RAA228943

[Krzysztof Kozlowski]

On 16/03/2026 10:00, Dawei Liu wrote:
> Hi Krzysztof,
> 
> Thank you for the review.
> 
> The RAA228942/228943 are register-compatible with RAA228228/244/246
> family, using the same PMBus command set and the raa_dmpvr2_2rail_nontc 
> driver configuration (2-rail without TEMP3 sensor). 
> 
> In the driver code, they reuse the existing device configuration, so no 
> special handling is needed. That's why they're added to the enum list in 
> the binding.
> 
> I will send v2 with improved commit messages to clarify this.


Please respond inline, instead of top-posting, because it makes your
emails hard to follow.
https://elixir.bootlin.com/linux/v6.8-rc7/source/Documentation/process/submitting-patches.rst#L340

Best regards,
Krzysztof

Re: [PATCH 1/2] hwmon/pmbus: (isl68137) Add support for Renesas RAA228942 and RAA228943

[Guenter Roeck]

On Mon, Mar 16, 2026 at 01:35:40PM +0800, Dawei Liu wrote:
> Both RAA228942 and RAA228943 are digital dual-output
> 16-Phase(X+Y ≤ 16) PWM controllers
> 
> Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>
> ---
>  Documentation/hwmon/isl68137.rst | 20 ++++++++++++++++++++
>  drivers/hwmon/pmbus/isl68137.c   |  6 ++++++
>  2 files changed, 26 insertions(+)
> 
> diff --git a/Documentation/hwmon/isl68137.rst b/Documentation/hwmon/isl68137.rst
> index e77f582c2..0ce20d091 100644
> --- a/Documentation/hwmon/isl68137.rst
> +++ b/Documentation/hwmon/isl68137.rst
> @@ -394,6 +394,26 @@ Supported chips:
>  
>        Provided by Renesas upon request and NDA
>  
> +  * Renesas RAA228942
> +
> +    Prefix: 'raa228942'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Provided by Renesas upon request and NDA
> +
> +  * Renesas RAA228943
> +
> +    Prefix: 'raa228943'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Provided by Renesas upon request and NDA
> +
>    * Renesas RAA229001
>  
>      Prefix: 'raa229001'
> diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
> index 78cff9712..da2484d42 100644
> --- a/drivers/hwmon/pmbus/isl68137.c
> +++ b/drivers/hwmon/pmbus/isl68137.c
> @@ -63,6 +63,8 @@ enum chips {
>  	raa228228,
>  	raa228244,
>  	raa228246,
> +	raa228942,
> +	raa228943,

AI:

  Is it necessary to add these entries to enum chips?
  Looking at the rest of the driver, this enum does not appear to be used
  anywhere. The device data mapping seems to rely on the variants enum
  (e.g., raa_dmpvr2_2rail_nontc) instead.

It has a point. 

Guenter

>  	raa229001,
>  	raa229004,
>  	raa229141,
> @@ -478,6 +480,8 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
>  	{"raa228228", raa_dmpvr2_2rail_nontc},
>  	{"raa228244", raa_dmpvr2_2rail_nontc},
>  	{"raa228246", raa_dmpvr2_2rail_nontc},
> +	{"raa228942", raa_dmpvr2_2rail_nontc},
> +	{"raa228943", raa_dmpvr2_2rail_nontc},
>  	{"raa229001", raa_dmpvr2_2rail},
>  	{"raa229004", raa_dmpvr2_2rail},
>  	{"raa229141", raa_dmpvr2_2rail_pmbus},
> @@ -529,6 +533,8 @@ static const struct of_device_id isl68137_of_match[] = {
>  	{ .compatible = "renesas,raa228228", .data = (void *)raa_dmpvr2_2rail_nontc },
>  	{ .compatible = "renesas,raa228244", .data = (void *)raa_dmpvr2_2rail_nontc },
>  	{ .compatible = "renesas,raa228246", .data = (void *)raa_dmpvr2_2rail_nontc },
> +	{ .compatible = "renesas,raa228942", .data = (void *)raa_dmpvr2_2rail_nontc },
> +	{ .compatible = "renesas,raa228943", .data = (void *)raa_dmpvr2_2rail_nontc },
>  	{ .compatible = "renesas,raa229001", .data = (void *)raa_dmpvr2_2rail },
>  	{ .compatible = "renesas,raa229004", .data = (void *)raa_dmpvr2_2rail },
>  	{ .compatible = "renesas,raa229621", .data = (void *)raa_dmpvr2_2rail },

RE: [PATCH 1/2] hwmon/pmbus: (isl68137) Add support for Renesas RAA228942 and RAA228943

[Dawei Liu]

Hi Guenter,

I understand that enum chips is not used in the device matching
logic. However, it provides a clear, centralized list of all
supported chip models for developers and users reviewing the code.

I added entries there to maintain consistency with recent commits
that had been accepted. For example:
- 71a117d28f87 "hwmon: (pmbus/isl68137) Add support for RAA229141"
- 2190ad55a601 "hwmon: (pmbus/isl68137) add support for Renesas
  RAA228244 and RAA228246"

Both commits follow the same pattern of adding to enum chips.
I think keeping these entries in enum chips maintains code
consistency and documentation value. However, if you prefer
not to add them there, I'm happy to adjust in v2.

Best regards,
Dawei Liu

-----Original Message-----
From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
Sent: Monday, March 16, 2026 11:48 PM
To: Dawei Liu <dawei.liu.jy@renesas.com>
Cc: linux-hwmon@vger.kernel.org; linux-kernel@vger.kernel.org; linux-doc@vger.kernel.org; devicetree@vger.kernel.org; linux-renesas-soc@vger.kernel.org; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; corbet@lwn.net; skhan@linuxfoundation.org; geert+renesas@glider.be; magnus.damm <magnus.damm@gmail.com>; Grant Peltier <grant.peltier.jg@renesas.com>
Subject: Re: [PATCH 1/2] hwmon/pmbus: (isl68137) Add support for Renesas RAA228942 and RAA228943

On Mon, Mar 16, 2026 at 01:35:40PM +0800, Dawei Liu wrote:
> Both RAA228942 and RAA228943 are digital dual-output 16-Phase(X+Y ≤ 
> 16) PWM controllers
> 
> Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>
> ---
>  Documentation/hwmon/isl68137.rst | 20 ++++++++++++++++++++
>  drivers/hwmon/pmbus/isl68137.c   |  6 ++++++
>  2 files changed, 26 insertions(+)
> 
> diff --git a/Documentation/hwmon/isl68137.rst 
> b/Documentation/hwmon/isl68137.rst
> index e77f582c2..0ce20d091 100644
> --- a/Documentation/hwmon/isl68137.rst
> +++ b/Documentation/hwmon/isl68137.rst
> @@ -394,6 +394,26 @@ Supported chips:
>  
>        Provided by Renesas upon request and NDA
>  
> +  * Renesas RAA228942
> +
> +    Prefix: 'raa228942'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Provided by Renesas upon request and NDA
> +
> +  * Renesas RAA228943
> +
> +    Prefix: 'raa228943'
> +
> +    Addresses scanned: -
> +
> +    Datasheet:
> +
> +      Provided by Renesas upon request and NDA
> +
>    * Renesas RAA229001
>  
>      Prefix: 'raa229001'
> diff --git a/drivers/hwmon/pmbus/isl68137.c 
> b/drivers/hwmon/pmbus/isl68137.c index 78cff9712..da2484d42 100644
> --- a/drivers/hwmon/pmbus/isl68137.c
> +++ b/drivers/hwmon/pmbus/isl68137.c
> @@ -63,6 +63,8 @@ enum chips {
>  	raa228228,
>  	raa228244,
>  	raa228246,
> +	raa228942,
> +	raa228943,

AI:

  Is it necessary to add these entries to enum chips?
  Looking at the rest of the driver, this enum does not appear to be used
  anywhere. The device data mapping seems to rely on the variants enum
  (e.g., raa_dmpvr2_2rail_nontc) instead.

It has a point. 

Guenter

>  	raa229001,
>  	raa229004,
>  	raa229141,
> @@ -478,6 +480,8 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
>  	{"raa228228", raa_dmpvr2_2rail_nontc},
>  	{"raa228244", raa_dmpvr2_2rail_nontc},
>  	{"raa228246", raa_dmpvr2_2rail_nontc},
> +	{"raa228942", raa_dmpvr2_2rail_nontc},
> +	{"raa228943", raa_dmpvr2_2rail_nontc},
>  	{"raa229001", raa_dmpvr2_2rail},
>  	{"raa229004", raa_dmpvr2_2rail},
>  	{"raa229141", raa_dmpvr2_2rail_pmbus}, @@ -529,6 +533,8 @@ static 
> const struct of_device_id isl68137_of_match[] = {
>  	{ .compatible = "renesas,raa228228", .data = (void *)raa_dmpvr2_2rail_nontc },
>  	{ .compatible = "renesas,raa228244", .data = (void *)raa_dmpvr2_2rail_nontc },
>  	{ .compatible = "renesas,raa228246", .data = (void 
> *)raa_dmpvr2_2rail_nontc },
> +	{ .compatible = "renesas,raa228942", .data = (void *)raa_dmpvr2_2rail_nontc },
> +	{ .compatible = "renesas,raa228943", .data = (void 
> +*)raa_dmpvr2_2rail_nontc },
>  	{ .compatible = "renesas,raa229001", .data = (void *)raa_dmpvr2_2rail },
>  	{ .compatible = "renesas,raa229004", .data = (void *)raa_dmpvr2_2rail },
>  	{ .compatible = "renesas,raa229621", .data = (void 
> *)raa_dmpvr2_2rail },

Re: [PATCH 1/2] hwmon/pmbus: (isl68137) Add support for Renesas RAA228942 and RAA228943

[Guenter Roeck]

On 3/16/26 19:50, Dawei Liu wrote:
> Hi Guenter,
> 
> I understand that enum chips is not used in the device matching
> logic. However, it provides a clear, centralized list of all
> supported chip models for developers and users reviewing the code.
> 
> I added entries there to maintain consistency with recent commits
> that had been accepted. For example:
> - 71a117d28f87 "hwmon: (pmbus/isl68137) Add support for RAA229141"
> - 2190ad55a601 "hwmon: (pmbus/isl68137) add support for Renesas
>    RAA228244 and RAA228246"
> 
> Both commits follow the same pattern of adding to enum chips.
> I think keeping these entries in enum chips maintains code
> consistency and documentation value. However, if you prefer
> not to add them there, I'm happy to adjust in v2.
> 

What you are saying is that I did not notice the problem when reviewing the
previous patches, and that it should be ok to continue the wrong pattern
because of that. Sorry, that is not how things work.

What should be done is to drop the unnecessary enum values, not to add new ones.

Guenter

> Best regards,
> Dawei Liu
> 
> -----Original Message-----
> From: Guenter Roeck <groeck7@gmail.com> On Behalf Of Guenter Roeck
> Sent: Monday, March 16, 2026 11:48 PM
> To: Dawei Liu <dawei.liu.jy@renesas.com>
> Cc: linux-hwmon@vger.kernel.org; linux-kernel@vger.kernel.org; linux-doc@vger.kernel.org; devicetree@vger.kernel.org; linux-renesas-soc@vger.kernel.org; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; corbet@lwn.net; skhan@linuxfoundation.org; geert+renesas@glider.be; magnus.damm <magnus.damm@gmail.com>; Grant Peltier <grant.peltier.jg@renesas.com>
> Subject: Re: [PATCH 1/2] hwmon/pmbus: (isl68137) Add support for Renesas RAA228942 and RAA228943
> 
> On Mon, Mar 16, 2026 at 01:35:40PM +0800, Dawei Liu wrote:
>> Both RAA228942 and RAA228943 are digital dual-output 16-Phase(X+Y ≤
>> 16) PWM controllers
>>
>> Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>
>> ---
>>   Documentation/hwmon/isl68137.rst | 20 ++++++++++++++++++++
>>   drivers/hwmon/pmbus/isl68137.c   |  6 ++++++
>>   2 files changed, 26 insertions(+)
>>
>> diff --git a/Documentation/hwmon/isl68137.rst
>> b/Documentation/hwmon/isl68137.rst
>> index e77f582c2..0ce20d091 100644
>> --- a/Documentation/hwmon/isl68137.rst
>> +++ b/Documentation/hwmon/isl68137.rst
>> @@ -394,6 +394,26 @@ Supported chips:
>>   
>>         Provided by Renesas upon request and NDA
>>   
>> +  * Renesas RAA228942
>> +
>> +    Prefix: 'raa228942'
>> +
>> +    Addresses scanned: -
>> +
>> +    Datasheet:
>> +
>> +      Provided by Renesas upon request and NDA
>> +
>> +  * Renesas RAA228943
>> +
>> +    Prefix: 'raa228943'
>> +
>> +    Addresses scanned: -
>> +
>> +    Datasheet:
>> +
>> +      Provided by Renesas upon request and NDA
>> +
>>     * Renesas RAA229001
>>   
>>       Prefix: 'raa229001'
>> diff --git a/drivers/hwmon/pmbus/isl68137.c
>> b/drivers/hwmon/pmbus/isl68137.c index 78cff9712..da2484d42 100644
>> --- a/drivers/hwmon/pmbus/isl68137.c
>> +++ b/drivers/hwmon/pmbus/isl68137.c
>> @@ -63,6 +63,8 @@ enum chips {
>>   	raa228228,
>>   	raa228244,
>>   	raa228246,
>> +	raa228942,
>> +	raa228943,
> 
> AI:
> 
>    Is it necessary to add these entries to enum chips?
>    Looking at the rest of the driver, this enum does not appear to be used
>    anywhere. The device data mapping seems to rely on the variants enum
>    (e.g., raa_dmpvr2_2rail_nontc) instead.
> 
> It has a point.
> 
> Guenter
> 
>>   	raa229001,
>>   	raa229004,
>>   	raa229141,
>> @@ -478,6 +480,8 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
>>   	{"raa228228", raa_dmpvr2_2rail_nontc},
>>   	{"raa228244", raa_dmpvr2_2rail_nontc},
>>   	{"raa228246", raa_dmpvr2_2rail_nontc},
>> +	{"raa228942", raa_dmpvr2_2rail_nontc},
>> +	{"raa228943", raa_dmpvr2_2rail_nontc},
>>   	{"raa229001", raa_dmpvr2_2rail},
>>   	{"raa229004", raa_dmpvr2_2rail},
>>   	{"raa229141", raa_dmpvr2_2rail_pmbus}, @@ -529,6 +533,8 @@ static
>> const struct of_device_id isl68137_of_match[] = {
>>   	{ .compatible = "renesas,raa228228", .data = (void *)raa_dmpvr2_2rail_nontc },
>>   	{ .compatible = "renesas,raa228244", .data = (void *)raa_dmpvr2_2rail_nontc },
>>   	{ .compatible = "renesas,raa228246", .data = (void
>> *)raa_dmpvr2_2rail_nontc },
>> +	{ .compatible = "renesas,raa228942", .data = (void *)raa_dmpvr2_2rail_nontc },
>> +	{ .compatible = "renesas,raa228943", .data = (void
>> +*)raa_dmpvr2_2rail_nontc },
>>   	{ .compatible = "renesas,raa229001", .data = (void *)raa_dmpvr2_2rail },
>>   	{ .compatible = "renesas,raa229004", .data = (void *)raa_dmpvr2_2rail },
>>   	{ .compatible = "renesas,raa229621", .data = (void
>> *)raa_dmpvr2_2rail },

[PATCH v2 0/3] hwmon/pmbus: isl68137: Add RAA228942/RAA228943 support

[Dawei Liu]

Add support for Renesas RAA228942 and RAA228943 digital dual-output
16-Phase PWM controllers. Also clean up the unused enum chips.

Changes in v2:
  - Remove entire unused enum chips (suggested by Guenter Roeck)
  - Improve commit message to clarify PMBus command compatibility
    (suggested by Krzysztof Kozlowski)
  - Split enum chips cleanup into separate patch

Dawei Liu (3):
  hwmon: (pmbus/isl68137) Remove unused enum chips
  hwmon: (pmbus/isl68137) Add support for Renesas RAA228942 and
    RAA228943
  dt-bindings: hwmon: isl68137: Add compatible strings for RAA228942 and
    RAA228943

 .../bindings/hwmon/pmbus/isil,isl68137.yaml   |  2 +
 Documentation/hwmon/isl68137.rst              | 20 ++++++++
 drivers/hwmon/pmbus/isl68137.c                | 50 ++-----------------
 3 files changed, 26 insertions(+), 46 deletions(-)

-- 
2.34.1

[PATCH v2 1/3] hwmon: (pmbus/isl68137) Remove unused enum chips

[Dawei Liu]

The enum chips is not used anywhere in the driver. Device matching
relies on the variants enum instead. Remove it to clean up the code.

Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>
---
 drivers/hwmon/pmbus/isl68137.c | 46 ----------------------------------
 1 file changed, 46 deletions(-)

diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
index 78cff9712..3346afdf3 100644
--- a/drivers/hwmon/pmbus/isl68137.c
+++ b/drivers/hwmon/pmbus/isl68137.c
@@ -23,52 +23,6 @@
 #define RAA_DMPVR2_READ_VMON	0xc8
 #define MAX_CHANNELS            4
 
-enum chips {
-	isl68137,
-	isl68220,
-	isl68221,
-	isl68222,
-	isl68223,
-	isl68224,
-	isl68225,
-	isl68226,
-	isl68227,
-	isl68229,
-	isl68233,
-	isl68239,
-	isl69222,
-	isl69223,
-	isl69224,
-	isl69225,
-	isl69227,
-	isl69228,
-	isl69234,
-	isl69236,
-	isl69239,
-	isl69242,
-	isl69243,
-	isl69247,
-	isl69248,
-	isl69254,
-	isl69255,
-	isl69256,
-	isl69259,
-	isl69260,
-	isl69268,
-	isl69269,
-	isl69298,
-	raa228000,
-	raa228004,
-	raa228006,
-	raa228228,
-	raa228244,
-	raa228246,
-	raa229001,
-	raa229004,
-	raa229141,
-	raa229621,
-};
-
 enum variants {
 	raa_dmpvr1_2rail,
 	raa_dmpvr2_1rail,
-- 
2.34.1

Re: [PATCH v2 1/3] hwmon: (pmbus/isl68137) Remove unused enum chips

[Guenter Roeck]

On Wed, Mar 18, 2026 at 10:19:19AM +0800, Dawei Liu wrote:
> The enum chips is not used anywhere in the driver. Device matching
> relies on the variants enum instead. Remove it to clean up the code.
> 
> Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>

Applied.

Thanks,
Guenter

[PATCH v2 2/3] hwmon: (pmbus/isl68137) Add support for Renesas RAA228942 and RAA228943

[Dawei Liu]

Both RAA228942 and RAA228943 are digital dual-output 16-Phase
(X+Y <= 16) PWM controllers. They are PMBus command compatible
with the RAA228228/RAA228244/RAA228246 family and use the same
2-rail non-TC driver configuration.

Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>
---
 Documentation/hwmon/isl68137.rst | 20 ++++++++++++++++++++
 drivers/hwmon/pmbus/isl68137.c   |  4 ++++
 2 files changed, 24 insertions(+)

diff --git a/Documentation/hwmon/isl68137.rst b/Documentation/hwmon/isl68137.rst
index e77f582c2..0ce20d091 100644
--- a/Documentation/hwmon/isl68137.rst
+++ b/Documentation/hwmon/isl68137.rst
@@ -394,6 +394,26 @@ Supported chips:
 
       Provided by Renesas upon request and NDA
 
+  * Renesas RAA228942
+
+    Prefix: 'raa228942'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Provided by Renesas upon request and NDA
+
+  * Renesas RAA228943
+
+    Prefix: 'raa228943'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Provided by Renesas upon request and NDA
+
   * Renesas RAA229001
 
     Prefix: 'raa229001'
diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
index 3346afdf3..e9bb24a2a 100644
--- a/drivers/hwmon/pmbus/isl68137.c
+++ b/drivers/hwmon/pmbus/isl68137.c
@@ -432,6 +432,8 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
 	{"raa228228", raa_dmpvr2_2rail_nontc},
 	{"raa228244", raa_dmpvr2_2rail_nontc},
 	{"raa228246", raa_dmpvr2_2rail_nontc},
+	{"raa228942", raa_dmpvr2_2rail_nontc},
+	{"raa228943", raa_dmpvr2_2rail_nontc},
 	{"raa229001", raa_dmpvr2_2rail},
 	{"raa229004", raa_dmpvr2_2rail},
 	{"raa229141", raa_dmpvr2_2rail_pmbus},
@@ -483,6 +485,8 @@ static const struct of_device_id isl68137_of_match[] = {
 	{ .compatible = "renesas,raa228228", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa228244", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa228246", .data = (void *)raa_dmpvr2_2rail_nontc },
+	{ .compatible = "renesas,raa228942", .data = (void *)raa_dmpvr2_2rail_nontc },
+	{ .compatible = "renesas,raa228943", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa229001", .data = (void *)raa_dmpvr2_2rail },
 	{ .compatible = "renesas,raa229004", .data = (void *)raa_dmpvr2_2rail },
 	{ .compatible = "renesas,raa229621", .data = (void *)raa_dmpvr2_2rail },
-- 
2.34.1

Re: [PATCH v2 2/3] hwmon: (pmbus/isl68137) Add support for Renesas RAA228942 and RAA228943

[Guenter Roeck]

On 3/17/26 19:19, Dawei Liu wrote:
> Both RAA228942 and RAA228943 are digital dual-output 16-Phase
> (X+Y <= 16) PWM controllers. They are PMBus command compatible
> with the RAA228228/RAA228244/RAA228246 family and use the same
> 2-rail non-TC driver configuration.
> 
> Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>

For my reference:

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Note that technically the devicetree patch should come first,
and I can not apply this and the next patch because you dropped
Krzysztof's Acked-by: tag from that patch.

Guenter

Re: [PATCH v2 2/3] hwmon: (pmbus/isl68137) Add support for Renesas RAA228942 and RAA228943

[Krzysztof Kozlowski]

On Tue, Mar 17, 2026 at 10:23:57PM -0700, Guenter Roeck wrote:
> On 3/17/26 19:19, Dawei Liu wrote:
> > Both RAA228942 and RAA228943 are digital dual-output 16-Phase
> > (X+Y <= 16) PWM controllers. They are PMBus command compatible
> > with the RAA228228/RAA228244/RAA228246 family and use the same
> > 2-rail non-TC driver configuration.
> > 
> > Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>
> 
> For my reference:
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> Note that technically the devicetree patch should come first,
> and I can not apply this and the next patch because you dropped
> Krzysztof's Acked-by: tag from that patch.

Was there an Ack? I see only one reply from me, but maybe something is
lost because entire posting is completely mixed up (v2 being part of v1)
so it all appears mixed in my inbox.

Best regards,
Krzysztof

Re: [PATCH v2 2/3] hwmon: (pmbus/isl68137) Add support for Renesas RAA228942 and RAA228943

[Guenter Roeck]

On 3/18/26 01:25, Krzysztof Kozlowski wrote:
> On Tue, Mar 17, 2026 at 10:23:57PM -0700, Guenter Roeck wrote:
>> On 3/17/26 19:19, Dawei Liu wrote:
>>> Both RAA228942 and RAA228943 are digital dual-output 16-Phase
>>> (X+Y <= 16) PWM controllers. They are PMBus command compatible
>>> with the RAA228228/RAA228244/RAA228246 family and use the same
>>> 2-rail non-TC driver configuration.
>>>
>>> Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>
>>
>> For my reference:
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>
>> Note that technically the devicetree patch should come first,
>> and I can not apply this and the next patch because you dropped
>> Krzysztof's Acked-by: tag from that patch.
> 
> Was there an Ack? I see only one reply from me, but maybe something is
> lost because entire posting is completely mixed up (v2 being part of v1)
> so it all appears mixed in my inbox.
> 

My sincere apologies. No, there wasn't. Not a good excuse, but I got confused
with another submission.

Sorry for that.

Guenter

[PATCH v2 3/3] dt-bindings: hwmon: isl68137: Add compatible strings for RAA228942 and RAA228943

[Dawei Liu]

RAA228942 and RAA228943 are Renesas digital dual-output 16-Phase
(X+Y <= 16) PWM controllers. They are PMBus command compatible
with the RAA228228/RAA228244/RAA228246 family and use the same
2-rail non-TC driver configuration.

Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>
---
 .../devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml          | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
index ae23a0537..53d07c0ce 100644
--- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
@@ -56,6 +56,8 @@ properties:
       - renesas,raa228228
       - renesas,raa228244
       - renesas,raa228246
+      - renesas,raa228942
+      - renesas,raa228943
       - renesas,raa229001
       - renesas,raa229004
       - renesas,raa229621
-- 
2.34.1

RE: [PATCH v2 3/3] dt-bindings: hwmon: isl68137: Add compatible strings for RAA228942 and RAA228943

[Dawei Liu]

Hi Krzysztof,

I've updated the commit message in v2 to clarify the compatibility,
as you suggested in your v1 review. The commit message now reads:

  "Both RAA228942 and RAA228943 are PMBus command compatible with the
   RAA228228/RAA228244/RAA228246 family and use the same 2-rail non-TC
   driver configuration."

Could you please review this v2 dt-bindings patch and provide your
Acked-by if it looks good to you?

Best Regards
Dawei Liu

-----Original Message-----
From: Dawei Liu 
Sent: Wednesday, March 18, 2026 10:20 AM
To: linux@roeck-us.net
Cc: linux-hwmon@vger.kernel.org; linux-kernel@vger.kernel.org; linux-doc@vger.kernel.org; devicetree@vger.kernel.org; linux-renesas-soc@vger.kernel.org; robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; corbet@lwn.net; skhan@linuxfoundation.org; geert+renesas@glider.be; magnus.damm <magnus.damm@gmail.com>; Grant Peltier <grant.peltier.jg@renesas.com>; Linda Xin <linda.xin.jg@renesas.com>; tabreztalks@gmail.com; Dawei Liu <dawei.liu.jy@renesas.com>
Subject: [PATCH v2 3/3] dt-bindings: hwmon: isl68137: Add compatible strings for RAA228942 and RAA228943

RAA228942 and RAA228943 are Renesas digital dual-output 16-Phase (X+Y <= 16) PWM controllers. They are PMBus command compatible with the RAA228228/RAA228244/RAA228246 family and use the same 2-rail non-TC driver configuration.

Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>
---
 .../devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml          | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
index ae23a0537..53d07c0ce 100644
--- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
@@ -56,6 +56,8 @@ properties:
       - renesas,raa228228
       - renesas,raa228244
       - renesas,raa228246
+      - renesas,raa228942
+      - renesas,raa228943
       - renesas,raa229001
       - renesas,raa229004
       - renesas,raa229621
--
2.34.1

Re: [PATCH v2 3/3] dt-bindings: hwmon: isl68137: Add compatible strings for RAA228942 and RAA228943

[Krzysztof Kozlowski]

On Wed, Mar 18, 2026 at 05:43:00AM +0000, Dawei Liu wrote:
> Hi Krzysztof,
> 
> I've updated the commit message in v2 to clarify the compatibility,
> as you suggested in your v1 review. The commit message now reads:
> 
>   "Both RAA228942 and RAA228943 are PMBus command compatible with the
>    RAA228228/RAA228244/RAA228246 family and use the same 2-rail non-TC
>    driver configuration."
> 
> Could you please review this v2 dt-bindings patch and provide your
> Acked-by if it looks good to you?

Why do you ping few hours after sending a patch? No, I will not Ack it
becuse I have bunch of other patches to do and pinging after few hours
makes a very bad impression. I have two weeks to respond to your patch.

Considering that recently some Renesas contributors did not review patches
still on the list but sent a fix to them, I find your request even less
appropriate. Start reviewing patches on the list.
(above is of course not a request to Renesas maintainers)

> 
> Best Regards
> Dawei Liu
> 
> -----Original Message-----
> From: Dawei Liu 
> Sent: Wednesday, March 18, 2026 10:20 AM


Best regards,
Krzysztof

RE: [PATCH v2 3/3] dt-bindings: hwmon: isl68137: Add compatible strings for RAA228942 and RAA228943

[Dawei Liu]

> Why do you ping few hours after sending a patch? No, I will not Ack
> it because I have bunch of other patches to do and pinging after few
> hours makes a very bad impression. I have two weeks to respond to
> your patch.
>
> Considering that recently some Renesas contributors did not review
> patches still on the list but sent a fix to them, I find your request
> even less appropriate. Start reviewing patches on the list.
> (above is of course not a request to Renesas maintainers)

Hi Krzysztof,

Really sorry for the early ping and top posting. This is my first
time to submit kernel patch and I did not fully follow the submission
rules. Will be more patient next time and will try to review other 
patches on the list.

Best regards,
Dawei Liu

Re: [PATCH v2 3/3] dt-bindings: hwmon: isl68137: Add compatible strings for RAA228942 and RAA228943

[Krzysztof Kozlowski]

On 2026-03-18 10:19 +0800, Dawei Liu wrote:
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> index ae23a0537..53d07c0ce 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> @@ -56,6 +56,8 @@ properties:
>        - renesas,raa228228
>        - renesas,raa228244
>        - renesas,raa228246
> +      - renesas,raa228942
> +      - renesas,raa228943

If they are compatible, maybe finally this binding should switch to
representing this with fallback?

Best regards,
Krzysztof

RE: [PATCH v2 3/3] dt-bindings: hwmon: isl68137: Add compatible strings for RAA228942 and RAA228943

[Dawei Liu]

> If they are compatible, maybe finally this binding should switch to representing this with fallback?

These chips have different hardware interfaces and
feature sets compared to existing family members,
requiring separate compatible strings for correct
hardware identification.

I have sent v3 with an updated commit message to
better reflect this.


Best regards,
Dawei Liu

Re: [PATCH v2 3/3] dt-bindings: hwmon: isl68137: Add compatible strings for RAA228942 and RAA228943

[Krzysztof Kozlowski]

On 23/03/2026 05:22, Dawei Liu wrote:
>> If they are compatible, maybe finally this binding should switch to representing this with fallback?
> 
> These chips have different hardware interfaces and
> feature sets compared to existing family members,
> requiring separate compatible strings for correct
> hardware identification.

Really? I see that you do not use the different compatible at all and
they look completely compatible.

Best regards,
Krzysztof