[PATCH 0/2] Label the fans on Kobol Helios64

[PATCH 0/2] Label the fans on Kobol Helios64

[Igor Velkov via B4 Relay]

Helios64 has two identical PWM fans, and userspace can tell them apart
only by their platform device names. Patch 1 makes pwm-fan.yaml
reference fan-common.yaml, as Rob suggested, which also allows label;
the hwmon core already exposes it as the label attribute. Patch 2 names
the fans after their headers, P6 and P7.

To: Guenter Roeck <linux@roeck-us.net>
To: Jean Delvare <jdelvare@suse.com>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-hwmon@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-kernel@vger.kernel.org

Signed-off-by: Igor Velkov <iav@iav.lv>
---
Igor Velkov (2):
      dt-bindings: hwmon: pwm-fan: Reference the common fan schema
      arm64: dts: rockchip: Label the fans on Kobol Helios64

 .../devicetree/bindings/hwmon/pwm-fan.yaml         | 22 +++++-----------------
 .../boot/dts/rockchip/rk3399-kobol-helios64.dts    |  4 ++--
 2 files changed, 7 insertions(+), 19 deletions(-)
---
base-commit: d2abcbb905b0e4b2e06b257fa1e5bcf4faa6dbda
change-id: 20261018-helios64-fan-label-a173ae71bebe

Best regards,
-- 
Igor Velkov <iav@iav.lv>

[PATCH 1/2] dt-bindings: hwmon: pwm-fan: Reference the common fan schema

[Igor Velkov via B4 Relay]

From: Igor Velkov <iav@iav.lv>

pwm-fan predates fan-common.yaml and repeats several of its properties.
Reference the common schema, drop the duplicated properties and keep
only the constraints specific to PWM fans.

This also allows label, which the hwmon core exposes as the label
attribute.

Link: https://lore.kernel.org/r/20250106173805.GA501301-robh@kernel.org
Assisted-by: LLM
Signed-off-by: Igor Velkov <iav@iav.lv>
---
 .../devicetree/bindings/hwmon/pwm-fan.yaml         | 22 +++++-----------------
 1 file changed, 5 insertions(+), 17 deletions(-)

diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
index 6a24851fd80d..b5407ed52976 100644
--- a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
+++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
@@ -10,19 +10,18 @@ maintainers:
   - Jean Delvare <jdelvare@suse.com>
   - Guenter Roeck <linux@roeck-us.net>
 
+allOf:
+  - $ref: fan-common.yaml#
+
 properties:
   compatible:
     const: pwm-fan
 
   cooling-levels:
     description: PWM duty cycle values corresponding to thermal cooling states.
-    $ref: /schemas/types.yaml#/definitions/uint32-array
     items:
       maximum: 255
 
-  fan-supply:
-    description: Phandle to the regulator that provides power to the fan.
-
   interrupts:
     description:
       This contains an interrupt specifier for each fan tachometer output
@@ -51,26 +50,14 @@ properties:
       Time to wait in microseconds after start when stopped.
 
   pulses-per-revolution:
-    description:
-      Define the number of pulses per fan revolution for each tachometer
-      input as an integer.
-    $ref: /schemas/types.yaml#/definitions/uint32
     minimum: 1
-    maximum: 4
     default: 2
 
-  pwms:
-    description: The PWM that is used to control the fan.
-    maxItems: 1
-
-  "#cooling-cells":
-    const: 2
-
 required:
   - compatible
   - pwms
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
@@ -114,4 +101,5 @@ examples:
       interrupt-parent = <&gpio5>;
       interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
       pulses-per-revolution = <2>;
+      label = "CPU fan";
     };

-- 
2.43.0

Re: [PATCH 1/2] dt-bindings: hwmon: pwm-fan: Reference the common fan schema

[sashiko-bot]

> From: Igor Velkov <iav@iav.lv>
> 
> pwm-fan predates fan-common.yaml and repeats several of its properties.
> Reference the common schema, drop the duplicated properties and keep
> only the constraints specific to PWM fans.
> 
> This also allows label, which the hwmon core exposes as the label
> attribute.
> 
> Link: https://lore.kernel.org/r/20250106173805.GA501301-robh@kernel.org
> Assisted-by: LLM
> Signed-off-by: Igor Velkov <iav@iav.lv>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261018-helios64-fan-label-v1-0-69a3f96d4efa@iav.lv?part=1

[PATCH 2/2] arm64: dts: rockchip: Label the fans on Kobol Helios64

[Igor Velkov via B4 Relay]

From: Igor Velkov <iav@iav.lv>

Name each fan after the header it plugs into, so that userspace can
tell the two apart through the hwmon label attribute.

Assisted-by: LLM
Signed-off-by: Igor Velkov <iav@iav.lv>
---
 arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
index 63ad79b4c8ac..a206827903e9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
@@ -70,8 +70,8 @@ clkin_gmac: external-gmac-clock {
 	};
 
 	fan1 {
-		/* fan connected to P7 */
 		compatible = "pwm-fan";
+		label = "P7";
 		pwms = <&pwm0 0 40000 0>;
 		cooling-levels = <0 80 170 255>;
 		interrupt-parent = <&gpio4>;
@@ -81,8 +81,8 @@ fan1 {
 	};
 
 	fan2 {
-		/* fan connected to P6 */
 		compatible = "pwm-fan";
+		label = "P6";
 		pwms = <&pwm1 0 40000 0>;
 		cooling-levels = <0 80 170 255>;
 		interrupt-parent = <&gpio4>;

-- 
2.43.0

Re: [PATCH 2/2] arm64: dts: rockchip: Label the fans on Kobol Helios64

[sashiko-bot]

> From: Igor Velkov <iav@iav.lv>
> 
> Name each fan after the header it plugs into, so that userspace can
> tell the two apart through the hwmon label attribute.
> 
> Assisted-by: LLM
> Signed-off-by: Igor Velkov <iav@iav.lv>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261018-helios64-fan-label-v1-0-69a3f96d4efa@iav.lv?part=2