From: sashiko-bot@kernel.org
To: "Samuel Herdman" <lk.gzpc0@passmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (nct6683) Add customer ID for ASRock X600DC-ITX
Date: Sat, 14 Nov 2026 09:39:13 +0000 [thread overview]
Message-ID: <sashiko-outbox-214331@kernel.org> (raw)
In-Reply-To: <20261114-nct6683-asrock-x600dc-itx-v1-1-cbccf1a627fe@passmail.com>
> From: Samuel Herdman <lk.gzpc0@passmail.com>
>
> The ASRock X600DC-ITX (BIOS 2.02) has an NCT6686D with customer ID
> 0x165f, which the driver does not know, so it only binds with force=1:
>
> nct6683: Found NCT6686D or compatible chip at 0x2e:0xa20
> nct6683 nct6683.2592: Enabling support for unknown customer ID 0x165f
> nct6683 nct6683.2592: NCT6686D EC firmware version 1.0 build 12/23/25
>
> The change:
>
> Add the customer ID so the driver binds on this board without force=1,
> and add the board to the list of tested boards.
>
> Tests:
>
> - With force=1 the readings are plausible: the CPU temperature (AMD TSI
> Addr 98h) is within a few degrees of k10temp's Tctl, VCC, VSB and
> AVSB read 3.36 V, VBAT reads 3.2 V, and fan1 reads about 1450 RPM.
> - With the same change applied to v7.3.3 on this board, the driver
> binds without force=1 and reports temperature and fan readings.
>
> The patch and this changelog were drafted with an AI coding assistant
> (Claude Code); I reviewed them and ran the tests above on my board.
>
> Signed-off-by: Samuel Herdman <lk.gzpc0@passmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261114-nct6683-asrock-x600dc-itx-v1-1-cbccf1a627fe@passmail.com?part=1
prev parent reply other threads:[~2026-11-14 9:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 9:37 [PATCH] hwmon: (nct6683) Add customer ID for ASRock X600DC-ITX Samuel Herdman via B4 Relay
2026-11-14 9:39 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-214331@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=lk.gzpc0@passmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox