Linux Hardware Monitor development
 help / color / mirror / Atom feed
* [PATCH] hwmon: (nct6683) Add customer ID for ASRock X600DC-ITX
@ 2026-11-14  9:37 Samuel Herdman via B4 Relay
  2026-11-14  9:39 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Samuel Herdman via B4 Relay @ 2026-11-14  9:37 UTC (permalink / raw)
  To: Guenter Roeck, Jonathan Corbet, Shuah Khan, Randy Dunlap
  Cc: linux-hwmon, linux-doc, linux-kernel, Johan Dahlin,
	Samuel Herdman

From: Samuel Herdman <lk.gzpc0@passmail.com>

The ASRock X600DC-ITX (BIOS 2.02) has an NCT6686D with customer ID
0x165f, which the driver does not know, so it only binds with force=1:

  nct6683: Found NCT6686D or compatible chip at 0x2e:0xa20
  nct6683 nct6683.2592: Enabling support for unknown customer ID 0x165f
  nct6683 nct6683.2592: NCT6686D EC firmware version 1.0 build 12/23/25

The change:

Add the customer ID so the driver binds on this board without force=1,
and add the board to the list of tested boards.

Tests:

- With force=1 the readings are plausible: the CPU temperature (AMD TSI
  Addr 98h) is within a few degrees of k10temp's Tctl, VCC, VSB and
  AVSB read 3.36 V, VBAT reads 3.2 V, and fan1 reads about 1450 RPM.
- With the same change applied to v7.3.3 on this board, the driver
  binds without force=1 and reports temperature and fan readings.

The patch and this changelog were drafted with an AI coding assistant
(Claude Code); I reviewed them and ran the tests above on my board.

Signed-off-by: Samuel Herdman <lk.gzpc0@passmail.com>
---
This overlaps with Johan Dahlin's pending series "hwmon: (nct6683) Fan
control and sensor names for ASRock NCT6686D boards" (v2, 11 Nov 2026).
Its first patch also adds NCT6683_CUSTOMER_ID_ASROCK8 (0x164a) and a
table row at the same spot, and its later patches key fan control on
that macro. Whichever lands second needs its macro renumbered
throughout; I'm happy to rebase on top of that series if preferred.
---
 Documentation/hwmon/nct6683.rst | 1 +
 drivers/hwmon/nct6683.c         | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/Documentation/hwmon/nct6683.rst b/Documentation/hwmon/nct6683.rst
index 62da8fd01..e2e95a33e 100644
--- a/Documentation/hwmon/nct6683.rst
+++ b/Documentation/hwmon/nct6683.rst
@@ -97,6 +97,7 @@ ASRock X570			NCT6683D EC firmware version 1.0 build 06/28/19
 ASRock X670E			NCT6686D EC firmware version 1.0 build 05/19/22
 ASRock B650 Steel Legend WiFi	NCT6686D EC firmware version 1.0 build 11/09/23
 ASRock Z590 Taichi		NCT6686D EC firmware version 1.0 build 01/25/21
+ASRock X600DC-ITX		NCT6686D EC firmware version 1.0 build 12/23/25
 MSI B550			NCT6687D EC firmware version 1.0 build 05/07/20
 MSI B550M			NCT6687D EC firmware version 1.0 build 05/07/20
 MSI B650			NCT6687D EC firmware version 0.0 build 09/27/22
diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
index de5b0194c..01784fa6a 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -209,6 +209,7 @@ superio_exit(int ioreg)
 #define NCT6683_CUSTOMER_ID_ASROCK5	0x1621
 #define NCT6683_CUSTOMER_ID_ASROCK6	0x1633
 #define NCT6683_CUSTOMER_ID_ASROCK7	0x163d
+#define NCT6683_CUSTOMER_ID_ASROCK8	0x165f
 
 #define NCT6683_REG_BUILD_YEAR		0x604
 #define NCT6683_REG_BUILD_MONTH		0x605
@@ -1640,6 +1641,8 @@ static int nct6683_probe(struct platform_device *pdev)
 		break;
 	case NCT6683_CUSTOMER_ID_ASROCK7:
 		break;
+	case NCT6683_CUSTOMER_ID_ASROCK8:
+		break;
 	default:
 		if (!force)
 			return -ENODEV;

---
base-commit: f9f5501d60c77c71f60bf5b273375e3777d66080
change-id: 20261114-nct6683-asrock-x600dc-itx-3d17b409d353

Best regards,
--  
Samuel Herdman <lk.gzpc0@passmail.com>



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-14  9:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-14  9:37 [PATCH] hwmon: (nct6683) Add customer ID for ASRock X600DC-ITX Samuel Herdman via B4 Relay
2026-11-14  9:39 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox