Linux Hardware Monitor development
 help / color / mirror / Atom feed
* [PATCH v3 0/2] hwmon: simatic-ipc-ec-sensors: add BX-54A EC driver
@ 2026-11-19 16:47 Benedikt Niedermayr
  2026-11-19 16:47 ` [PATCH v3 1/2] " Benedikt Niedermayr
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Benedikt Niedermayr @ 2026-11-19 16:47 UTC (permalink / raw)
  To: linux; +Cc: linux-hwmon

Hi,

this patch adds a hardware monitoring driver for the embedded controller on
Siemens SIMATIC IPC BX-54A systems.

The driver loads directly via ACPI "_HID" which is reserved for Siemens.
See commit for more information.

I'm not the original author of this driver but I reviewed it as carefully as
possible and I would step in as maintainer for it.

This patch does not enable the hardware platform on which this controller is
present.
Instead I just routed the enablement through the i2c tree, which is currently
in review [1].
I wasn't expecting the review to take that long, so it's maybe better to route
the platform enablements through this tree instead... I dont know...


changes since v2:

- fix: shared mutable temp config array in simatic_ipc_ec_hwmon_probe()
  Switched to a dynamic allocation approach for the temperature channels


changes since v1:

- fix typo (drviers -> drivers) in a comment
- improve fan speed decoding (my own AI finding -> considers little-endian)
- Sashiko review:
  - add documentation leaning a bit towards asus_ec_sensors.rst
  - sanitize chip_name in simatic_ipc_ec_fan_probe()
  - temp channel config: Move to a static approach.
    Use a static array sized for the maximum number of channels that fit into
    the 256 byte EC address space.
    Also reject configurations (from the firmware) that exceed this limit.
    IMHO this was only a theoretical issue since there is only a single EC.
  - fix uninitialized reads on ec_read()
  - validate pwm_enable
  - clamp before cast in simatic_ipc_ec_temp_write()
  - fix pointer-sign mismatch passing s8 to ec_read()
  - fix wrong assignment to temp*_min_alarm and temp*_max_alarm


[1] https://patchwork.ozlabs.org/project/linux-i2c/patch/20261116142351.1228943-4-benedikt.niedermayr@siemens.com/

Best regards,
Benedikt

Benedikt Niedermayr (2):
  hwmon: simatic-ipc-ec-sensors: add BX-54A EC driver
  docs: hwmon: introduce simatic-ipc-ec-sensors

 Documentation/hwmon/index.rst                 |   1 +
 .../hwmon/simatic-ipc-ec-sensors.rst          |  64 ++
 MAINTAINERS                                   |   7 +
 drivers/hwmon/Kconfig                         |  11 +
 drivers/hwmon/Makefile                        |   1 +
 drivers/hwmon/simatic-ipc-ec-sensors.c        | 567 ++++++++++++++++++
 6 files changed, 651 insertions(+)
 create mode 100644 Documentation/hwmon/simatic-ipc-ec-sensors.rst
 create mode 100644 drivers/hwmon/simatic-ipc-ec-sensors.c

--
2.43.0

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2026-11-19 17:47 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 16:47 [PATCH v3 0/2] hwmon: simatic-ipc-ec-sensors: add BX-54A EC driver Benedikt Niedermayr
2026-11-19 16:47 ` [PATCH v3 1/2] " Benedikt Niedermayr
2026-11-19 17:00   ` sashiko-bot
2026-11-19 17:19   ` Guenter Roeck
2026-11-19 17:47     ` Niedermayr, Benedikt
2026-11-19 16:47 ` [PATCH v3 2/2] docs: hwmon: introduce simatic-ipc-ec-sensors Benedikt Niedermayr
2026-11-19 16:52   ` sashiko-bot
2026-11-19 17:10 ` [PATCH v3 0/2] hwmon: simatic-ipc-ec-sensors: add BX-54A EC driver Guenter Roeck
2026-11-19 17:20   ` Niedermayr, Benedikt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox