* [PATCH -next] hv: hyperv.h: Remove unused extern declaration vmbus_ontimer()
@ 2023-07-25 13:58 YueHaibing
2023-07-25 14:12 ` Michael Kelley (LINUX)
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2023-07-25 13:58 UTC (permalink / raw)
To: kys, haiyangz, wei.liu, decui; +Cc: linux-hyperv, linux-kernel, YueHaibing
Since commit 30fbee49b071 ("Staging: hv: vmbus: Get rid of the unused function vmbus_ontimer()")
this is not used anymore, so can remove it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
include/linux/hyperv.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index bfbc37ce223b..3ac3974b3c78 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -1239,9 +1239,6 @@ extern int vmbus_recvpacket_raw(struct vmbus_channel *channel,
u32 *buffer_actual_len,
u64 *requestid);
-
-extern void vmbus_ontimer(unsigned long data);
-
/* Base driver object */
struct hv_driver {
const char *name;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH -next] hv: hyperv.h: Remove unused extern declaration vmbus_ontimer()
2023-07-25 13:58 [PATCH -next] hv: hyperv.h: Remove unused extern declaration vmbus_ontimer() YueHaibing
@ 2023-07-25 14:12 ` Michael Kelley (LINUX)
2023-07-25 14:17 ` YueHaibing
0 siblings, 1 reply; 3+ messages in thread
From: Michael Kelley (LINUX) @ 2023-07-25 14:12 UTC (permalink / raw)
To: YueHaibing, KY Srinivasan, Haiyang Zhang, wei.liu@kernel.org,
Dexuan Cui
Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
From: YueHaibing <yuehaibing@huawei.com> Sent: Tuesday, July 25, 2023 6:59 AM
>
I'd suggest using "Drivers: hv: vmbus:" as the prefix in the commit message Subject.
I see that "hv: hyperv.h:" has been used a few times in the past, but my suggestion
is much more commonly used and would give better overall consistency.
> Since commit 30fbee49b071 ("Staging: hv: vmbus: Get rid of the unused function
> vmbus_ontimer()")
> this is not used anymore, so can remove it.
Indeed, yes!
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> include/linux/hyperv.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
> index bfbc37ce223b..3ac3974b3c78 100644
> --- a/include/linux/hyperv.h
> +++ b/include/linux/hyperv.h
> @@ -1239,9 +1239,6 @@ extern int vmbus_recvpacket_raw(struct vmbus_channel
> *channel,
> u32 *buffer_actual_len,
> u64 *requestid);
>
> -
> -extern void vmbus_ontimer(unsigned long data);
> -
> /* Base driver object */
> struct hv_driver {
> const char *name;
> --
> 2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] hv: hyperv.h: Remove unused extern declaration vmbus_ontimer()
2023-07-25 14:12 ` Michael Kelley (LINUX)
@ 2023-07-25 14:17 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2023-07-25 14:17 UTC (permalink / raw)
To: Michael Kelley (LINUX), KY Srinivasan, Haiyang Zhang,
wei.liu@kernel.org, Dexuan Cui
Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
On 2023/7/25 22:12, Michael Kelley (LINUX) wrote:
> From: YueHaibing <yuehaibing@huawei.com> Sent: Tuesday, July 25, 2023 6:59 AM
>>
>
> I'd suggest using "Drivers: hv: vmbus:" as the prefix in the commit message Subject.
> I see that "hv: hyperv.h:" has been used a few times in the past, but my suggestion
> is much more commonly used and would give better overall consistency.
Ok, will send v2.
>
>> Since commit 30fbee49b071 ("Staging: hv: vmbus: Get rid of the unused function
>> vmbus_ontimer()")
>> this is not used anymore, so can remove it.
>
> Indeed, yes!
>
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
>
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> include/linux/hyperv.h | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
>> index bfbc37ce223b..3ac3974b3c78 100644
>> --- a/include/linux/hyperv.h
>> +++ b/include/linux/hyperv.h
>> @@ -1239,9 +1239,6 @@ extern int vmbus_recvpacket_raw(struct vmbus_channel
>> *channel,
>> u32 *buffer_actual_len,
>> u64 *requestid);
>>
>> -
>> -extern void vmbus_ontimer(unsigned long data);
>> -
>> /* Base driver object */
>> struct hv_driver {
>> const char *name;
>> --
>> 2.34.1
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-25 14:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-25 13:58 [PATCH -next] hv: hyperv.h: Remove unused extern declaration vmbus_ontimer() YueHaibing
2023-07-25 14:12 ` Michael Kelley (LINUX)
2023-07-25 14:17 ` YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox