[PATCH 1/1] scsi: storvsc: Handle additional SRB status values

[PATCH 1/1] scsi: storvsc: Handle additional SRB status values

[Michael Kelley]

Testing of virtual fibre channel devices under Hyper-V has
shown additional SRB status values being returned for various
error cases.  Because these SRB status values are not
recognized by storvsc, the I/O operations are not flagged as
an error. Request are treated as if they completed normally
but with zero data transferred, which can cause a flood of
retries.

Add definitions for these SRB status values and handle them
like other error statuses from the Hyper-V host.

Signed-off-by: Michael Kelley <mikelley@microsoft.com>
---
 drivers/scsi/storvsc_drv.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 7e92a48..ab286c1 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -316,6 +316,9 @@ enum storvsc_request_type {
 #define SRB_STATUS_ABORTED		0x02
 #define SRB_STATUS_ERROR		0x04
 #define SRB_STATUS_INVALID_REQUEST	0x06
+#define SRB_STATUS_TIMEOUT		0x09
+#define SRB_STATUS_SELECTION_TIMEOUT	0x0A
+#define SRB_STATUS_BUS_RESET		0x0E
 #define SRB_STATUS_DATA_OVERRUN		0x12
 #define SRB_STATUS_INVALID_LUN		0x20
 #define SRB_STATUS_INTERNAL_ERROR	0x30
@@ -980,6 +983,10 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb,
 	case SRB_STATUS_ABORTED:
 	case SRB_STATUS_INVALID_REQUEST:
 	case SRB_STATUS_INTERNAL_ERROR:
+	case SRB_STATUS_TIMEOUT:
+	case SRB_STATUS_SELECTION_TIMEOUT:
+	case SRB_STATUS_BUS_RESET:
+	case SRB_STATUS_DATA_OVERRUN:
 		if (vm_srb->srb_status & SRB_STATUS_AUTOSENSE_VALID) {
 			/* Check for capacity change */
 			if ((asc == 0x2a) && (ascq == 0x9)) {
-- 
1.8.3.1

Re: [PATCH 1/1] scsi: storvsc: Handle additional SRB status values

[Martin K. Petersen]

Michael,

> Testing of virtual fibre channel devices under Hyper-V has shown
> additional SRB status values being returned for various error cases.
> Because these SRB status values are not recognized by storvsc, the I/O
> operations are not flagged as an error. Request are treated as if they
> completed normally but with zero data transferred, which can cause a
> flood of retries.
>
> Add definitions for these SRB status values and handle them like other
> error statuses from the Hyper-V host.

Applied to 6.5/scsi-fixes, thanks!

[1/1] scsi: storvsc: Handle additional SRB status values
      https://git.kernel.org/mkp/scsi/c/812fe6420a6e

-- 
Martin K. Petersen	Oracle Linux Engineering