From: Wei Liu <wei.liu@kernel.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Wei Liu <wei.liu@kernel.org>,
Linux on Hyper-V List <linux-hyperv@vger.kernel.org>,
Linux Kernel List <linux-kernel@vger.kernel.org>,
Linux Kconfig List <linux-kbuild@vger.kernel.org>,
Wei Liu <liuwe@microsoft.com>
Subject: Re: [PATCH RFC] kconfig: add hvconfig for Linux on Hyper-V
Date: Tue, 8 Oct 2019 17:10:01 +0100 [thread overview]
Message-ID: <20191008161001.lwiduq4mlyjumw5b@debian> (raw)
In-Reply-To: <CAK7LNAQpszkwtp2mAfoPajkRi0SHPspivWn9sUsxO0oua2X6NQ@mail.gmail.com>
On Wed, Oct 09, 2019 at 01:03:19AM +0900, Masahiro Yamada wrote:
[...]
> > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
> > index ef2f2336c469..2ee46301b22e 100644
> > --- a/scripts/kconfig/Makefile
> > +++ b/scripts/kconfig/Makefile
> > @@ -104,6 +104,10 @@ PHONY += xenconfig
> > xenconfig: xen.config
> > @:
> >
> > +PHONY += hvconfig
> > +hvconfig: hv_guest.config
> > + @:
> > +
>
>
> Does this need to be hooked up to kconfig Makefile?
>
It is not strictly necessary. Just thought it would be nice to follow
existing examples.
> In my understanding, this code provides
> "make hvconfig" as a shorthand for "make hv_guest.config"
>
Yes that's correct.
> Please do not do this.
>
>
> See "xenconfig" as a bad example.
>
> "make xenconfig" is a shorthand of "make xen.config".
> This exists to save just one character typing.
>
>
> If I allow this, people would push more and more random pointless shorthands,
> which are essentially unrelated to kconfig.
>
>
> kvmconfig and xenconfig are just historical mistakes.
>
>
> Please drop the changes to scripts/kconfig/Makefile.
OK.
>
> Also, please do not use misleading "kconfig:" for the subject prefix.
> You can use the subject prefix "hyper-v:" or something.
>
OK.
Wei.
prev parent reply other threads:[~2019-10-08 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 13:15 [PATCH RFC] kconfig: add hvconfig for Linux on Hyper-V Wei Liu
2019-10-08 16:03 ` Masahiro Yamada
2019-10-08 16:10 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008161001.lwiduq4mlyjumw5b@debian \
--to=wei.liu@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuwe@microsoft.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox