From: Wei Liu <wei.liu@kernel.org>
To: Michael Kelley <mikelley@microsoft.com>
Cc: YueHaibing <yuehaibing@huawei.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] hv_debugfs: Make hv_debug_root static
Date: Sat, 4 Apr 2020 17:48:24 +0100 [thread overview]
Message-ID: <20200404164824.yu3ye46ykwotc3ej@debian> (raw)
In-Reply-To: <MW2PR2101MB105222D949FB4944EE647F2FD7C70@MW2PR2101MB1052.namprd21.prod.outlook.com>
On Fri, Apr 03, 2020 at 12:21:47PM +0000, Michael Kelley wrote:
> From: YueHaibing <yuehaibing@huawei.com> Sent: Friday, April 3, 2020 1:29 AM
> >
> > Fix sparse warning:
> >
> > drivers/hv/hv_debugfs.c:14:15: warning: symbol 'hv_debug_root' was not declared. Should
> > it be static?
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> > drivers/hv/hv_debugfs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hv/hv_debugfs.c b/drivers/hv/hv_debugfs.c
> > index 8a2878573582..ccf752b6659a 100644
> > --- a/drivers/hv/hv_debugfs.c
> > +++ b/drivers/hv/hv_debugfs.c
> > @@ -11,7 +11,7 @@
> >
> > #include "hyperv_vmbus.h"
> >
> > -struct dentry *hv_debug_root;
> > +static struct dentry *hv_debug_root;
> >
> > static int hv_debugfs_delay_get(void *data, u64 *val)
> > {
> > --
> > 2.17.1
> >
>
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
>
Queued. Thanks.
prev parent reply other threads:[~2020-04-04 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 8:28 [PATCH -next] hv_debugfs: Make hv_debug_root static YueHaibing
2020-04-03 12:21 ` Michael Kelley
2020-04-04 16:48 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200404164824.yu3ye46ykwotc3ej@debian \
--to=wei.liu@kernel.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox