* [PATCH -next] hv_debugfs: Make hv_debug_root static
@ 2020-04-03 8:28 YueHaibing
2020-04-03 12:21 ` Michael Kelley
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2020-04-03 8:28 UTC (permalink / raw)
To: kys, haiyangz, sthemmin, wei.liu; +Cc: linux-hyperv, linux-kernel, YueHaibing
Fix sparse warning:
drivers/hv/hv_debugfs.c:14:15: warning: symbol 'hv_debug_root' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/hv/hv_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hv/hv_debugfs.c b/drivers/hv/hv_debugfs.c
index 8a2878573582..ccf752b6659a 100644
--- a/drivers/hv/hv_debugfs.c
+++ b/drivers/hv/hv_debugfs.c
@@ -11,7 +11,7 @@
#include "hyperv_vmbus.h"
-struct dentry *hv_debug_root;
+static struct dentry *hv_debug_root;
static int hv_debugfs_delay_get(void *data, u64 *val)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH -next] hv_debugfs: Make hv_debug_root static
2020-04-03 8:28 [PATCH -next] hv_debugfs: Make hv_debug_root static YueHaibing
@ 2020-04-03 12:21 ` Michael Kelley
2020-04-04 16:48 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Michael Kelley @ 2020-04-03 12:21 UTC (permalink / raw)
To: YueHaibing, KY Srinivasan, Haiyang Zhang, Stephen Hemminger,
wei.liu@kernel.org
Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
From: YueHaibing <yuehaibing@huawei.com> Sent: Friday, April 3, 2020 1:29 AM
>
> Fix sparse warning:
>
> drivers/hv/hv_debugfs.c:14:15: warning: symbol 'hv_debug_root' was not declared. Should
> it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/hv/hv_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hv/hv_debugfs.c b/drivers/hv/hv_debugfs.c
> index 8a2878573582..ccf752b6659a 100644
> --- a/drivers/hv/hv_debugfs.c
> +++ b/drivers/hv/hv_debugfs.c
> @@ -11,7 +11,7 @@
>
> #include "hyperv_vmbus.h"
>
> -struct dentry *hv_debug_root;
> +static struct dentry *hv_debug_root;
>
> static int hv_debugfs_delay_get(void *data, u64 *val)
> {
> --
> 2.17.1
>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] hv_debugfs: Make hv_debug_root static
2020-04-03 12:21 ` Michael Kelley
@ 2020-04-04 16:48 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2020-04-04 16:48 UTC (permalink / raw)
To: Michael Kelley
Cc: YueHaibing, KY Srinivasan, Haiyang Zhang, Stephen Hemminger,
wei.liu@kernel.org, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org
On Fri, Apr 03, 2020 at 12:21:47PM +0000, Michael Kelley wrote:
> From: YueHaibing <yuehaibing@huawei.com> Sent: Friday, April 3, 2020 1:29 AM
> >
> > Fix sparse warning:
> >
> > drivers/hv/hv_debugfs.c:14:15: warning: symbol 'hv_debug_root' was not declared. Should
> > it be static?
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> > drivers/hv/hv_debugfs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hv/hv_debugfs.c b/drivers/hv/hv_debugfs.c
> > index 8a2878573582..ccf752b6659a 100644
> > --- a/drivers/hv/hv_debugfs.c
> > +++ b/drivers/hv/hv_debugfs.c
> > @@ -11,7 +11,7 @@
> >
> > #include "hyperv_vmbus.h"
> >
> > -struct dentry *hv_debug_root;
> > +static struct dentry *hv_debug_root;
> >
> > static int hv_debugfs_delay_get(void *data, u64 *val)
> > {
> > --
> > 2.17.1
> >
>
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
>
Queued. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-04 16:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-03 8:28 [PATCH -next] hv_debugfs: Make hv_debug_root static YueHaibing
2020-04-03 12:21 ` Michael Kelley
2020-04-04 16:48 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox