* [PATCH] HID: hyperv: fix possible memory leak in mousevsc_probe()
@ 2022-10-28 13:40 Yang Yingliang
2022-11-01 10:45 ` Wei Liu
2022-11-02 13:34 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2022-10-28 13:40 UTC (permalink / raw)
To: linux-input, linux-hyperv
Cc: kys, haiyangz, sthemmin, wei.liu, jkosina, yangyingliang
If hid_add_device() returns error, it should call hid_destroy_device()
to free hid_dev which is allocated in hid_allocate_device().
Fixes: 74c4fb058083 ("HID: hv_mouse: Properly add the hid device")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/hid/hid-hyperv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
index e0bc73124196..ab57b49a44ed 100644
--- a/drivers/hid/hid-hyperv.c
+++ b/drivers/hid/hid-hyperv.c
@@ -499,7 +499,7 @@ static int mousevsc_probe(struct hv_device *device,
ret = hid_add_device(hid_dev);
if (ret)
- goto probe_err1;
+ goto probe_err2;
ret = hid_parse(hid_dev);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] HID: hyperv: fix possible memory leak in mousevsc_probe()
2022-10-28 13:40 [PATCH] HID: hyperv: fix possible memory leak in mousevsc_probe() Yang Yingliang
@ 2022-11-01 10:45 ` Wei Liu
2022-11-02 13:34 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2022-11-01 10:45 UTC (permalink / raw)
To: Yang Yingliang
Cc: linux-input, linux-hyperv, kys, haiyangz, sthemmin, wei.liu,
jkosina
On Fri, Oct 28, 2022 at 09:40:43PM +0800, Yang Yingliang wrote:
> If hid_add_device() returns error, it should call hid_destroy_device()
> to free hid_dev which is allocated in hid_allocate_device().
>
> Fixes: 74c4fb058083 ("HID: hv_mouse: Properly add the hid device")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Wei Liu <wei.liu@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] HID: hyperv: fix possible memory leak in mousevsc_probe()
2022-10-28 13:40 [PATCH] HID: hyperv: fix possible memory leak in mousevsc_probe() Yang Yingliang
2022-11-01 10:45 ` Wei Liu
@ 2022-11-02 13:34 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2022-11-02 13:34 UTC (permalink / raw)
To: Yang Yingliang
Cc: linux-input, linux-hyperv, kys, haiyangz, sthemmin, wei.liu
On Fri, 28 Oct 2022, Yang Yingliang wrote:
> If hid_add_device() returns error, it should call hid_destroy_device()
> to free hid_dev which is allocated in hid_allocate_device().
>
> Fixes: 74c4fb058083 ("HID: hv_mouse: Properly add the hid device")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/hid/hid-hyperv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
> index e0bc73124196..ab57b49a44ed 100644
> --- a/drivers/hid/hid-hyperv.c
> +++ b/drivers/hid/hid-hyperv.c
> @@ -499,7 +499,7 @@ static int mousevsc_probe(struct hv_device *device,
>
> ret = hid_add_device(hid_dev);
> if (ret)
> - goto probe_err1;
> + goto probe_err2;
>
Good catch, applied, thank you.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-02 13:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-28 13:40 [PATCH] HID: hyperv: fix possible memory leak in mousevsc_probe() Yang Yingliang
2022-11-01 10:45 ` Wei Liu
2022-11-02 13:34 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox